[RESOLVED] help with update script

[snoopgreen]

Hello everyone

I was hoping someone may offer me some advice / help

Its with the script below

$db = mysql_connect("anubis.sunderland.ac.uk","cs0cge","Sp1tfire");
mysql_select_db("cs0cge", $db);
if (isset ($_POST['Submit'])) { // checking if submit button has been pressed

extract($_POST);  // extracts the POST data

// cleans up and makes safe database input
$external_id = mysql_real_escape_string(trim($external_id));
$ExtName = mysql_real_escape_string(trim($ExtName));
$ContactDetails = mysql_real_escape_string(trim($ContactDetails));
$Email = mysql_real_escape_string(trim($Email));
$Tele = mysql_real_escape_string(trim($Tele));
$presOrgan = mysql_real_escape_string(trim($presOrgan));
$start = mysql_real_escape_string(trim($start));
$finish = mysql_real_escape_string(trim($finish));
$date = mysql_real_escape_string(trim($date));
$radiobutton = mysql_real_escape_string(trim($radiobutton));


if (!$external_id || !$ExtName || !$ContactDetails || !$Email || !$Tele || !$presOrgan || !$start || !$finish || !$date) { // checking to make sure all the form fields have values
				$error = "Sorry, You havent entered data in all the fields!<br><BR>";	// if some field values are missing outputs this error message
	} else { // if every field has value it runs the SQL query and updates the database
$result = mysql_query("UPDATE external_examiners, prog_externals, external_visits SET external_examiners.name='$ExtName', external_examiners.contact_details='$ContactDetails',
			external_examiners.email_address='$Email', external_examiners.tele_num='$Tele', external_examiners.pres_organisation='$presOrgan', prog_externals.start_date='$start', 
			prog_externals.finish_date='$finish', external_visits.date='$date', external_visits.ext_report='$radiobutton'
		WHERE external_examiners.external_id = '" . $external_id ."'
		AND prog_externals.external_id = '" . $external_id . "'
		AND external_visits.external_id = '" . $external_id . "'",$db)or die ('MySQL Error: ' . mysql_error()); // if problem within database query outputs SQL error
		echo("<b><br><br>Record Updated</br></br></b>");  
		}
} else {
	if (isset ($error)) {
		echo $error;
	}

  // selecting data from 3 database tables and outputing it on the screen using a While loop
	$result = mysql_query("SELECT * FROM external_examiners, prog_externals, external_visits WHERE external_examiners.external_id = prog_externals.external_id 
	AND external_examiners.external_id = external_visits.external_id
	ORDER BY external_examiners.external_id", $db) or die ('MYSQL Error: ' . mysql_error());
	While($rec = mysql_fetch_array($result)) {	// While loop outputs the data onto the screen above the update form
	echo("External ID: " . $rec["external_id"] . "<br>\n");
	echo("External Name: " . $rec["name"] . "<br>\n");
	echo("Contact Details: " . $rec["contact_details"] . "<br>\n");
	echo("Email Address: " . $rec["email_address"] . "<br>\n");
	echo("Telephone Number: " . $rec["tele_num"] . "<br>\n");
	echo("Present Organisation: " . $rec["pres_organisation"] . "<br>\n");
	echo("Start Date: " . $rec["start_date"] . "<br>\n");
	echo("Finish Date: " . $rec["finish_date"] . "<br>\n");
	echo("Visit Date: " . $rec["date"] . "<br>\n");
	echo("External Report: " . $rec["ext_report"] . "<br><br>\n");
	}

?>
<P> <!-- A form within a table which user inputs data into -->
<form action = "<?php echo $PHP_SELF  ?>" method="POST">
  <table width="456" border="1">
    <tr> 
      <td colspan="2">External ID:</td>
      <td width="195"><input type="text" name="external_id"></td>
    </tr>
    <tr> 
      <td colspan="2">External Name:</td>
      <td width="195"><input type="text" name="ExtName"></td>
    </tr>
    <tr> 
      <td colspan="2">Contact Details: </td>
      <td><input type="text" name="ContactDetails"></td>
    </tr>
    <tr> 
      <td colspan="2">Email Address: </td>
      <td><input type="text" name="Email"></td>
    </tr>
    <tr> 
      <td colspan="2">Telephone Number: </td>
      <td><input type="text" name="Tele"></td>
    </tr>
    <tr> 
      <td colspan="2">Present Organisation: </td>
      <td><input type="text" name="presOrgan"></td>
    </tr>
    <tr> 
      <td colspan="2">Externals Start Date: </td>
      <td><input type="text" name="start"></td>
    </tr>
    <tr> 
      <td colspan="2">Externals Finish Date: </td>
      <td><input type="text" name="finish"></td>
    </tr>
    <tr> 
      <td colspan="2">Externals Visit Date: </td>
      <td><input type="text" name="date"></td>
    </tr>
    <tr> 
      <td width="157">External Report: </td>
      <td width="82">Yes: 
        <input name="radiobutton" type="radio" value="Yes"> </td>
      <td>No: 
        <input name="radiobutton" type="radio" value="No"> </td>
    </tr>
    <tr> 
      <td colspan="2">&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td colspan="2"><div align="right"> 
          <input type="submit" name="Submit" value="Submit">
        </div></td>
      <td><input type="reset" name="Reset" value="Reset"></td>
    </tr>
  </table>
</form><br>

for some reason my error checking is not working the error message is just not appearing when only a couple fields get values entered

could anyone help me where this script is going wrong?

thanks for any help in advance
snoopgreen