[RESOLVED] Mod Code Error (Help Please)

Rowan06

I just installed a Welcome PM Mod to my phpBB2 forum. After all the installation and uploading etc, I went into my AdminCP to check if it worked. There is a bit there now saying PM Settings, but when I go to it I get this:

http://img135.imageshack.us/img135/3672/welcomepm2yn.jpg

Anyone know how to fix this?? Also I tryed running the wpm_db_update.php file but im getting this:

Parse error: syntax error, unexpected T_STRING in /home/hazard/public_html/wpm_db_update.php on line 66

Anyone know what this is and how to fix it ?? Thanks alot..

thorpe

I would imagine you would get more help on a phpBB help forum. This is akin to asking a Linux question in a C forum.

Rowan06

OK i posted about it on the forum of the coder who made the mod. But ive heard nothing back so far.. does anyone on this maybe know what it could be??

Heres the link to the mod:
http://www.phpbbhacks.com/download/2127

Roger_Ramjet

If you posted the code from that script here I'm sure we could debug it for you - it's a basic syntax error meaning an unclosed bracket or missing string quote. Make sure you mark which is line 66 cos we aint gonna count them.

Rowan06

http://img135.imageshack.us/img135/3672/welcomepm2yn.jpg
OK I opened the admin_wpm.php file and heres a few lines near the line 112 were i says the error is:

$sql = "SELECT *
	FROM " . WPM;
if(!$result = $db->sql_query($sql))
{
	message_die(GENERAL_ERROR, $lang['update_error'], "", __LINE__, __FILE__, $sql);
}
else
{
	while($row = $db->sql_fetchrow($result))

So you know the bit saying "message_die(GENERAL_ERROR, $lang['update_error'], "", LINE, FILE, $sql);" is line 112

Roger_Ramjet

No I meant the wpm_db_update.php script.

"wpm_db_update.php file but im getting this:

Parse error: syntax error, unexpected T_STRING in /home/hazard/public_html/wpm_db_update.php on line 66"

It has not created the table WPM so you get the other error telling you that WPM does not exist. Fix the table create script, run it, and the other problem goes away.

And post the whole script up to and a little beyond line 66.

Rowan06

I got a reply from the mods forums, and he suggested trying the latest version of them. So I got the latest version of the install.php and update.php.. ran them and they worked successfully... but im still gettin that error in the AdminCP so its got to do with fixing that....

anyway... heres the wpm_update.php codes up to line 72

<?php
/***************************************************************************
 *                               wpm_db_update.php
 *                            ----------------------
 *
 * 				copyright	: ©2003, 2005 Duvelske  (duvelske@planet.nl)
 *
 ***************************************************************************/

/***************************************************************************
 *
 *   This program is free software; you can redistribute it and/or modify
 *   it under the terms of the GNU General Public License as published by
 *   the Free Software Foundation; either version 2 of the License, or
 *   (at your option) any later version.
 *
 ***************************************************************************/

define('IN_PHPBB', true);
$phpbb_root_path = './';
include($phpbb_root_path . 'extension.inc');
include($phpbb_root_path . 'common.'.$phpEx);
define('WPM_INST', $table_prefix.'wpm');

//
// Start session management
//
$userdata = session_pagestart($user_ip, PAGE_INDEX);
init_userprefs($userdata);
//
// End session management
//


if( !$userdata['session_logged_in'] )
{
	$header_location = ( @preg_match('/Microsoft|WebSTAR|Xitami/', getenv('SERVER_SOFTWARE')) ) ? 'Refresh: 0; URL=' : 'Location: ';
	header($header_location . append_sid("login.$phpEx?redirect=db_update.$phpEx", true));
	exit;
}

if( $userdata['user_level'] != ADMIN )
{
	message_die(GENERAL_MESSAGE, 'You are not authorised to view this page');
}


$page_title = 'Updating the database for the WPM mod v 1.0.10';
include($phpbb_root_path . 'includes/page_header.'.$phpEx);

echo '<table width="100%" cellspacing="1" cellpadding="2" border="0" class="forumline">';
echo '<tr><th>Updating the database for the WPM mod</th></tr><tr><td><span class="genmed"><ul type="circle">';


$sql = array();
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'active_wpm')";
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'wpm_username')";
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'wpm_userid')";
	$sql[] = "DROP TABLE " . WPM_INST. "";
	$sql[] = "CREATE TABLE " . WPM_INST . " (name varchar(255) NOT NULL default '', value text NOT NULL) TYPE=MyISAM";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_version', '1.0.10')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('active_wpm', '1')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_username', 'Anonymous')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_userid', '-1')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_subject', 'Welcome to [sitename]!')";
	INSERT INTO phpbb_wpm VALUES ('wpm_message', 'Hi, there [username]!');

for( $i = 0; $i < count($sql); $i++ )
{
	if( !$result = $db->sql_query ($sql[$i]) )
	{
		$error = $db->sql_error();

Roger_Ramjet

Learn to use the php tags if you want people to help you then you had better lmake it easy for them.

<?php
/***************************************************************************
 *                               wpm_db_update.php
 *                            ----------------------
 *
 * 				copyright	: ©2003, 2005 Duvelske  (duvelske@planet.nl)
 *
 ***************************************************************************/

/***************************************************************************
 *
 *   This program is free software; you can redistribute it and/or modify
 *   it under the terms of the GNU General Public License as published by
 *   the Free Software Foundation; either version 2 of the License, or
 *   (at your option) any later version.
 *
 ***************************************************************************/

define('IN_PHPBB', true);
$phpbb_root_path = './';
include($phpbb_root_path . 'extension.inc');
include($phpbb_root_path . 'common.'.$phpEx);
define('WPM_INST', $table_prefix.'wpm');

//
// Start session management
//
$userdata = session_pagestart($user_ip, PAGE_INDEX);
init_userprefs($userdata);
//
// End session management
//


if( !$userdata['session_logged_in'] )
{
	$header_location = ( @preg_match('/Microsoft|WebSTAR|Xitami/', getenv('SERVER_SOFTWARE')) ) ? 'Refresh: 0; URL=' : 'Location: ';
	header($header_location . append_sid("login.$phpEx?redirect=db_update.$phpEx", true));
	exit;
}

if( $userdata['user_level'] != ADMIN )
{
	message_die(GENERAL_MESSAGE, 'You are not authorised to view this page');
}


$page_title = 'Updating the database for the WPM mod v 1.0.10';
include($phpbb_root_path . 'includes/page_header.'.$phpEx);

echo '<table width="100%" cellspacing="1" cellpadding="2" border="0" class="forumline">';
echo '<tr><th>Updating the database for the WPM mod</th></tr><tr><td><span class="genmed"><ul type="circle">';


$sql = array();
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'active_wpm')";
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'wpm_username')";
	$sql[] = "DELETE FROM " . CONFIG_TABLE . " WHERE ('config_name' = 'wpm_userid')";
	$sql[] = "DROP TABLE " . WPM_INST. "";
	$sql[] = "CREATE TABLE " . WPM_INST . " (name varchar(255) NOT NULL default '', value text NOT NULL) TYPE=MyISAM";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_version', '1.0.10')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('active_wpm', '1')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_username', 'Anonymous')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_userid', '-1')";
	$sql[] = "INSERT INTO " . WPM_INST . " VALUES ('wpm_subject', 'Welcome to [sitename]!')";
	INSERT INTO phpbb_wpm VALUES ('wpm_message', 'Hi, there [username]!');

for( $i = 0; $i < count($sql); $i++ )
{
	if( !$result = $db->sql_query ($sql[$i]) )
	{
		$error = $db->sql_error();

Like I said, which is line 66? Don't expect us to count them for you MARK IT WITH A COMMENT. IE // <<<< This is line 66

Roger_Ramjet

Now I can see wht is wrong with this: it is obvious. It would be obvious to you if you had marked line 66. So try doing that, and then try thinking about what is wrong with it.