[RESOLVED] Log-In Script

[mediamonkey2006]

Hello...

I have introduced a log-in script (slightly more complex than that shown in the example):

Click to view Example

However I am having a small problem:

When the login is processed; it has:

session_register("username");
header("location:main.php");

Then in the header of main.php (and all pages on the website thereafter) - to ensure only logged-in users can view the pages is:

<? 
session_start();
if(!session_is_registered(username)){
header("location:index.php");
}
?>

And this is working - however; even when a user is logged in... it sometimes still goes back to index.php.

All of the pages are in the "/" directory... Apart from the forum pages... Which are in the "/forum" directory... It is those pages that tend to send the user back to index.php.

I've also noticed: Even though it is linked to: http://www.website.com/forum... The link actually changes to: http://website.com/forum... Perhaps this is another possible cause?

Do you have any ideas how I can resolve this?

Thanks for your help!

MM2006 :rolleyes:

[bbreslauer]

Try changing the second one to

if(!session_is_registered("username")){

[mediamonkey2006]

Hiya...

I just gave that a go - it still gives the same problem though...

Thanks,

MM2006 🙂

[mediamonkey2006]

Anybody got any more suggestions?

Thanks,

MM2006

[bubblenut]

Replace the head('location:index.php');
with
print_r($SESSION);
print_r($SERVER);
die();
re-create the error and paste the result back here.

[mediamonkey2006]

Hi Bubblenut...

Thanks for helping me... The results are:

Array ( ) Array ( [DOCUMENT_ROOT] => /home/nameoc/public_html [HTTP_ACCEPT] => image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, application/x-shockwave-flash, / [HTTP_ACCEPT_ENCODING] => gzip, deflate [HTTP_ACCEPT_LANGUAGE] => en-gb [HTTP_CACHE_CONTROL] => max-stale=0 [HTTP_CONNECTION] => Keep-Alive [HTTP_COOKIE] => phpbb2mysql_data=a%3A2%3A%7Bs%3A11%3A%22autologinid%22%3Bs%3A0%3A%22%22%3Bs%3A6%3A%22userid%22%3Bi%3A-1%3B%7D [HTTP_HOST] => website.com [HTTP_REFERER] => http://www.website.com/main.php [HTTP_USER_AGENT] => Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1) [HTTP_X_BLUECOAT_VIA] => B5D8B1055C914D51 [PATH] => /sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/X11R6/bin:/root/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin:/home/vdeck/apps/perlmodules/vDeck/Sudo:/var/qmail/bin [QMAILUSER] => nameoc [REDIRECT_QMAILUSER] => nameoc [REDIRECT_STATUS] => 200 [REDIRECT_URL] => /forum/ [REMOTE_ADDR] => 82.148.96.67 [REMOTE_PORT] => 44988 [SCRIPT_FILENAME] => /home/nameoc/public_html/forum/index.php [SERVER_ADDR] => 72.22.71.34 [SERVER_ADMIN] => [e-mail] [SERVER_NAME] => website.com [SERVER_PORT] => 80 [SERVER_SIGNATURE] =>
Apache/1.3.33 Server at website.com Port 80
[SERVER_SOFTWARE] => Apache/1.3.33 (Unix) mod_log_bytes/0.3 FrontPage/5.0.2.2635 mod_ssl/2.8.22 OpenSSL/0.9.7g [GATEWAY_INTERFACE] => CGI/1.1 [SERVER_PROTOCOL] => HTTP/1.1 [REQUEST_METHOD] => GET [QUERY_STRING] => [REQUEST_URI] => /forum/ [SCRIPT_NAME] => /forum/index.php [PATH_TRANSLATED] => /home/nameoc/public_html/forum/index.php [PHP_SELF] => /forum/index.php [argv] => Array ( ) [argc] => 0 )

I removed the actual website name and replaced it with 'website.com' - so's not to advertise.. Hope that's alright.

Thanks for your help.

MM2006 🙂

[mediamonkey2006]

Hiya,

Any ideas on what is causing the error?

Thanks,

MM2006

[bbreslauer]

Where the login is processed, try putting session_start() on the first line (before ANY other code).

[mediamonkey2006]

Hi!

Thanks for your suggestion - unfortunately it is still returning to the login page... I think I need to paste the entire process_login.php script which handles the login; so you can see what is going on:

<?php
$dbhost = 'localhost';
$dbusername = 'usernamehere';
$dbpasswd = 'passwordhere';
$database_name = 'dbnamehere';
$tbl_name="users";

$password = md5($password);

// Connect to server and select databse.
mysql_connect("$dbhost", "$dbusername", "$dbpasswd")or die("cannot connect"); 
mysql_select_db("$database_name")or die("cannot select DB");

$sql="SELECT * FROM $tbl_name WHERE username='$username' and password='$password' and activated='1'";
$result=mysql_query($sql);

// Mysql_num_row is counting table row
$count=mysql_num_rows($result);

// If result matched $username and $password, table row must be 1 row
if($count==1){

// Register username and redirect to file "main.php"
session_start();
session_register("username");
header("location:main.php");
}
else {
		$error_output = 'Incorrect username and/or password. Try again?';
		include 'index.php';
}
?>

Then on the first line of every page:

<? 
session_start();
if(!session_is_registered(username)){
header("location:index.php");
}
?>

The wierd thing is... From my own computer with my own login details - it works.

From my friends computer, with their login details - it doesn't work (sends back to the login page).

Any ideas would be greatly appreciated.

Thanks,

MM2006

[bbreslauer]

What I meant in the first script is that you should have the following:

<?php
session_start()

on the first two lines. I'm not sure this will change anything, but try it.

[Pinkmischief]

is main.php within a folder?

[mediamonkey2006]

Hiya,

I tried putting the:

session_start();

On the first line of Process_Login.php... However it still provided the same problem (with the forum).

main.php is in the "/" directory... It's not in any sub-folders... However /forum is a sub-folder.

Have you any further ideas?

Many Thanks,

MM2006 🙂

[mediamonkey2006]

Hi...

It just dawned on me that perhaps the reason it wasn't working - was due to the fact I was linking to:

/forum

So I changed the link to:

/forum/index.php

And it works! However; it is outputting some "WARNING" errors:

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/viewforum.php:7) in /home/public_html/forum/includes/sessions.php on line 258

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/viewforum.php:7) in /home/public_html/forum/includes/sessions.php on line 259

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/viewforum.php:7) in /home/public_html/forum/includes/page_header.php on line 483

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/viewforum.php:7) in /home/public_html/forum/includes/page_header.php on line 485

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/viewforum.php:7) in /home/public_html/forum/includes/page_header.php on line 486

In the top the following 'forum' pages, I have:

<? 
session_start(); 
if(!session_is_registered(username)){ 
header("location:index.php"); 
} 
?> 

index.php
viewforum.php
viewonline.php
viewtopic.php

The forum i'm using is PHPBB.

Do you have any suggestions how to alleviate this error?

Thanks,

MM2006 🙂

[mediamonkey2006]

Hiya.

I have just decided to include the code in the "Page_Header.PHP" of the forum... As opposed to the individual pages (makes more sense, I think?)

Anyway... There are now only three errors. At the top of the script, I have:

<? 
session_start(); 
if(!session_is_registered(username)){ 
header("location:index.php"); 
} 
?> 

The errors are:

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/includes/page_header.php:7) in /home/public_html/forum/includes/page_header.php on line 489

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/includes/page_header.php:7) in /home/public_html/forum/includes/page_header.php on line 491

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/forum/includes/page_header.php:7) in /home/public_html/forum/includes/page_header.php on line 492

Those lines are (the ones below maked 'header'):

if (!empty($HTTP_SERVER_VARS['SERVER_SOFTWARE']) && strstr($HTTP_SERVER_VARS['SERVER_SOFTWARE'], 'Apache/2'))
{
	header ('Cache-Control: no-cache, pre-check=0, post-check=0');
}
else
{
	header ('Cache-Control: private, pre-check=0, post-check=0, max-age=0');
}
header ('Expires: 0');
header ('Pragma: no-cache');

Therefore - my question is... Can I change the initial code:

<? 
session_start(); 
if(!session_is_registered(username)){ 
header("location:index.php"); 
} 
?> 

For something other than header? Like Include or something / somehow?

Thanks for your help with this.

MM2006 🙂

[Pinkmischief]

The header errors normally mean that something has been echoed to the browser before the headers are sent be sure to check that there is no output to the browser before the headers are sent even so much as a space will cause that error from my experience that normally means that.

Please bear in mind that i have only been doing PHP for 5 months and never done any programming language before that i am not 100% sure that the info i give is 100% correct.

But i still try to help as much as ican

reagrds Pinky.

[mediamonkey2006]

Pinky.. You are a STAR!

Thanks for your help! It turns out there were spaces after each line of my inserted code:

<?
session_start();
if(!session_is_registered(username)){
header("location:index.php");
}
?>

Which in turn caused it to have the error!!! I never knew a space could do that!

Thank you very much for your help - I really appreciate it! 🙂

Have a great day,

MM2006

[Pinkmischief]

Your very welcome glad i could help sry been away for abit been a bit busy lol