[RESOLVED] Function error

Oni

Hi--

I was going to use a repeat code 10 times. So, rather then taking up all of that space I thought I'd try to use a function. The first time I've tried to create my own function and I get an error:

Parse error: parse error, unexpected T_LIST, expecting T_STRING in /home/basichy/public_html/ict/secure/index.php on line 79

function list($bk) {  //Line 79
$result = mysql_query("SELECT id FROM books WHERE id = $bk") or die(mysql_error()); 
$row = mysql_fetch_array( $result );
if ($num % 2 == 0 )
{
//even
$eo = "even";
} 
else //odd
{
$eo = "odd";
}
$num++;
print "<tr class='$eo'>"; //Table Style

$id = .$row['id'];
$title = .$row['title'];
$author = .$row['author'];
$price = .$row['price'];
$genre = .$row['genre'];
$stock = .$row['stock'];


print "<td><font color=\"white\"><font color=\"white\">$id</td><td><A HREF=\"http://site.com/ict/secure/bookdetails.php?id=$id\" onClick=\"return popup(this, 'notes')\"><font color=\"white\">$title</A></td><td><font color=\"white\">$author</td><td><font color=\"white\">$price</td><td><font color=\"white\">$genre</td><td><font color=\"white\">$stock</td>";
print "</tr>";
}

I'm pretty sure that the code before and after is alright because I got that error after I had added in the function...

Any ideas?
Thanks!!

bpat1434

list is an actual PHP function.. you need to reword your function name. Sometimes it can be as easy as prepending an underscore: _list($bk).

You can't use names of php functions as your own name, otherwise you get this error.

Now, if you'll allow me to speak about your function....

-- You don't define $num, so you'll get an error when you try to reference it...

$id = .$row['id'];
$title = .$row['title'];
$author = .$row['author'];
$price = .$row['price'];
$genre = .$row['genre'];
$stock = .$row['stock'];

I think you're trying to add the string to the current variable. If that's true, the proper syntax is:

$var .= 'some string'

What you have will be an error....

Oni

Thanks for the help!

I got the code working perfectly, except, the values for the variables don't seem to work...

I tried what you suggested and changed the original to:

$id .= $row['id'];

That didn't work so I tried:

$id .= '$row['id']';

Any suggestions?

And, What I'm trying to do for that variable is that-- I ran the mysql query and I'm trying to get the data that was in the cell...

bpat1434

1.) You need to declare a variable first. So:
$id .= $row['id']
when $id hasn't previously been declared, won't write anything. You'd need to "default" all your variables. You could do this on one line:
$id = $var2 = $var3 = $var4 = $var5 = '';
That would set all the vars to an empty string.

2.) If you just want to "replace" what that variable holds (the value), then remove the "." from in front of the equal sign.

Oni

The variable is newly created here, I haven't mentioned it earlier. So I have:

$id = $row['id'];
$title = $row['title'];
$author = $row['author'];
$price = $row['price'];
$genre = $row['genre'];
$stock = $row['stock'];

However, when I create the table, all of the entries are blank... Except the id one.

Maybe it has something to do with my mysql query. But I think everything looks fine??

bpat1434

Yup, your SQL query is wrong... it should be:
SELECT * FROM .... instead of
SELECT id FROM ....

Oni

Ya, that's it.

Thanks for the help 😉