imagecopyresampled - problem

[mashnote]

so i think i've read every thread which came up in my searches on this board for the subject, but i still have a problem

i cut down the script to the basics to get other possible errors out of the way, and it still doesn't work.

i can upload the image, get the image size, etc...

but the resizing just fails time after time, and i especially get this output

Resource id #3

i'm not sure what to do with this. i've searched for this error (?), without results.

here's my full code.

if($action == "new") {

$uploaddir = './images/upload/';
$imagename = $_FILES['cover']['name'];
$temp_picture = $_FILES['cover']['tmp_name'];
$uploaded_picture = $uploaddir . $imagename ; //full path
$imagesize = getimagesize($uploaded_picture);
$width = $imagesize[0]; //oude breedte -- height is de eerste waarde van de array die getimagesize als uitkomst geeft
$height = $imagesize[1]; //oude hoogte
$maxwidth = 100; //nieuwe breedte
$maxheight = 100; //nieuwe hoogte

$cover = imagecreatetruecolor($maxwidth, $maxheight);
$oldcover = imagecreatefromjpeg($uploaded_picture); 
imagecopyresampled ($cover, $oldcover, 0,0,0,0, $maxwidth, $maxheight,        
    $width, $height);
imagejpeg($cover, $temp_picture); 

    //if (move_uploaded_file($temp_picture, $uploaded_picture)) {
    $insertQuery = "INSERT INTO mash_cms (id,input_date, band, title, format, label, url, review, reviewer, cover, online) VALUES ('$id','$input_date','$band','$title','$format','$label','$url','$review','$reviewer','$cover','  
		 $online')";

  //}

  // de gegevens in de database steken
    $results = mysql_query( $insertQuery );

          // als de gegevens in de database zijn gestoken
         if($results){
         echo( "your review was succesfully uploaded." );
		 echo ("<br><br>");
		 echo "band:.".$band."<br>title:".$title."<br><img             
                     src='".$cover."'><br>";
		 echo ("<a href='cms_index.php?p=1&action=new' target='_self'>want to upload another review ?</a>");



         }
         else{
         die( "Trouble Saved: " . mysql_error() );
         }

    }

thanx in advance!

[Weedpacket]

That's because you're outputting the image resource itself ($cover), instead of the filename you saved it under ($temp_picture). And while I'm thinking about it, you might want to actually save it somewhere, instead of back into its temporary location, from where it would get deleted when the script is finished.

[mashnote]

Weedpacket wrote:

That's because you're outputting the image resource itself ($cover), instead of the filename you saved it under ($temp_picture). And while I'm thinking about it, you might want to actually save it somewhere, instead of back into its temporary location, from where it would get deleted when the script is finished.

so i should change this part into....?
(i tried lots of things before, changing the variables in this...maybe in the wrong way though):

 imagejpeg($cover, $temp_picture);

and use this again ?
(when i upload the file without resizing, i did use this part and there were physical pics in my upload folder):

 //if (move_uploaded_file($temp_picture, $uploaded_picture)) { 

[mashnote]

so i read the php manual again, and just went through my code step by step.

i got it working now, but i'm not 100% it's exactly right and if it's coded in a kosjer way.

  if($action == "new") {

$uploaddir = './images/upload/';
$imagename = $_FILES['cover']['name'];
$temp_picture = $_FILES['cover']['tmp_name'];
$uploaded_picture = $uploaddir . $imagename ; //full path
$imagesize = getimagesize($temp_picture);
$width = $imagesize[0]; //oude breedte -- height is de eerste waarde van de array die getimagesize als uitkomst geeft
$height = $imagesize[1]; //oude hoogte
$maxwidth = 100; //nieuwe breedte
$maxheight = 100; //nieuwe hoogte

$newcover = imagecreatetruecolor($maxwidth, $maxheight);//een zwarte afbeelding creëren met die nieuwe afmetingen
$oldcover = imagecreatefromjpeg($temp_picture);//van de upgeloade temp. cover een jpg maken.
imagecopyresampled ($newcover, $oldcover, 0,0,0,0, $maxwidth, $maxheight, $width, $height);//resizen van oude cover naar nieuwe met de        
//ingestelde parameters
imagejpeg($newcover, $temp_picture); //die geresizede afbeelding bruikbaar maken

    if (move_uploaded_file($temp_picture, $uploaded_picture)) {
    $cover = $uploaded_picture;
    $insertQuery = "INSERT INTO mash_cms (id,input_date, band, title, format, label, url, review, reviewer, cover, online) VALUES ('$id','$input_date','$band','$title','$format','$label','$url','$review','$reviewer','$cover','  
         $online')";

  }

  // de gegevens in de database steken
    $results = mysql_query( $insertQuery );

          // als de gegevens in de database zijn gestoken
         if($results){
         echo( "your review was succesfully uploaded." );
         echo ("<br><br>");
         echo "band:.".$band."<br>title:".$title."<br><img             
                     src='".$cover."'><br>";
         echo ("<a href='cms_index.php?p=1&action=new' target='_self'>want to upload another review ?</a>");



         }
         else{
         die( "Trouble Saved: " . mysql_error() );
         }

    }