Whats the deal with str_replace??

[chinrub]

ive used this function "str_replace" to replace a comment in a template,
i was wondering what i'd have to do to use it more than once
e.g.

$msg[$i] = str_replace("<!--EMAIL-->", $row['email'], $message);
$msg[$i] = str_replace("<!--NAME-->", $row['name'], $message);

is that acceptable?

or do i need something like a seperate array set up for each variable to be replaced?

[obsidian]

what you have is perfectly acceptable, but it's going to add all sorts of overhead if you have to call it a dozen times or so for a larger template. if you create an array of your targets and values, you can get by with calling it once:

$targets = array("<!--EMAIL-->", "<!--NAME-->");
$replace = array($row['email'], $row['name']);
$msg[$i] = str_replace($targets, $replace, $message);

hope this helps

[Weedpacket]

obsidian wrote:

what you have is perfectly acceptable,

Well, not quite; the second ocurrence of $message ought to be $msg[$i] if you don't want the work of the previous line to be wasted.

I'd use the array as well. I'd even go further, if I'm right and there's never any <!--slots--> in the replacement text that get replaced further on, and suggest using [man]strtr[/man]; once that function replaces a section of text it doesn't bother looking at that section again (str_replace lookst at the entire string for every replacement).

[chinrub]

thanks alot for the replies im gonna give them a try now and hope it works 😃

edit - Worked a treat 😃 thank you very much! 😃