weird

[lancey10]

whev ever i navigated to the page i just coded, it shows nothing, no eriirs, nothing except the page #'s on the bottom! why is that? the mysql info is all correct but i dont know whats going wrong, here is the code:

<?

function per_page($link, $offset) {
  global $numofpages, $page;
  $numofpages = round($numofpages);

  $pagesstart = round($page-$offset);
  $pagesend = round($page+$offset);

  if ($page != "1" && round($numofpages) != "0") {
    echo str_replace("%page", round($page-1), '<a href="'.$link.'"><font face="Trebuchet MS">&laquo;</font></a>&nbsp; ');
  }

  for($i = 1; $i <= $numofpages; $i++) { 
    if ($pagesstart <= $i && $pagesend >= $i) {
      if ($i == $page) {
        echo "<b>[$i]</b>&nbsp;";
      }
      else {
        echo str_replace("%page", "$i", '<a href="'.$link.'">'.$i.'</a>&nbsp; ');
      }
    }
  }
  if (round($numofpages) == "0") {
    echo "[$i]";
  }

  if ($page != round($numofpages) && round($numofpages) != "0") {
    echo str_replace("%page", round($page+1), '<a href="'.$link.'"><font face="Trebuchet MS">&raquo;</font></a>');
  }
}


/* Connect to mysql */
$db=mysql_connect ("BLOACKED", "BLOCKED", "BLOACKED") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("db154983921"); 



/* Set How many results to display per page */
$pp = "40";

/* Select the table that you want to view, you can add things like WHERE something='something' */
$table = "namemap";

$total = mysql_result(mysql_query("SELECT COUNT(id) FROM $table"),0); 
$numofpages = $total / $pp;   

if (!isset($_GET['page'])) { 
  $page = 1; 
} 
else { 
  $page = $_GET['page']; 
} 
$limitvalue = $page * $pp - ($pp); 

/* Display the rows */
$query = "SELECT * FROM $table ORDER by id DESC LIMIT $limitvalue, $pp " or die ('cant select namemap');
$result = mysql_query($query);
//$i=1;
//$color1 = '#717171';
//$color2 = '#464646';

while($r=mysql_fetch_array($result))
 //$color = ($i%2==0)?$color1:$color2;
{

            echo"<table width='100%'>";
		    echo" <td>";
                   echo"<a href='torrents.php?mode=details&amp;id='>";
                     echo"$r[filename]";
                   echo"</a>";
			   echo"</td>";
               echo"<td align = 'center'>$r[size]";
               echo"</td>";
               echo"<td>";
                echo"$r[seeds]</td>";
               echo"<td>";
                 echo"$r[leechers]</td>";
             echo"</tr>";
         echo"</table>";
   }
//$i++;
/* Display the pages down the bottom */
echo 'Pages: '.round($numofpages).'<br>';

per_page("?page=%page", "5");

?>

[bpat1434]

Here are a few things I see:

for($i = 1; $i <= $numofpages; $i++) {
    if ($pagesstart <= $i && $pagesend >= $i) {
      if ($i == $page) {
        echo "<b>[$i]</b>&nbsp;";
      }
      else {
        echo str_replace("%page", "$i", '<a href="'.$link.'">'.$i.'</a>&nbsp; ');
      }
    }
  } 

can be rewritten to be:

for($i = $pagesstart; $i <= $pagesend; $i++) {
      if ($i == $page) {
        echo "<b>[$i]</b>&nbsp;";
      }
      else {
        echo str_replace("%page", "$i", '<a href="'.$link.'">'.$i.'</a>&nbsp; ');
      }
  }

Remove teh spaces between function names and parethensis:

$db=mysql_connect ("BLOACKED", "BLOCKED", "BLOACKED") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("db154983921"); 

Should be a number, not a string:

$pp = "40"; 
// Should be:
$pp = 40;

This:

if (!isset($_GET['page'])) {
  $page = 1;
}
else {
  $page = $_GET['page'];
}

Can be rewritten as:

$page = (!isset($_GET['page']))?1:$_GET['page'];

Always use an or die() statement:

$result = mysql_query($query);

This type of line doesn't need to be in quotes:

echo"$r[filename]"; 

and should be rewritten as:

echo$r['filename']; 

Start with those, see what that gets you...

[lancey10]

there is a error in

$result = mysql_query($query)

what can be the problem?

[bpat1434]

your query....

$query = "SELECT * FROM $table ORDER by id DESC LIMIT $limitvalue, $pp " or die ('cant select namemap'); 

is not correct.... it should just be the string.... the or die() statement goes after mysql_query()...

[khendar]

I must disagree with bpat1434 on one point:

Always use an or die() statement:

I believe you are usually better off imbedding some error handling eg:

$result = mysql_query($query); 
if($msg = mysql_error())
echo __LINE__ . ' of ' . __FILE__ . '<pre>' . $query . '</pre><br /> (caused: '.$msg.')';

or something.

[bpat1434]

But for the purposes of getting things working, having an or die() statement will suffice. Get it working first, then tidy it up and secure the code. But I do agree, you should remove the die() statements eventually, but usually they're good to have while debugging.

Of course, even that can be done like:

if($debug===TRUE)
{
    die(mysql_error());
}
else
{
    $msg = mysql_error();
    echo __LINE__.' of '.__FILE__.'<pre>'.$query.'</pre><br /> (caused: '.$msg.')';
}

All wrapped in an if(!$result) test....