What is wrong with this

Pipips

I am trying to generate a form using PHP

I want to have user fields but also have the IP posted as a hidden field

I have got this code :

<html>
<head>
<title>Atheist Republic Chatroom</title>
</head>
<body>

<?php
$ip = $_SERVER['REMOTE_ADDR'];

echo "<input type=\"hidden\"name=\"ip\"value=\"";
echo $ip;
echo "\">;

echo "<input type=\"submit\"value=\"submit\">";

</body>
</html>

Why is this wrong?

Houdini

Well for one thing you had no form to work with, and a couple of other things, not sure what you are trying to do but this will at least show the submit button and place the ip into the hidden field. so try this. Like I said not sure just what it is you are trying to do but this works, maybe not the way you want but it works.

<html>
<head>
<title>Atheist Republic Chatroom</title>
</head>
<body>
<form method="post" action= "somefile.php">
<?php
$ip = $_SERVER['REMOTE_ADDR'];
echo "<input type=\"hidden\"name=\"ip\"value=\"$ip\">";
?>
<input type="submit"value="submit">
</form>
</body>
</html>

TF_TheMoon

Why do you want to display the IP in a hidden field anyway? If you've then going to validate based on that you've leaving your script open to manipulation from basic javascript. Keep your IP based checking server-side