Passing value from checkbox

audiomove

I'm trying to pass a value in checkbox which is a variable assigned a value from a tabe within my database inside a while loop.

while($row = mysql_fetch_row($results)) {
	list($id, $bannerName, $clientName, $Url) = $row;
	echo '<tr>
			<td width="10"><input type="checkbox" name="ckname[]" value="$id"></td>
			<td width="25">';
	print $id;
.
.
.
.
.

the (...) just signify theirs more code.

With the variable $id, which is used to pass the value. With the following print statement it does print the value of $id so it is been passed the values from the table. But when i pass the the variable $id, its passed as $id and not the value of that variable. Ive tryed taking away the double quotes, using single quotes etc so it doesnt seem to be that, as it has been with other issues i often have.

the following code is where it is been passed. And when i passed a value like "1" instead of the variable the code works fine.


case 'Delete':

if (isset($_GET['ckname'])) {
	foreach ($_GET['ckname'] as $id)
	mysql_query("DELETE FROM Banner WHERE id = '" . $id . "'");
	print $id;
} else {
	echo "No items selected";
}
break;

Any suggestions you may have that might help would be very much welcomed.

Regards,
Cathal

Installer

The id is passed as a string "$id" because of the way you're using your quotation marks. Try

    echo '<tr> 
      <td width="10"><input type="checkbox" name="ckname[]" 
      value="' . $id . '"></td> 
      <td width="25">';

And it looks to me like when you do get it working, someone is going to come along and delete every row in your table just for the fun of it.

audiomove

Thanks installer that worked.

audiomove

Since this originated here, i taught id save space and reserect this thread.

I have a piece of code

echo '<tr>
<td width="10"><input type="checkbox" name="ckname[]" value="' . $id . '"></td>
<td width="25">$id</td>
<td width="100"> <a href=\'downloadlistedit.php?id=$id\'> $name</a></td>
<td width="50">$section</td>
<td width="50">$category</td>
<td width="50">$version</td>
<td width="50">$hits</td>
</tr>';

instead of printing out the values of the variables its print the actual variable $id for example. It's probably just a syntax thing but could save me alot of time if someone could just tell me what im doing wrong.

Thanks,
Cathal

brandtj

Because you are using single quotes, any variable you name is assumed as is.

Example:

$hi = 'hey';

echo $hi;            // returns: hey
echo "$hi";          // returns: hey
echo '$hi';          // returns: $hi

So if you want to use single quotes, you have to end them before you can name a variable.

Example:

$hi = 'hey';

echo 'Here it is: ' . $hi . ' -- there it is';
// returns: Here it is: hey -- there is is

My apologies for the bad example, but I hope it helps nonetheless! 😃

audiomove

hey brandtj nice reply, that does clear it up a bit. I've got some problems again unfortunately, tryed to play around with it but need to ask for your davice again.

With the following code

echo '<tr>
		<td width="10"> <input type="checkbox" name="ckname[]" value="' . $id . '" /></td> 
		<td width="25">'. $id .'</td>
		<td width="100"><a href="downloadlistedit.php?id="'. $id .'>'. $name .'</a></td>
		<td width="50">'. $section .'</td>
		<td width="50">'. $category .'</td>
		<td width="50">'. $version .'</td>
		<td width="50">'. $hits .'</td>
	</tr>';[/QUOTE] 
It display downloadlistedit.php?id= and blank after it, again it's probably the syntax trying to understand but maybe you could show me in the right direction.

Also when i click delete im back to the original problem I had in this thread awhile ago. It doesnt delete the item from the database, you can see my delete statment code in the earlier posts at the top.

If you could spare the time to expand on your help earlier it would be greatly appreciated.

Thanks,
Cathal

brandtj

Hmm... one thing I can see is

<td width="100"><a href="downloadlistedit.php?id="'. $id .'>'. $name .'</a></td>

needs to be

<td width="100"><a href="downloadlistedit.php?id="'. $id .'">'. $name .'</a></td>

There was a missing quotation mark there at the end of the tag... Does that work?

audiomove

thanks for drawing my attention to there, i took out the "" quotes altogether which solved it nicely and my other problem was a miss spelling on my behalf. Thanks again for your time.

brandtj

Anytime! 😃