[RESOLVED] Php Images

[SilverWolfe]

Hi again, i am using this code

<?
$height = 200;
$width = 200;

$im = ImageCreate($width, $height);
$white = ImageColorAllocate($im, 225,225,225);
$black = ImageColorAllocate($im, 0,0,0);

ImageFill($im,0,0,$black);
ImageLine($im,0,0,$width,$height,$white);
ImageString($im,4,50,150, 'Sale', $white);

Header('Content-type: image/jpeg')

ImageJpeg($im); 

ImageDestroy($im);

?>

and i get :

Parse error: parse error in C:\Program Files\Apache Group\Apache2\htdocs\imagetest.php on line 15

which is 'ImageJpeg($im);'

i take that out and it does the same with 'ImageDestroy($im);'

Any help?

[bpat1434]

Missing last ";" on Header('Content-type: image/jpeg') line...

Note: Line number errors usually point to where PHP runs into a problem, not where the problem is. Look a few lines above from the given line number to see if you see anything obvious (like this error)

[SilverWolfe]

...

oh my, thanks.. i feel like a total newbie, now. thanks much

now while on the subject, the image now works, using that image created by php, is there a way to keep that image but replace the text inside it, without editing the code.. like a smaller buttons... using a function, like button('Sale'); or button('Sale last week');

What i am trying to do, is make buttons for a website, i'm working on, and instead of putting more space on the server i want php to make the buttons for me on the site

button('Home','index.php');
button('News','news.php');
ect

but still using the same button (button.php thats is blank adding the text to it with a fuction in the main index.php..

button.php:

<?



$im = imagecreatefrompng('Button.png');
$blue = ImageColorAllocate($im, 14,1,175);
$color=$blue;

$width=ImageSX($im);
$height=ImageSY($im);


$font_size=15;

putenv('GDFONTPATH=C:\Windows\Fonts');
$fontname='arial';
if(isset($text)){
ImageTTFText ($im,$font_size,0,50,22,$blue,$fontname,$text);
}

Header('Content-type: image/png');

ImagePng($im);
ImageDestroy($im);

?>  

Index.php:

<?

function button($string)
{
$text=$string;

echo "<img src=button.php><br>";
}

button('Home');
button('News');
?>

not linking anything yet just testing it as you can tell.. and the image/button comes up blank...
hope i made that next problem as clear as possible

[bpat1434]

Perhaps you should take a separate approach and instead use $_GET values to generate the buttons, and then just call the php script from within your image tag:
button.php

<?php

$text = (isset($_GET['s']) && !empty($_GET['s']))?$_GET['s']:'Home';

$im = imagecreatefrompng('Button.png');
$blue = ImageColorAllocate($im, 14,1,175);
$color=$blue;

$width=ImageSX($im);
$height=ImageSY($im);


$font_size=15;

putenv('GDFONTPATH=C:\Windows\Fonts');
$fontname='arial';
if(isset($text)){
ImageTTFText ($im,$font_size,0,50,22,$blue,$fontname,$text);
}

Header('Content-type: image/png');

ImagePng($im);
ImageDestroy($im);

?> 

Index.php

<img src="button.php?s=Home" /> 
<img src="button.php?s=News" />

[SilverWolfe]

Thanks much, that worked great! never thought about $_GET values!

[Weedpacket]

You've done nothing to get $text into the button; index.php and button.php are two separate pages, and the browser sees them as two separate resources, and makes two separate requests (one for the page itself, one for the image in the src attribute).

The easiest way to send something to button.php here would be to put it in the URL:

echo "<img src=\"button.php?label=".$text."\"><br>"; 

And in button.php get the value passed from $_GET['label'].

Be aware that whatever you might put in there fore the label, someone else looking at your page could put anything in the same place. Offhand I don't see any vulnerabilities that result, but I'm not 100% confident that GD Lib's text-handling is safe in all circumstances (I have found one or two bugs in its code in the past). I'd suggest at least

1. using substr() to limit the maximum possible length of the string (you know how long a label is going to be - short enough to fit in the button - so don't allow anything much longer than that), and

2. allow only the sorts of characters that you will be allowing in labels (upper/lower case letters, spaces, maybe a bit of punctuation, perhaps digits). [man]preg_match[/man] would be good for this:

   if(preg_match("#[^a-zA-Z0-9 /.'-]#", $text){$text=""; // a blank label instead of one with weird characters in it

   won't allow anything that contains something other than a letter, digit, space, slash, point, apostrophe, or hyphen.

[bpat1434]

Weedpacket, don't forget to escape the single quote...

if(preg_match('#[^a-zA-Z0-9 /.\'-]#', $text){$text=""; }// a blank label instead of one with weird characters in it 

And yes, implement the rescrictions about text that Weedpacket suggests.

[Weedpacket]

Heh, went back and used double quotes. Thought of adding the apostrophe at the last second.