database wont update

tbobker

Hi i have been building a simple cms and it is all working ok apart from the fact that i cannot update the database from the admin side.

Here is the update script that i have written:

<?php

include("dbconnect.inc");
$text = $_POST['text'];

if ($_POST[submit])

{

$sql = "UPDATE pages SET content = $text WHERE title = $update;";

$result = mysql_query($sql,$conn);

}

echo "<center><a href='index.php'>Update another page</a></center>";
echo $text."<br>";       //checking to see the variable exists (this is from the text form
echo $update;             //check to see the variable exists, passing it in the url





?>

please help this is really annoying me!!!

TF_TheMoon

A few things.

Does your dbconnect include file make the connect to the database, because there is nothing ni that code which will
If the content field is a string field (varchar, char, text etc) you're missing the ' ' that you'll need unless your HTML input field has them, which would be nasty.
Is title a string, if so update will also need to be encapsulated within '' or "".
Can $update be false, as if it is you'll be getting a SQL Syntax error.
Have you done a print_r( $conn ) to see if there are any errors there?

On a side note, perhaps should consider using PEAR:😃B (http://pear.php.net) for your database needs

tbobker

thanks for the help, unfortunately i have checked everything and it still doesnt work.

what is print_r($conn) tried it and got - Resource id #4

when you say update has to be encapsulated in " " what do you mean, like this;

$sql = "UPDATE pages SET content = '$text' WHERE title = '$update';"; this is what i have now, content was a blob field but have changed it to text to see if it made a difference but it hasn't.

Any ideas?

SeenGee

maybe this :

change -

if ($_POST[submit])

if ($_POST['submit'])

BTW:

for security you should change your include file to either dbconnect.inc.php or just dbconnect.php, this way the code it contains can never be displayed to a malicious user.

tbobker

Thanks for all your ideas and help. I have figured it all out, the name of the submit button on the post form had a capital S so i changing it to s and it now works.

Thanks again, great site!