[RESOLVED] Brand new newbie

[cspgsl]

I can tell PHP is going to be lots of fun however, there are the pains of beginning something from scratch. I have made several errors up to now but just cannot see what the problem is here.

You can see the form at http://php.cedarsprings.cc/orderform.html

I want to apply a discount to the pro price at two levels. I think I have written the php code correctly but the discount isn't applied.

Thanks for any help...

<?php
// create short variable names
$pro = $POST['pro'];
$comp = $POST['comp'];
$personal = $POST['personal'];
$diy = $POST['diy'];
$host = $POST['host'];
$qna = $POST['qna'];
$facts = $POST['facts'];
$calc = $POST['calc'];
$news = $POST['news'];
$setupcomp = $POST['setupcomp'];
$setuppersonal = $POST['setuppersonal'];
$setuphost = $POST['setuphost'];

echo '<p>Your order is as follows: </p>';
$totalqty = 0;
$totalqty = $pro + $comp + $personal + $diy + $host + $qna + $facts + $calc + $news;
echo 'Items Ordered: '.$totalqty.'<br />';

$totalamount = 0.00;

define('PROPRICE', 300.00);
define('COMPPRICE', 200.00);
define('PERSONALPRICE', 100.00);
define('DIYPRICE', 1000.00);
define('HOSTPRICE', 400.00);
define('QNAPRICE', 100.00);
define('FACTSPRICE', 100.00);
define('CALCPRICE', 100.00);
define('NEWSPRICE', 100.00);
define('SETUPCOMPPRICE', 50.00);
define('SETUPPERSONALPRICE', 100.00);
define('SETUPHOSTPRICE', 200.00);

$totalamount = $pro PROPRICE
+ $comp COMPPRICE
+ $personal PERSONALPRICE
+ $diy DIYPRICE
+ $host HOSTPRICE
+ $qna QNAPRICE
+ $facts FACTSPRICE
+ $calc CALCPRICE
+ $news NEWSPRICE;
+ $setupcomp SETUPCOMPPRICE;
+ $setuppersonal SETUPPERSONALPRICE;
+ $setuphost SETUPHOSTPRICE;

echo 'Subtotal: $'.number_format($totalamount,2).'<br />';

if( $pro < 2 )
$discount = 0;
elseif( $pro >= 2 && $pro <= 5 )
$discount = 10;
elseif( $pro >= 5 && $pro <= 9 )
$discount = 20;

$taxrate = 0.15; // local salestax is 15%

$totalamount = $totalamount * (1 + $taxrate);
echo 'Total including tax: $'.number_format ($totalamount,2).'<br />';

if( $totalqty == 0 )
{
echo '<font color=red>';
echo 'You did not order anything! <br />';
echo '</font>';
}

else
{
if ($pro> 0 )
echo $pro.' Professional Plan<br />';
if ($comp> 0 )
echo $comp.' Comprehensive Plan<br />';
if ($personal> 0 )
echo $personal.' Personal Plan<br />';
if ($diy> 0 )
echo $diy.' DIY Plan<br />';
if ($host> 0 )
echo $host.' Hosting Only Plan<br />';
if ($qna> 0 )
echo $qna.' Quick Q &amp; A ToolKit<br />';
if ($facts> 0 )
echo $facts.' Qucik Facts ToolKit<br />';
if ($calc> 0 )
echo $calc.' Calculators ToolKit<br />';
if ($news> 0 )
echo $news.' Quarterly Newsletters ToolKit<br />';
}

echo '<p>Order processed at ';
echo date('H:i, jS F');
echo '</p>';

?>

[khendar]

You've set your $discount amount but you haven't added (multiplied) it to your $totalamount.

[cspgsl]

Thanks for the reply. I now see that it needs to be included in defining $totalamount so I tried a few scenarios

First I tried:

$totalamount = ($totalamount $discount) (1 + $taxrate);

But that didn't make sense as it woud appear that I am saying apply the discount to the total amount.

So then I tried: (thinking that if I multiply the PROPRICE by the $discount it would do so at the appropriate level... Nope

$totalamount = $pro PROPRICE $discount
+ $comp COMPPRICE
+ $personal PERSONALPRICE
+ $diy DIYPRICE
+ $host HOSTPRICE
+ $qna QNAPRICE
+ $facts FACTSPRICE
+ $calc CALCPRICE
+ $news NEWSPRICE;
+ $setupcomp SETUPCOMPPRICE;
+ $setuppersonal SETUPPERSONALPRICE;
+ $setuphost * SETUPHOSTPRICE; :bemused:

Then I tried: (thinking that $discount needed to be defines as a separate amount... Na

$totalamount = $pro PROPRICE
+ $discount PROPPRICE
+ $comp COMPPRICE
+ $personal PERSONALPRICE
+ $diy DIYPRICE
+ $host HOSTPRICE
+ $qna QNAPRICE
+ $facts FACTSPRICE
+ $calc CALCPRICE
+ $news NEWSPRICE;
+ $setupcomp SETUPCOMPPRICE;
+ $setuppersonal SETUPPERSONALPRICE;
+ $setuphost * SETUPHOSTPRICE; :bemused:

I don't know where wlse to place the expression.

Thanks

[TF_TheMoon]

Your discount is an postive integer so when you multiply it its going to increase the amount not decrease it

So I believe you are trying to achieve this:
total Amount = ( Total Amount - % Discount of ProPrice ) Then add Tax to that total

in which case you want

$totalamount = ($totalamount - (PROPRICE ($discount/100) ) ) (1 + $taxrate);

[Houdini]

Try putting your discount into $totalamount only when it qualifies like this

if($pro < 2)
$totalamount=$totalamount;
elseif( $pro >= 2 && $pro <= 5 )
$totalamount = $totalamount *.9;
elseif( $pro >= 5 && $pro <= 9 )
$totalamount = $totalamount *.8;

That will figure the discount before taxes.
Notice that I used the inverse of 10% which is .9 and the inverse of 20% which is .8
Now if someone meets the $pro>=2 && $pro<=5) they will Pay after taxes $103.50 on a hundred dollar purchase ((100.9)1.15)
See if that doesn't work for you

[cspgsl]

Thanks. I found that there had to be one minor alteration to your suggestion.

$totalamount = ($totalamount - (PROPRICE ($discount/100) ) ) (1 + $taxrate);

only discounted the pro price not the qty sold so the total amount only reflected a discount of 1 pro plan not the quantity that were sold. I added $pro to the expression and voila.

$totalamount = ($totalamount - ($pro PROPRICE ($discount/100) ) )* (1 + $taxrate);

[cspgsl]

Houdini wrote:

Try putting your discount into $totalamount only when it qualifies like this

if($pro < 2)
$totalamount=$totalamount;
elseif( $pro >= 2 && $pro <= 5 )
$totalamount = $totalamount *.9;
elseif( $pro >= 5 && $pro <= 9 )
$totalamount = $totalamount *.8;

That will figure the discount before taxes.
Notice that I used the inverse of 10% which is .9 and the inverse of 20% which is .8
Now if someone meets the $pro>=2 && $pro<=5) they will Pay after taxes $103.50 on a hundred dollar purchase ((100.9)1.15)
See if that doesn't work for you

That would seem to make sense as I could treat each product individually without having to mess with the final $totalamount calculation.

This could come in handy as I want to add in another feature (see order form www.php.cedarsprings.cc/orderform.html) which will add the appropriate setup charge to the oder if a person purchases a plan and one of the toolkit options.

I'm working on that one now so I might be back in a while...

Thanks,

[Houdini]

I never figured my computer accounting course would have been of much use, but using the inverse gives the real valuse without all the unnecessary math instead of 100*.1=10 and then subtracting that from the original number just multiply by the inverse or .9 and you effectively have the desired result in one simple operation. Same thing with your paycheck just take your gross and take the inverse .85 for most and you have your net pay without all the messy math.

I noticed that your tax rate was 15% which seems a little high, but oh well, instead of the 1+and all just multiply by1.15 which is the after tax price of any amount or 115%

[cspgsl]

15%... it's Atlantic Canada. It only hurts for a moment if you say it fast.

[Houdini]

In Tennessee we have one of the highest sales taxes in the United States and it is 8.25% which on purchases gets rounded up so an item for a dollar is 1.09, I have been tempted to take pliers and cut pennies into parts and say here is your 1/4 of a cent but then I would probably be arrested for defacing the money. This sales tax is for all items, food, medicine, everything.

[Blulagoon]

V.A.T in the UK is 17.5%, and is added to most everything except food and books.

Blu :mad:

[TF_TheMoon]

And not even mention the petrol (gas) prices over here in the UK lol

[cspgsl]

Petrol prices... nothing to laugh about anywhere!