Kb, Mb, Gb, Tb

lancey10

ok, does this work, i think u will know what im trying to do by loocking at code:

  if ($r[seeds] < 1000 * 1024)
    return ($r[seeds] / 1024) . " KB";
  if ($r[seeds] < 1000 * 1048576)
    return ($r[seeds] / 1048576) . " MB";
  if ($r[seeds] < 1000 * 1073741824)
    return ($r[seeds] / 1073741824) . " GB";
	if ($r[seeds] < 1001 * 1073741824)
  return ($r[seeds] / 1099511627776) . " TB";

Houdini

What are you trying to do exactly?

elcius

I think he's just trying to get it to return the size est. of a set amount of bites, no?

if($r[seeds]>=1099511627776)return ($r[seeds]/1099511627776)." TB"
elseif($r[seeds]>=1073741824)return ($r[seeds]/1073741824)." GB"
elseif($r[seeds]>=1048576)return ($r[seeds]/1048576)." MB"
elseif($r[seeds]>=1024)return ($r[seeds]/1024)." KB"
else return $r[seeds]." B";

lancey10

yea thats what im trying to do but the code u just gave me doesnt work

lancey10

i tried

if($r[seeds]>=1099511627776)return $r[seeds]=($r[seeds]/1099511627776)." TB";
elseif($r[seeds]>=1073741824)return $r[seeds]=($r[seeds]/1073741824)." GB";
elseif($r[seeds]>=1048576)return $r[seeds]=($r[seeds]/1048576)." MB";
elseif($r[seeds]>=1024)return $r[seeds]=($r[seeds]/1024)." KB";
else return $r[seeds]." B";

becuase i need $r[seeds] to equal the new amount and replace it on the html table

Weedpacket

Not certain about the desired rounding involved, hence, the comment. Also not knowing what "doesnt work" means.

$seeds = $r['seeds'];
if($seeds>1024) // or 10240 if you want to go up to 10239kB and then to 10MB.
{
	$suffix = 'k'; $seeds /= 1024;
}
if($seeds>1024)
{
	$suffix = 'M'; $seeds /= 1024;
}
if($seeds>1024)
{
	$suffix = 'G'; $seeds /= 1024;
}
if($seeds>1024)
{
	$suffix = 'T'; $seeds /= 1024;
}
return intval($seeds).$suffix.'B';

All this is assuming certain things about $r['seeds'] - that it contains the result of a database query, and that the type used to store the value is sufficient to store such a large number as 1099511627776, and it's not the database that's corrupting it (assuming that there is anything wrong with the original code; if there is we haven't been told what). Also assuming that the code is supposed to be the body of a function that is passed $r, and returns this string (which is a pure guess based on the use of "return" on the last line of the original code).

lancey10

ok so i accidently put seeds instead of size as the variable, but this is the part of the script im trying to chsange the size into kb, mb, tb, etc. the last code yu gave me didnt worko

while($r=mysql_fetch_array($result))
//$color = ($i%2==0)?$color1:$color2;
{
echo"
<table class='main_table' width='100%'>
<td width='69%'>
<a href='torrents.php?mode=details&amp;id='>
$r[filename]
</a>
</td>
<td width='13%' align = 'center'>$r[size]
</td>
<td width='9%'>
$r[seeds]</td>
<td width='9%'>
$r[leechers]</td>
</tr>
</table>";
}
//$i++;
/* Display the pages down the bottom */
echo '<br>Pages: '.round($numofpages).'<br>';

per_page("?page=%page", "5");

?>

bpat1434

Are you positive of the value of $r['size']? Because Weedpackets looks like it should work perfectly fine.

could always try:

function kMGTB($size)
{
  $kB = 1024; 
  $MB = $kB*1024;
  $GB = $MB*1024;
  $TB = $GB*1024;

  if($size < $kB)
    return $size.' kB';
  elseif($size < $MB){
    return (round($size/$MB, 2)).' MB';
  elseif($size < $GB)
    return (round($size/$GB, 2)).' GB';
  elseif($size < $TB)
    return (round($size/$TB, 2)).' TB';
  else
    return $size.' ??';
}

echo '<table class="main_table" width='100%'>
<td width='69%'>
<a href="torrents.php?mode=details&amp;id=">'.$r['filename'].'</a>
</td>
<td width="13%" align="center">'.kMGTB($r['size']).'
</td>
<td width="9%">'.$r['seeds'].'</td>
<td width="9%">'.$r['leechers'].'</td>
</tr>
</table>';

Weedpacket

Whoo, it's getting worse; not only "it didnt work" but "it didnt worko" as well. I'm glad we've got such detailed information to go on.

Incidentally, nowhere are you using this function to rescale the size, and nowhere are you using the return value. So how are you trying to use this code?

lancey10

im sorry for no detailed information, i thought it was self explanatory, but i got a parse error still:
Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /homepages/43/d147142614/htdocs/main.php on line 261

and line 261 is:
<a href='torrents.php?mode=details&id='>'.$r['filename'].'</a>

bpat1434

And which code are you using?

This is one reason why Weedpacket said:

I'm glad we've got such detailed information to go on.

New code, this will work:

function kMGTB($size)
{
  $kB = 1024;
  $MB = $kB*1024;
  $GB = $MB*1024;
  $TB = $GB*1024;

  if($size < $MB)
    return (round($size/$kB, 2)).' kB';
  elseif($size < $GB)
    return (round($size/$MB, 2)).' MB';
  elseif($size < $TB)
    return (round($size/$GB, 2)).' GB';
  else
    return (round($size/$TB, 2)).' TB';
}

And if you want stuff less than 1kB to show up as ??B use this:

function kMGTB($size)
{
  $kB = 1024;
  $MB = $kB*1024;
  $GB = $MB*1024;
  $TB = $GB*1024;

  if($size < $kB)
	return (round($size, 2)).' B';
  elseif($size < $MB)
    return (round($size/$kB, 2)).' kB';
  elseif($size < $GB)
    return (round($size/$MB, 2)).' MB';
  elseif($size < $TB)
    return (round($size/$GB, 2)).' GB';
  else
    return (round($size/$TB, 2)).' TB';
}

I tested it in a recursive loop for a directory, so I know it works.

TF_TheMoon

lancey10 wrote:
im sorry for no detailed information, i thought it was self explanatory, but i got a parse error still:
Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /homepages/43/d147142614/htdocs/main.php on line 261

and line 261 is:
<a href='torrents.php?mode=details&id='>'.$r['filename'].'</a>

Is this in your PHP or HTML code?

Looking at what you're doing and guessing just change that for this

<a href="torrents.php?mode=details&id=">'.$r['filename'].'</a>

You're using ' all the time for both HTML and then to try to concat a string

samudasu

lancey10, i think your main problem is that you don't understand how "return" works. I'm guessing that you want to see the returned value but you're unable. Here's your code put into a function, i think this is what you're after. bpat1434's code is a little nicer, you might want to use it.

Do some reading on how return is used.
http://www.php.net/manual/en/function.return.php

function getsize($size)
{
    if ($size < 1000 * 1024)
        return ($size / 1024) . " KB";
    if ($size < 1000 * 1048576)
        return ($size / 1048576) . " MB";
    if ($size < 1000 * 1073741824)
        return ($size / 1073741824) . " GB";
    if ($size < 1000 * 1099511627776)
       return ($size / 1099511627776) . " TB";
}
print getsize($r['seeds']);

http://www.php.net/manual/en/function.return.php

lancey10

IT WORKS, sorry guys that i didnt write out a good explanation, ill get better sooner or later, lol, but the problem was the # percentage like in:

suppose to be like:

<table class="main_table" width=100%> with out quotaion

lancey10

another question, will this work:

$seeds=$r['seeds'];
<? if $seeds < 100) {?>
<div class=r>
<? } ?>

bpat1434

Nope, you have a parse error....

<? if $seeds < 100) {?>

But after you fix it, it would if you put $seed=$r['seeds'] inside PHP tags....

lancey10

i know its suppose to be <? if ($seeds < 100) {?> but for some reason it doesnt work, it makes every seed including one greater then 100 the same color as the div class

lancey10

and also, how do i make it so when ever there is an error, it doesnt display the mysql error?

Weedpacket

lancey10 wrote:
IT WORKS, sorry guys that i didnt write out a good explanation, ill get better sooner or later, lol, but the problem was the # percentage like in:

<table class="main_table" width='100%'>

suppose to be like:

<table class="main_table" width=100%> with out quotaion

No, it is supposed to have quotes. But if you're using single quotes around the PHP string, you'll get into trouble if you use single quotes inside the string.

<table class="main_table" width='100%'>

Helpful suggestion: don't go around mixing quotes. Try and be consistent.

<table class="main_table" width="100%">

lancey10 wrote:
and also, how do i make it so when ever there is an error, it doesnt display the mysql error?

If you don't ask for the mysql error with mysql_error(), it won't be displayed. If you're talking about PHP errors caused by not properly handling what's returned from the MySQL function, then handle it. Turning display_errors off is something reserved for when the site goes live.

lancey10

ahh ok and thanks, but what about the post i made b4:

i know its suppose to be <? if ($seeds < 100) {?> but for some reason it doesnt work, it makes every seed including one greater then 100 the same color as the div class

anyone know why its acting like this?