Writing a Query based on Sessions

[Rollo_Tamasi]

I'm trying to run a query based on fields that i have carried over in a session.
I'm trying to update the database based on the field userid
I'm not sure what the code should be.....i'm guessing something like this but it isn't working for me i'm afraid.

f(isset($_SESSION['userid']))
{
	$query = "UPDATE package, first_name, last_name, username, company, address1, address2, address3, city, country, email_address, businessnum, mobile, cctype, ccname, ccnum, month, year, ccsec, text FROM users WHERE id = '{$_SESSION['userid']}'";
} 

[laserlight]

hmm... the problem isnt with your use of the session variable, but that your SQL statement doesnt make sense in the first place.

[Houdini]

The UDATE syntax is UPDATE tablename SET column=value, column=value...WHERE clause

[Nibinaear]

Your format for the update is wrong, you seem to have done a strange combination of select and insert. It would be best if you look this up in the mysql manual:

Mysql Manual Update Syntax

This would be better (took me ages to type!):

$query="update students set package=\"whatever\",first_name=\"Bob\",last_name=\"Smith\",\"BigGuy\",company=\"Microsoft\",address1=\"the house\",address2=\"the road\",address3=\"the city\",city=\"London\",country=\"England\",email_address=\"[e-mail]\",businessnum=01938193847,mobile=07748294727,cctype=\"\",ccname=\"\",ccnum=\"\",month=\"jan\",year='2006',ccsec=\"\",text=\"what are these fields for?!\" where id=".$_SESSION['userid'];

[Rollo_Tamasi]

thanks for the reponses guys, i have added this code:

<?

session_start(); 

include 'db.php';

$query = "SELECT userid, first_name, last_name FROM users WHERE userid = '{$_SESSION['userid']}'";
    $result = mysql_query($query) or die('Error : ' . mysql_error());
    list('$first_name', '$last_name');

?>

to pull the fields uerid, first_name and last_name from the db users but i get an error:
"Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ')' in Line 15 (which is the line - list('$first_name', '$last_name')😉

any ideas?

[Rollo_Tamasi]

I have sorted out the previous problem.
I have the script rendering in the browser now without any errors but i have a problem with inserting the new data into the database. The script basically replaces the current data that is contained in the db with a new one which the user inputs.

So far the edit.php page brings up the input text boxes with the current information in it. However when i enter in the new data and hit submit...the current data remains :mad: .
So it basically doesn't update properly.

here is my code as it stands at the moment

<?
session_start(); 

include 'db.php';

?>
<?php


$query = "SELECT userid, first_name, last_name FROM users WHERE userid = '{$_SESSION['userid']}'";
$result = mysql_query($query) or die('Error : ' . mysql_error());
if(mysql_num_rows($result))
{
  $row = mysql_fetch_assoc($result);
  echo "First: {$row['first_name']}, Last: {$row['last_name']}";
}
//else
//{
  // handle no match found error here
//} 
else if(isset($_POST['userid']))
{

$first_name = $_POST['first_name2'];
$last_name = $_POST['last_name2'];


// update the article in the database
$query = "UPDATE users SET first_name = '$first_name' , last_name = '$last_name' WHERE userid = '{$_SESSION['userid']}'";


$first_name   = stripslashes($first_name);
$last_name = stripslashes($last_name);
}
?>
<form method="post" action="edit2.php">
<input type="hidden" name="userid" value="<?=$userid;?>">
  <table width="700" border="0" cellpadding="2" cellspacing="1" class="box" align="center">
    <tr> 
      <td width="100">Title</td>
      <td><input name="first_name" type="text" id="first_name" value="<?=$first_name;?>"></td>
    </tr>
    <tr> 
      <td width="100">Content</td>
      <td><input name="last_name" type="text" id="last_name" value="<?=$last_name;?>"></td>
    </tr>
    <tr> 
      <td width="100">&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td colspan="2" align="center"><input name="update" type="submit" id="update" value="Update"></td>
    </tr>
  </table>

</form>

any ideas? thank god this is the final hurdle.

[samudasu]

Yes, don't use else if. Just use if. The most important thing is that you're not sending the second $query to the database so how does it have the chance to update?

[Rollo_Tamasi]

thank you, the if statement worked