Stuck in a loop

clo8

I'm new to PHP, I've had to learn it for an assignment at uni. The following code works and displays a record when it's true but doesn't print anything out when it's false it just reloads the page.

if ($form)
{
$result = mysql_query("SELECT * FROM availability", $dbh);

while ($rec = mysql_fetch_array($result))
{
$ok = 0;
if ($date && $rec["date"] == $date)
$ok = 1;

if ($ok)

{
print "The following date was found: \n";
print "Date: " . $rec["date"] . " \n";
print "Available: " . $rec["available"] . " \n";
print "Price: " . $rec["price"] . " \n";
print "<a href=dateform.php>Enquire about booking this date</a> \n";
}
}
}

I realise there's nothing in there at the moment to get it to print out if it's false but I've tried putting the line everywhere and it either doesn't do it or errors. I'm starting to wonder if the loops the wrong sort??

Any help would be great!!!

xcx

gardnc

$ok = 0;
if ($date && $rec["date"] == $date)
$ok = 1;

if ($ok)

It's never false, it's always either 0 or 1.

clo8

Ok but if I place:

if ($ok = 1)
{
print "No date has been found please ensure you are following the guidelines below";
}

below the part if ($ok = 0) then it loops it as many times as there are records in the table. I think it's something to do with the while loop but don't I need this to pull the records out of the table in the first place?

Weedpacket

Comparison uses ==. = means assignment.

I don't know why people insist on always using "while($row = mysql_fetch_array())".

$result = mysql_query("SELECT * FROM availability", $dbh);

$returned_rows = mysql_num_rows($result);

if($returned_rows>0)
{
	// there are records to display. Loop through and display them.
	// if you insist, you can use a while($row=...) loop here.
	for($i=0; $i<$returned_rows; $i++)
	{
		$row = mysql_fetch_array($result);
		// ... etc.
	}
}
else
{
	// There were no records returned. Time to do something else instead.
}

And don't tell me you really are using tags for this....

clo8

<?php

$dbh=mysql_connect etc

$result = mysql_query("SELECT * FROM availability", $dbh);

$returned_rows = mysql_num_rows($result);

if($returned_rows>0)
{

for($i=0; $i<$returned_rows; $i++) 
{ 
    $row = mysql_fetch_array($result); 
    print "<font size=2 face=Verdana>The following date was found:</font><br><br>\n";

    print "<font size=2 face=Verdana><b>Date:</b> " . $rec["date"] . "</font><br>\n";

    print "<font size=2 face=Verdana><b>Available:</b> " . $rec["available"] . "</font><br>\n";

    print "<font size=2 face=Verdana><b>Price:</b> " . $rec["price"] . "</font><br><br>\n";

    print "<font size=2 face=Verdana><a href=dateform.php><font color=#996633>Enquire about booking this date</font></a></font><br>\n";


}

}
else
{
print "There were no matching records found, please ensure you are following the guidelines below";
}

This loops the headers but doesn't pull anything from the db. I know I'm probably being really stupid here but most of this is going straight over my head!!

And yes, I'm sure there is a better way to do the font without tagging it but I'm seriously a complete beginner!!

xcx

rincewind456

Well it won't print anything as your accessing the array with $row, yet trying to print it by calling $rec?

If BTW you are a complete beginner then STOP using font tags now. use CSS to style your pages.

clo8

I think I'm just confusing myself more and more!! I basically need a loop that takes a value entered via a search form and compares it to fields in the database, then if it matches displays that field and if it doesn't displays a message saying there are no matching fields.

Will look into CSS!

xcx

Weedpacket

rincewind456 is referring to these lines in your code:

$row = mysql_fetch_array($result);

and

print "<font size=2 face=Verdana><b>Date:</b> " . $rec["date"] . "</font><br>\n";

What you're confused about is what you've named the variable.

clo8

I realised that and changed $rec to $row but it still isn't working

rincewind456

clo8 wrote:
I think I'm just confusing myself more and more!! I basically need a loop that takes a value entered via a search form and compares it to fields in the database, then if it matches displays that field and if it doesn't displays a message saying there are no matching fields.
xcx

Yes I think you are as the code you have posted here doesn't do that!

Your code will need to change to something like this

$search_term = mysql_real_escape_string(trim($_POST['search_term']));

$result = mysql_query("SELECT * FROM availability WHERE field_name = $search_term");

this will search a a search term against a particular mysql field, to search more than one field and more than one term just add more "where" criteria.

You will also need to check that the array you are pulling data from is actually populated the way you think it is so after the line

$row = mysql_fetch_array($result);

use this to see the array contents, specifically the array keys

echo "<pre>";
print_r($row);
echo "</pre>";

You'll then be able to check that the $row names are correct;