[RESOLVED] Issue validating posts

[dmacman1962]

Hi Everyone,

I am attempting to use a method weedpacket showed me to validate my forms and I seem to be missing something. It tells me I did not fill in all the entries wether I did or not.

Here is sample of the first 2 form fields...

<tr>
<td width="147">Adam Sandler</td>
    <td width="118"><input name="N[0]" type="radio" value="1" /></td>
    <td width="124"><input name="N[0]" type="radio" value="2" /></td>
    <td width="100"><input name="N[0]" type="radio" value="3" /></td>
    <td width="135"><input name="N[0]" type="radio" value="4" /></td>
    <td width="170"><input name="N[0]" type="radio" value="5" /></td>
  </tr>
  <tr>
    <td>Arnold Schwarzenegger</td>
    <td><input name="N[1]" type="radio" value="1" /></td>
    <td><input name="N[1]" type="radio" value="2" /></td>
	<td><input name="N[1]" type="radio" value="3" /></td>
    <td><input name="N[1]" type="radio" value="4" /></td>
    <td><input name="N[1]" type="radio" value="5" /></td>
</tr>

And the process to validate the entries and make them an array.

//Make sure they voted for all celebs
if(!isset($_POST['Name'])) { // You did not select any boxes
 	$_POST['Name'] = array();// Make it an array
    die("<p align='center'><font face='Arial' size='3' color='#FF0000'>You did not vote for all the celebrities. <br>Please hit the back button and finish voting.</font></p>");  // Go back
} else {
//Loop thru the posts
//$_POST['Name'] = array();// Make it an array
		foreach ($_POST['Name'] as $n) { //Set the elements in the array
  			  for( $c = 0; $c <= 45; $c++ )	{
       			 ${'Name'.$c} = $n[$c];
    						}
	}
}

I know this is close, I just dont see the error.

Thanks in advance,

Don

[Installer]

The name of your posted array is "N", not "Name".

[dmacman1962]

Sorry, I was trying to use weedpackets validation with another persons suggestion on making the answers and array so I can insert them.

I broke these 2 apart to clear up the issues.

But now, if I vote for nobody, it tells me I did not vote, but if I vote for just a single person, it completes the proccess, (it should not let me continue until I voted for all the people).?

Here is what I have for the validation now.

//Make sure they voted for all celebs
if(!isset($_POST['N'])) { // You did not select any boxes
 	$_POST['N'] = array();// Make it an array
    die("<p align='center'><font face='Arial' size='3' color='#FF0000'>You did not vote for all the celebrities. <br>Please hit the back button and finish voting.</font></p>");  // Go back
} 

And for the names array...

//Loop thru the posts
$_POST['Name'] = array();// Make it an array
		foreach ($_POST['Name'] as $n) { //Set the elements in the array
  			  for( $c = 0; $c <= 45; $c++ )	{
       			 ${'Name'.$c} = $n[$c];
    						}
	}

IThere must be a different validation technique to ensure all the selection where filled in, I just dont see it here.

Any ideas?

Thanks,

Don

[Installer]

Here's one way you could do it:

$star_array = array('Adam Sandler', 'Arnold Schwarzenegger');

if (!isset($_POST['submit'])) {
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="post">' .
         '<table>';
    foreach ($star_array as $star) {
        echo '<tr><td width="147">' . $star . '</td>';
        for ($rating = 1; $rating <= 5; $rating++) {
            echo '<td width="118"><input name="N[' . $star . ']" type="radio" value="' . $rating . '" /></td>';
        }
        echo '</tr>';
    }
    echo '<tr><td><input name="submit" type="submit" value="submit" />';
         '</td></tr></table></form>';

} else {
    foreach ($star_array as $star) {
        if (!isset($_POST['N'][$star])) {
            die('<p>You did not vote for all etc.</p>');
        }
    }
    echo 'You voted for all etc.';
    // do_stuff();
}

I put it all into one file just for simplicity, to demonstrate. Having the names in an array would make it easier to handle the $_POST['N'] array. The array could be put at the top of the script, as here, or pulled from an included file or database. That would also make it easier to edit the names, if needed. Using arrays makes it possible to use for and foreach loops, which makes the code more concise, among many benefits.

[dmacman1962]

Hi Installer,

Thanks for helping.

I did what you suggested and I have the names in a table as such.

ID | QRatingID | Name
1 | 1 | Adam Sandler
1 | 1 | Arnold Schwarzenegger

etc. so I tried to build the array like this.

$sql="SELECT * FROM QRatingNames";
$result=mysql_query($sql,$conn) or die(mysql_error());
while ($row = mysql_fetch_array($result)) {
	$star = $row['Name'];
	$star_array = array($star);
	}


// run script
 //$star_array = array('Adam Sandler', 'Arnold Schwarzenegger');

if (!isset($_POST['submit'])) {
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="post">' .
         '<table>';

// and the rest of your code is the same....

But I only get the last entry.

Am I close?

With your help, I think I will get this up by the deadline of Wednesday.

Thanks,

Don

[Installer]

$sql = "SELECT * FROM QRatingNames"; 
$result = mysql_query($sql,$conn) or die(mysql_error()); 
while ($row = mysql_fetch_array($result)) { 
    $star_array[] = $row['Name']; 
}

I hope you meet your deadline, but I'm sure you know that that's not what I'm trying for here, that I'm offering this code as something to help you understand PHP. Good luck.

[dmacman1962]

Hi Installer,

No, I know that is not your intent, nor mine, just making a comment.

I am ALWAYS trying to learn and improve, that's why I love this forum.

I learn more here than all the other forums I visit combined!

I made your change and I see where I was trying to make it an array and you changed it to...

$star_array[] = $row['Name'];

I have this as the complete form and it is getting all the names, but if I only vote for some, it just resets the form and goes back.

Here is the compete code...

$sql="SELECT * FROM QRatingNames";
$result=mysql_query($sql,$conn) or die(mysql_error());
while ($row = mysql_fetch_array($result)) {
    $star_array[] = $row['Name'];
} 

// run script
if (!isset($_POST['submit'])) {
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="post">' .
         '<table>';
    foreach ($star_array as $star) {
        echo '<tr><td width="147">' . $star . '</td>';
        for ($rating = 1; $rating <= 5; $rating++) {
            echo '<td width="118"><input name="N[' . $star . ']" type="radio" value="' . $rating . '" /></td>';
        }
        echo '</tr>';
    }
    echo '<tr><td align="center" colspan="6"><input name="Reset" type="reset" value="Reset" />&nbsp;&nbsp;<input name="Submit" type="submit" value="Submit" />';
         '</td></tr></table></form>';

} else {
    foreach ($star_array as $star) {
        if (!isset($_POST['N'][$star])) {
            die('<p>You did not vote for all etc.</p>');
        }
    }
    echo 'You voted for all etc.';
    // do_stuff();
} 

Did I make a mistake?

Thanks,

Don

[Installer]

Dunno. 🙂 I'll set up a small test db table and check it out. Meanwhile here are couple more ideas:

If you wanted to use sessions, you could eliminate the need to query the db each time the script runs. Just put "session_start()" at the top of the script, and replace this line:

$star_array[] = $row['Name'];

with this one:

$_SESSION['names'][] = $row['Name'];

Then substitute "$_SESSION['names']" for "$star_array" in the rest of the script.

Also, for a little gain in speed, you could use this:

// If using sessions; else use "$star_array"
    if (!isset($_POST['N']) || (count($_POST['N']) !== count($_SESSION['names'])) {
        die('<p>You did not vote for all etc.</p>');
    }

instead of this:

// Likewise
    foreach ($_SESSION['names'] as $star) {
        if (!isset($_POST['N'][$star])) {
            die('<p>You did not vote for all etc.</p>');
        }
    }

[Installer]

This is pretty complete, I think. It will keep track of the checked values. I tested it, but not exhaustively, and it seems to work well.

session_start();

if (!isset($_SESSION['names'])) {
    $db_server = 'example.com:3306';
    $user      = 'user';
    $password  = 'password';
    $conn = mysql_connect ($db_server, $user, $password);
    if ($conn === false) {
        die('Connection to "' . $db_server . '" failed: ' . mysql_error() . '<br />');
    }
    $query = "USE example";
    $result = mysql_query($query);
    $sql = "SELECT * FROM QRatingNames"; 
    $result = mysql_query($sql, $conn) or die(mysql_error()); 
    while ($row = mysql_fetch_array($result)) { 
        $_SESSION['names'][] = $row['Name'];
        $_SESSION['checked'][$row['Name']] = 0; 
    } 
}

if (!isset($_POST['submit'])) {
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="post">' .
         '<table>';
    foreach ($_SESSION['names'] as $star) {
        echo '<tr><td width="147">' . $star . '</td>';
        for ($rating = 1; $rating <= 5; $rating++) {
            echo '<td width="118"><input name="N[' . $star . ']" type="radio" ';
            if ($rating == $_SESSION['checked'][$star]) {
                echo 'checked="checked" ';
            }
            echo 'value="' . $rating . '" /></td>';
        }
        echo '</tr>';
    }
    echo '<tr><td><input name="submit" type="submit" value="submit" />' .
         '</td></tr></table></form>';
} else {
    if (!isset($_POST['N'])) {
        die('<p>You did not vote for any etc.</p>');
    } elseif (count($_POST['N']) !== count($_SESSION['names'])) {
        echo '<p>You did not vote for all etc.</p>';
        foreach ($_SESSION['names'] as $key => $value) {
            if (isset($_POST['N'][$value])) {
                $_SESSION['checked'][$value] = $_POST['N'][$value];
            } else {
                $_SESSION['checked'][$value] = 0;
            }
        }
    } else {
        echo 'All voted for etc.';
        // do_stuff();
    }
}

It's too late at night for a coherent explanation, so I'll just let you plow through it.

hth

[dmacman1962]

Hi Installer,

Wow, You wrote some sweet code, thanks.

You did several things I either have not seen before or could not pull off.

1) I've never seen using an sessions used like this before, I like.

$_SESSION['names'][] = $row['Name'];
$_SESSION['checked'][$row['Name']] = 0;

2) You nested several loops and did some cool verifying.

3) Was willing to help a person to the solution, not just throw some code at somone. I respect that.

And again, I wasn't looking for someone to do all the work for me, but help and guide me along. I am going to play around with some of the techniques you did here with other files I have and see what I can come up with.

You rock!

I hope someday I can help you back.

Thanks,

Don