how to write a download file code in php

thread_PHP

hi i am getting problems with downloading the files i am displaying the page i am showning some records as a hyper link and i am unable to download the file please help me i am sure i might have written wrong code somewhere please correct me

<?
session_start();

$uid= $_SESSION['loguid'];

if($uid=='')
{
$_SESSION['loguid']="Guest";

$uid=  $_SESSION['loguid'];	
}
require("header.php");

error_reporting(0); //disables any PHP warnings or errors on the page. 
$server=$HTTP_SERVER_VARS["SERVER_NAME"]; // provides the domainname
$link="http://$server/"; //main link
?>

<html>
<head>
<title>Trans-verse - Upload page</title>
<meta http-equiv='Content-Type' content="text/html; charset=iso-8859-1">
<style type="text/css"> 
<!-- 
.box { 
    font-family: Arial, Helvetica, sans-serif; 
    font-size: 12px; 
    border: 1px solid #000000; 
} 
--> 
</style> 

</head>
<body>

<form  action="downloads1.php" method="POST">
<table align="center">
<TR><TD>
<div class="containermain">
<div class="topnavi">
<? include "trans-verse.html" ?>
</div>


<? 
include("config.php"); 

	$ob=new Configure;		 
	$ob->connDB();  
  	$ob->selDB();

$qry=sprintf("select * from doctorfile ");

$res=mysql_query($qry);
?>
<table border="0" cols="2" >


<?php
while($row=mysql_fetch_array($res,MYSQL_BOTH))
{
	$filename=$row['voicefilenumber'];
	//print $filename;
	//$fname=split($filename,".",3);
	$fileext=substr($filename,strlen($fileext));
	print $fileext;
	$fname=substr($filename,".",$filename);

	print "Name:".$fname;

print "<tr> <td><a href=downloads1.php?id=$fname>$fname</a></td></tr>";
print "<tr> <td><A class=alpha href=\"downloads1.php\">  $fname</a> </td></tr>";	
$file_ext= substr($fname,-4,4);
//$filename='mambo1.bmp';
	$dir="./docproject"; 

echo $dir;

if (isset($_REQUEST["voicefilenumber"])) 
{ 
    $file=$dir.$_REQUEST["voicefilenumber"]; 

    header("Content-type: application/force-download"); 
    header("Content-Transfer-Encoding: Binary"); 
    header("Content-length: ".filesize($file)); 
    header("Content-disposition: attachment; filename=\"".basename($file)."\""); 
    readfile("$file"); 
} 
else 
{ 
	echo "No file selected"; 
} 




}

	?>
</table>
</TD>
</TR>
</table>
<?php require("body.php");
require("includes/footer.php");
?>
</form>
</body>
</html>

THANKS IN ADVANCE

jpmoriarty

The "header" commands have to come before anything else is sent to the browser - before any html. You can't just start sending header commands in the middle of an html document - what's the browser going to do? It's gets halfway through displaying your page and then suddenly gets sent a header (the clue's in the name - it comes at the head!) telling it that it's not actually supposed to be displaying an html document, it's supposed to be handling a file.

If you make a new page which doesn't output any HTML at all, just gets sent those headers, then you should find you have more luck

Weedpacket

What he said. On a side note, the MIME type you should be using is "application/octet-stream". "application/force-download" isn't recognised.