MySQL - Resource id #5 [error]

[notset]

$config['text_ads'] = 3;
if ($ad_type == 'text') {
  $sql = "SELECT `id`,`name`,`url` FROM `ads` WHERE `batch` > 0 AND `amount` > `views` AND `type` = '".$ad_type."' ORDER BY RAND() LIMIT ".$config['text_ads'];
  $result = mysql_query($sql) OR exit(mysql_error());
  if (mysql_num_rows($result) > 0) {
    while ($row = mysql_fetch_array($result)) {
      echo $row['name'];
    }
  }
}

I get:
Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource

it's in line: while ($row = mysql_fetch_array($result)) {

echo $result shows:
Resource id #5

Where is the problem?

Thank's

[laserlight]

hmm... at a glance it looks okay. However, it shouldnt even reach the point, since mysql_query() should fail.

Have you tried printing the SQL statement to check if it is valid? Does the call to mysql_num_rows() also indicate a warning?

[notset]

$sql returns:
SELECT id,name,url FROM ads WHERE batch > 0 AND amount > views AND type = 'text' ORDER BY RAND() LIMIT 3

mysql_num_rows($result) - fine:
2

[laserlight]

Okay... very strange indeed.

Put aside your current script, and just test with this script, replacing the dummy connection and database settings:

mysql_connect("server", "username", "password")
	OR die(mysql_error());
mysql_select_db("database")
	OR die(mysql_error());
$sql = "SELECT `id`, `name`, `url` FROM `ads`
	WHERE `batch` > 0 AND `amount` > `views` AND `type` = 'text'
	ORDER BY RAND() LIMIT 3";
$result = mysql_query($sql)
	OR die(mysql_error());

if (mysql_num_rows($result) > 0) {
	while ($row = mysql_fetch_array($result)) {
		echo $row['name'];
	}
} else {
	echo 'No rows in result set';
}

[notset]

Your script works fine - i get the true result and no errors 🙂

[laserlight]

Your script works fine - i get the true result and no errors

Okay, that means that there is something wrong elsewhere in your original script.

[notset]

Thank you very much, laserlight. I found the problem.

[laserlight]

Ah, cool 🙂
Could you state what it was? I'm quite curious because it was rather strange.

[notset]

Oh, it was a stupid mistake in the part of code which i didn't copy here - i used the same string for mysql query in the cycle.

while ($row = mysql_fetch_array($result)) {
$sql = "UPDATE ads SET views = views+1, lastview = '".date("Y-m-d H:i:s", time()+36000)."' WHERE id = '".$row['id']."'";
$result = mysql_query($sql) OR exit(mysql_error());
}