Please Help Me ASAP!! :(

angelkay73

I am EXTREMELY new to PHP, only a few weeks in. Can someone please look at my code and see what I am doing wrong? I have to turn this in, but I have looked at it too long and I am completely stumped. I am trying to create an e-mail project. Thank you so much for the help!!

Thank you,
Angel

<? php

$authuser = '1234';

$username = "root";
$password = "******";
$db = "angel_test";

mysql_connect('localhost', $username, $password);
mysql_select_db($db);

$query = Select messageFrom, messageSubject, messageDate
from cw_message
where user = "$authuser";
$results = mysql_query($query)';

$numRows = mysql_numrows($result);

mysql_close();

//echo "The first part works!";

$counter = 0;
while ($counter < $numRows)
{
$from = mysql_result($result, $counter, "messageFrom");
$subject = mysql_result($result, $counter, "messageSubject");
$date = mysql_result($result, $counter, "messageDate");

echo $from "<BR>";
echo $subject "<BR>";
echo $date "<BR>";

$counter ++;

//echo "The While Statement Works!";
}

//echo "This Works!";

bpat1434

1.) You don't assign the connection to a variable (no big deal) but you also don't check to see if you connected:

mysql_connect('localhost', $username, $password);
mysql_select_db($db);

2.) Your syntax is wrong here. You need to encapsulate strings in quotes:

$query = Select messageFrom, messageSubject, messageDate
from cw_message
where user = "$authuser";

3.) This is a deprecated way of getting the number of rows returned, and you should instead use mysql_num_rows:

mysql_numrows($result);
// Should use:
mysql_num_rows($result);

4.) This can be reduced to a simple while loop. Also, you have a syntax error in your string concatenation. You really should watch it:

$counter = 0;
while ($counter < $numRows)
{
$from = mysql_result($result, $counter, "messageFrom");
$subject = mysql_result($result, $counter, "messageSubject");
$date = mysql_result($result, $counter, "messageDate");

echo $from "<BR>";
echo $subject "<BR>";
echo $date "<BR>";

$counter ++;

//echo "The While Statement Works!";
}

so it becomes:

while($row = mysql_fetch_array($result))
{
  echo $row['messageFrom'] . "<BR>";
  echo $row['messageSubject'] . "<BR>";
  echo $row['messageDate'] . "<BR>";

//echo "The While Statement Works!";
}

angelkay73

Thanks so much for the reply! Did I mention I am not a programmer? And that I am extremely stupid when it comes to PHP? 🙂 I made a few changes from your reply, however, I am still having problems. Before when I tried to run it, I only got a blank screen. Now when I run it I simply get a post of my code. Any suggestions? Sorry to be so stupid 🙁

Thank you!

bpat1434

When you get a blank screen, it usually means PHP has found an error in your code. It also means you need to modify the error reporting of PHP to either log it in a file, or to show it on screen. Search the forums, we've got a long discussion going on error_reporting now....