Undefined Index/INSERT Statement

[jennifer_ann]

I keep getting an undefined index error. I thought my INSERT statement would take care of that but nothing I am trying works. I've tried the EXTRACT ($_POST) method, and naming each individual variable, but still the same error.....

<?php

$Customer_Lname=$_POST['lastname'];
$Customer_Fname=$_POST['firstname'];
$Customer_address=$_POST['address'];
$Customer_city=$_POST['city'];
$Customer_state=$_POST['state'];
$Customer_zipcode=$_POST['zipcode'];
$Customer_email=$_POST['email'];
$Customer_username=$_POST['username'];
$Customer_password=$_POST['password'];


// open connection to database
$db = mysql_connect("localhost", "root", "");
if (!$db)
{
 	print "unable to connect!";
	exit;
}

//select database to use
$db= mysql_select_db ("mapleside");
if (!$db)
{
		print "could not select database";
	exit;
}

// create SQL query	 string
$query = "INSERT INTO customer (Customer_Lname, Customer_Fname, Customer_address, Customer_city, Customer_state, Customer_zipcode, Customer_email, Customer_username, Customer_password) VALUES ($Customer_Lname, $Customer_Fname, $Customer_address, $Customer_city, $Customer_state, $Customer_zipcode, $Customer_email, $Customer_username , $Customer_password)";
$result = mysql_query($query);

mysql_query($query) or die
	('Error, insert query failed');
echo('Data inserted successfully' );

//close connection
mysql_close();

// This will have to be adjusted once the pages are completed. 

?>

By the way, thanks to all who helped me with my forms. They are up and working now! I appreciate it!

[Houdini]

You are overwriting $db originally the connection resource with $db the database resource

$db = mysql_connect("localhost", "root", "");//This is ok untill....
if (!$db)
{
    print "unable to connect!";
    exit;
}

//select database to use
$db= mysql_select_db ("mapleside")//you overwrite it here

so change it to something like this

$connect = mysql_connect("localhost", "root", "");
if (!$db)
{
    print "unable to connect!";
    exit;
}

//select database to use
$db= mysql_select_db ("mapleside")

[thorpe]

You need to check these post variables actually exist. Use [man]isset[/man] or [man]empty[/man].

You'll also get an error in your sql statement because your values aren't enclosed in quotes. eg;

$sql = "INSERT INTO tbl (fld) VALUES ('$foo')";

[jennifer_ann]

Houdini =) I think I'll just take you everywhere I go and steal ya!

[jennifer_ann]

Now what is ('$foo')?

[thorpe]

Its an example. You need to surround your values in quotes.

[Houdini]

$foo $bar $wombat are just variables that really have no meaning at all programmers have been using them for a while, not sure what started it but for most purposes it has no real meaning, I am sure if you did a google search or went to Wikipedia you could find out more but I never really concerned myself with it, they are just non sensical might have been becuase of the Foo Fighters for all I know.

[jennifer_ann]

See there has to be something else I'm doing wrong cause even when I put quotes around them, I still get index error

[thorpe]

Did you read my original post?

You need to check these post variables actually exist. Use isset or empty.

Need an example?

if (!empty($_POST['lastname']) {
  $Customer_Lname=$_POST['lastname'];
} else {
  $Customer_Lname='';
}

[Houdini]

Would any of those variables be a $_SESSION variable? Somewhere they have to get assigned a value.

[jennifer_ann]

Thorpe, yes thank you I did put that into my code and re ran it but no luck.

[thorpe]

Post what you have now.

[jennifer_ann]

<?php

$Customer_Lname=$_POST['lastname'];
$Customer_Fname=$_POST['firstname'];
$Customer_address=$_POST['address'];
$Customer_city=$_POST['city'];
$Customer_state=$_POST['state'];
$Customer_zipcode=$_POST['zipcode'];
$Customer_email=$_POST['email'];
$Customer_username=$_POST['username'];
$Customer_password=$_POST['password'];

// Open Connection
 $connect = mysql_connect("localhost", "root", "");
if (!$db)
{
    print "unable to connect!";
    exit;
}

//select database to use
$db= mysql_select_db ("mapleside") 

// create SQL query	 string
$query = "INSERT INTO customer (Customer_Lname, Customer_Fname, Customer_address, Customer_city, Customer_state, Customer_zipcode, Customer_email, Customer_username, Customer_password) VALUES ('$Customer_Lname', '$Customer_Fname', '$Customer_address', '$Customer_city', '$Customer_state', '$Customer_zipcode', '$Customer_email', '$Customer_username' , '$Customer_password')";
$result = mysql_query($query);

if (!empty($_POST['lastname']) {
  $Customer_Lname=$_POST['lastname'];
} else {
  $Customer_Lname='';
} 
if (!empty($_POST['firstname']) {
  $Customer_Fname=$_POST['firstname'];
} else {
  $Customer_Fname='';
} 
if (!empty($_POST['address']) {
  $Customer_address=$_POST['address'];
} else {
  $Customer_address='';
} 
if (!empty($_POST['city']) {
  $Customer_city=$_POST['city'];
} else {
  $Customer_city='';
} 
if (!empty($_POST['state']) {
  $Customer_state=$_POST['state'];
} else {
  $Customer_state='';
} 
if (!empty($_POST['zipcode']) {
  $Customer_zipcode=$_POST['zipcode'];
} else {
  $Customer_zipcode='';
} 
if (!empty($_POST['email']) {
  $Customer_email=$_POST['email'];
} else {
  $Customer_email='';
} 
if (!empty($_POST['username']) {
  $Customer_username=$_POST['username'];
} else {
  $Customer_username='';
} 
if (!empty($_POST['password']) {
  $Customer_password=$_POST['password'];
} else {
  $Customer_password='';
} 

mysql_query($query) or die
	('Error, insert query failed');
echo('Data inserted successfully' );

//close connection
mysql_close();

// This will have to be adjusted once the pages are completed. 

?>

[laserlight]

$Customer_Lname=$POST['lastname'];
$Customer_Fname=$POST['firstname'];
$Customer_address=$POST['address'];
$Customer_city=$POST['city'];
$Customer_state=$POST['state'];
$Customer_zipcode=$POST['zipcode'];
$Customer_email=$POST['email'];
$Customer_username=$POST['username'];
$Customer_password=$_POST['password'];

Remove the above mentioned block of code, since it is now useless.

[jennifer_ann]

Thank you laserlight I took it out

[thorpe]

What the? Try checking the variables BEFORE you use them.

<?php

if (!empty($_POST['lastname']) { 
  $Customer_Lname=$_POST['lastname']; 
} else { 
  $Customer_Lname=''; 
} 
if (!empty($_POST['firstname']) { 
  $Customer_Fname=$_POST['firstname']; 
} else { 
  $Customer_Fname=''; 
} 
if (!empty($_POST['address']) { 
  $Customer_address=$_POST['address']; 
} else { 
  $Customer_address=''; 
} 
if (!empty($_POST['city']) { 
  $Customer_city=$_POST['city']; 
} else { 
  $Customer_city=''; 
} 
if (!empty($_POST['state']) { 
  $Customer_state=$_POST['state']; 
} else { 
  $Customer_state=''; 
} 
if (!empty($_POST['zipcode']) { 
  $Customer_zipcode=$_POST['zipcode']; 
} else { 
  $Customer_zipcode=''; 
} 
if (!empty($_POST['email']) { 
  $Customer_email=$_POST['email']; 
} else { 
  $Customer_email=''; 
} 
if (!empty($_POST['username']) { 
  $Customer_username=$_POST['username']; 
} else { 
  $Customer_username=''; 
} 
if (!empty($_POST['password']) { 
  $Customer_password=$_POST['password']; 
} else { 
  $Customer_password=''; 
}

// Open Connection 
$connect = mysql_connect("localhost", "root", ""); 
if (!$db) 
{ 
    print "unable to connect!"; 
    exit; 
} 

//select database to use 
mysql_select_db("mapleside") 

// create SQL query     string 
$query = "INSERT INTO customer (Customer_Lname, Customer_Fname, Customer_address, Customer_city, Customer_state, Customer_zipcode, Customer_email, Customer_username, Customer_password) VALUES ('$Customer_Lname', '$Customer_Fname', '$Customer_address', '$Customer_city', '$Customer_state', '$Customer_zipcode', '$Customer_email', '$Customer_username' , '$Customer_password')"; 

mysql_query($query) or die 
    ('Error, insert query failed'); 
echo('Data inserted successfully' ); 

//close connection 
mysql_close(); 

// This will have to be adjusted once the pages are completed. 

?>

Also... you where running the query twice for some unknown reason.

[jennifer_ann]

Sorry! I'm VERY VERY new to this

[Houdini]

One major question jennifer_ann doest the form page call this page right after you hit submit? If it goes to another page you will need to use SESSION data to carry those POST variables to this page, inother words all the values you are assigning will be blank.

[Houdini]

These have been tested with a database and work at least with the information from your form and database query.
The HTML:

<html>
<head> 
    <title>Mapleside Farms</title> 
    <link rel="stylesheet" href="mapleside.css" type="text/css" /> 
</head>
<body> 
<form name = "account" action="account.php" method = "post"> 
Enter information 
<table border = 1 width = 100%><tr><td>
Last name:<input name = 'Customer_Lname'> 
</td><td > 
First name:<input name = 'Customer_Fname'> 
</td><td > 
Address: <input name = 'Customer_address'> 
</td></tr><tr><td> 
City:<input name= 'Customer_city'> 
</td><td> 
State:<input name= 'Customer_state'> 
</td><td> 
Zip Code:<input name = 'Customer_zipcode'> 
</td></tr><tr><td> 
E-Mail:<input name = 'Customer_email'> 
</td><td> 
Username:<input name = 'Customer_username'> 
</td><td> 
Password:<input name = 'Customer_password'> 
</td></tr></table>
<center><input type=submit value="go"></center>
</form> 
</body>
</html>

The account.php Page:

<?php 
$Customer_Lname=$_POST['Customer_Lname']; 
$Customer_Fname=$_POST['Customer_Fname']; 
$Customer_address=$_POST['Customer_address']; 
$Customer_city=$_POST['Customer_city']; 
$Customer_state=$_POST['Customer_state']; 
$Customer_zipcode=$_POST['Customer_zipcode']; 
$Customer_email=$_POST['Customer_email']; 
$Customer_username=$_POST['Customer_username']; 
$Customer_password=$_POST['Customer_password']; 
// open connection to database 
$connect = mysql_connect("localhost", "root", ""); 
if (!$connect) 
{ 
    print "unable to connect!"; 
    exit; 
} 
//select database to use 
$db= mysql_select_db ("mapleside"); 
if (!$db) 
{ 
        print "could not select database"; 
    exit; 
} 
// create SQL query     string 
$query = "INSERT INTO customer (Customer_Lname, Customer_Fname, Customer_address, Customer_city, Customer_state, Customer_zipcode, Customer_email, Customer_username, Customer_password) VALUES ('$Customer_Lname', '$Customer_Fname', '$Customer_address', '$Customer_city', '$Customer_state', '$Customer_zipcode', '$Customer_email', '$Customer_username' , '$Customer_password')"; 
$result = mysql_query($query) 
  or die('Error, insert query failed'); 
echo('Data inserted successfully.<br />' ); 
//close connection 
mysql_close(); 
// This will have to be adjusted once the pages are completed.
echo "$Customer_Lname $Customer_Fname $Customer_address $Customer_city $Customer_state $Customer_zipcode $Customer_email $Customer_username $Customer_password"; 
?>