[RESOLVED] File_get_contents help

Sacky

I read your sites wonderful guide on how to use the file_get_contents and i decided to do the same except get the share prices from asx.com.au
I made this code

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Share Prices</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<?php
$url = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=CML";
$handle = fopen($url, "r");
$contents = file_get_contents($url);
fclose($handle);

$cml_price = "/</a></th><td class='last'>([0-9]*)</td>/";
preg_match($cml_price, $contents, $CML);
echo $CML;

?>
</body>
</html>

This is the error it gives me

Warning: preg_match(): Unknown modifier 'a' in /home/sacky/public_html/index.php on line 14
Array

This is the site http://www.williamsack.jumbahost.com/index.php

Can anyone tell me what im doing wrong?

Houdini

Your delimiter / needs to be at the beggining and the end of your pattern so when it sees the </a it thinks the pattern is over so you either need to use a delimiter that won't be used in the pattern like

$cml_price = "#</a></th><td class='last'>([0-9]*)</td>#";

or you need to escape all delimiter symbols in the pattern that you want to be part of the pattern like this

$cml_price = "/<\/a><\/th><td class='last'>([0-9]*)<\/td>/";

My self I would just change the delimiter to the # sign.

Sacky

Thanks Houdini
But now it just says Array on the page instead of the share price? Any ideas?

Houdini

You might want to change your pattern or look at preg_match() in the manual.

bpat1434

Actually, that's the expected response.

If matches (Your $CML variable) is provided, then it is filled with the results of search. $matches[0] will contain the text that matched the full pattern, $matches[1] will have the text that matched the first captured parenthesized subpattern, and so on.

$CML will be populated with an array. To get the price do this:

$price = $CML[1][0];

If you read the preg_match manual page, it says that it returns an array, and the first element is a dump of all the matched data (in this case just one), and then after that each individual section. So you need to do a [man]var_dump[/man] to get the array structure, and then extract the price from that.

Also, take Houdini's advice. The Preg functions can take any character as its delimeter. Use that to your advantage. Only the ereg functions need to use the forward slash (/) as their delimeter.

Sacky

This is my new code

$cml_price = "#</a></th><td class='last'>([0-9]*)</td>#"; 
preg_match($cml_price, $contents, $CML);
    $price = $CML[1][0]; 
echo $price;

?>
</body>
</html>

But now it just comes up with a blank page (www.williamsack.jumbahost.com)
I also looked at the preg_match manual and i didnt really see my problem
But thanks a lot for your responses they have helped me a lot

bpat1434

You have no opening <body> tag

Sacky

I put in the <body> tag above the <?php
But still no go, a blank page

samudasu

Here's another way if you don't mind using Yahoo quotes.

<?php
$url = 'http://au.finance.yahoo.com/d/quotes.csv?s=CML.AX&f=sl1d1t1c1ohgv&e=.csv';
$fp = fopen($url, 'r');
if (($data = fgetcsv($fp, 1000)) !== false) {
    print "<pre>";
    print_r($data); // shows all data available
    print "</pre>";
    print "Last trade: $data[1]"; // show the last trade price
}
?>

Sacky

Thanks but id prefer to know what im doing rather than just copying stuff
But in regards to that script is there anyway to just make the price show rather than all the other stuff?

HalfaBee

Your regex was slightly wrong

<?php
$url = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=CML";
$contents = file_get_contents($url);

$cml_price = "#</a></th><td class='last'>([0-9\\.]*)</td>#";
preg_match($cml_price, $contents, $CML);
print_r($CML);
$price = $CML[1][0];
echo $price;
?>

bpat1434

Your pattern is wrong.... so the array doesn't get populated. Change the pattern and it shoudl work.

[edit]
Always just a few seconds late... but a couple notes:

1.) You don't need the back-slash in teh regex... it's a price.... and you don't need to "escape" the dot in a character class 😉
2.) When setting the price variable use: $price = $CML[1]; not what i gave you above. I'm used to preg_match_all() instead of preg_match.
[/edit]

HalfaBee

heh, just habit I suppose.
It worked so I was happy 😉

Sacky

OK heres my new code
<?php
$url = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=CML";
$contents = file_get_contents($url);

$cml_price = "#</a></th><td class='last'>([0-9\.]*)</td>#";
preg_match($cml_price, $contents, $CML);
print_r($CML);
$price = $CML[1];
echo $price;
?>

But now it says Array ( [0] => 10.850 [1] => 10.850 ) 10.850 on my website, which is right but i would like to get rid of all the extra stuff and leave 10.850? Is this possible?
Thanks for your help btw

Sacky

No wait i did it, just got rid of print_r, thanks a bunch guys

Sacky

Now what i want to do is this

CML: $price x 3,000 = $sum

how would i make it present that
i was thinking
$sum = $price + 3000
but it didnt work, any ideas?

bpat1434

well which is it: add 3000, or multiply by 3000?

// To add:
$sum = $price+3000;

// To Multiply:
$sum = $price*3000;

You may want to look at [man]float/man to get the sig-figs right.

Sacky

ok done the job, thank you guys so much for your help

this is my final code
<?php
$url = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=CML";
$contents = file_get_contents($url);

$cml_price = "#</a></th><td class='last'>([0-9\.])</td>#";
preg_match($cml_price, $contents, $CML);
$price = $CML[1];
$sum = $price3000;
print "CML: $price x 3000 = $sum";
?>

bradgrafelman

Don't forget to mark this thread resolved!

Sacky

wait i have one final question, and its a very basic one
This is my new code
<?php
$urlcml = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=CML";
$contentscml = file_get_contents($urlcml);
$cml_pricecml = "#</a></th><td class='last'>([0-9\.])</td>#";
preg_match($cml_pricecml, $contentscml, $CML);
$pricecml = $CML[1];
$sumcml = $pricecml622;
print "CML: $pricecml x 622 = $sumcml";

$urlarg = "http://www.asx.com.au/asx/markets/PriceResults.jsp?method=get&template=F1001&ASXCodes=ARG";
$contentsarg = file_get_contents($urlarg);
$cml_pricearg = "#</a></th><td class='last'>([0-9\.])</td>#";
preg_match($cml_pricearg, $contentsarg, $ARG);
$pricearg = $ARG[1];
$sumarg = $pricearg8658;
print "ARG: $pricearg x 8658 = $sumarg";
?>

Now it displays like this CML: 10.850 x 622 = 6748.7 ARG: 7.010 x 8658 = 60692.58, so how do i make it like this
CML: 10.850 x 622 = 6748.7
ARG: 7.010 x 8658 = 60692.58