Memory Size error with imagecreatefromjpeg()

rosegarden

I have a family website where pics are uploaded by endusers and cataloged in a db table. The index page randomly picks a pic and displays it. I have been setting the width to be a standard 200 in the img tag. I am looking to autothumbnail the pics so that I do not have to wait for the HUGE pics to download when I really only want a small pic there (they can then click on the thumbnail to view the full size pic)

I have found a few scripts that work but I seem to be having a problem with the size of some of the pics.

I am getting the following error:

Fatal error: Allowed memory size of 18388608 bytes exhausted (tried to allocate 10320 bytes) in thumbnail.php on line 18

I believe that it is stemmed from the imagecreatefromjpeg() function. Is there a way around the size limitation?

Listed below is my entire thumbnail script just in case I am looking in the wrong place.

<?php
$pic="pic/Lincoln2.jpg";
function imagecopyresampledselection($filename, $desired_width, $desired_height, $bordersize, $position)
{    

   // Get new dimensions
   list($width, $height) = getimagesize($filename);
   if($desired_width/$desired_height > $width/$height):
       $new_width = $desired_width;
       $new_height = $height * ($desired_width / $width);
   else:
       $new_width = $width * ($desired_height / $height);
       $new_height = $desired_height;
   endif;

   // Resize
   $image_p = imagecreatetruecolor($new_width, $new_height);
   $image_f = imagecreatetruecolor($desired_width, $desired_height);
   $image = imagecreatefromjpeg($filename);
   imagecopyresampled($image_p, $image, 0, 0, 0, 0, $new_width, $new_height, $width, $height);

   // Adjust position
   switch($position)
   {
       case("topleft"):
           $x = $bordersize;
           $y = $bordersize;
           break;

   case("topright"):
       $x = $new_width - $desired_width + $bordersize;
       $y = $bordersize;
       break;

   case("bottomleft"):
       $x = $bordersize;
       $y = $new_height - $desired_height + $bordersize;
       break;

   case("bottomright"):
       $x = $new_width - $desired_width + $bordersize;
       $y = $new_height - $desired_height + $bordersize;
       break;

   case("center"):
       $x = ($new_width - $desired_width) / 2 + $bordersize;
       $y = ($new_height - $desired_height) / 2 + $bordersize;
       break;
   }

   // Resample with 1px border
   imagecopyresampled($image_f, $image_p, $bordersize, $bordersize, $x, $y,    $desired_width    - 2 * $bordersize, 
                                                                               $desired_height    - 2 * $bordersize, 
                                                                               $desired_width    - 2 * $bordersize, 
                                                                               $desired_height    - 2 * $bordersize);

   return $image_f;
}

$image_f = imagecopyresampledselection($pic, 200, 200, 1, "center");
header('Content-type: image/jpeg');
imagejpeg($image_f, null, 100);

?>

Again... Thank you for any help you may provide....

Installer

Try using "imagedestroy()" on "$image", right after the first "imagecopyresampled()", and create "$image_f" after that. It probably wouldn't hurt (and would be good practice) to use it on the other two images, also. And try using the default image quality, or at least a lower one. You're liable to see little difference in the picture, but you'll use less resources.

rosegarden

Is this what you meant by destroying the first image and then creating the first $image_f after that?

Where can I read about changing to the default quality. I am not sure how to do this.

Again, thank you for your help...

<?php
$pic = "pic/Camera Pictures 213.jpg";
function imagecopyresampledselection($filename, $desired_width, $desired_height, $bordersize, $position)
{    

   // Get new dimensions
   list($width, $height) = getimagesize($filename);
   if($desired_width/$desired_height > $width/$height):
       $new_width = $desired_width;
       $new_height = $height * ($desired_width / $width);
   else:
       $new_width = $width * ($desired_height / $height);
       $new_height = $desired_height;
   endif;

   // Resize
   $image_p = imagecreatetruecolor($new_width, $new_height);
   $image = imagecreatefromjpeg($filename);
   imagecopyresampled($image_p, $image, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
   imagedestroy($image);
   $image_f = imagecreatetruecolor($desired_width, $desired_height);
   // Adjust position
   switch($position)
   {
       case("topleft"):
           $x = $bordersize;
           $y = $bordersize;
           break;

   case("topright"):
       $x = $new_width - $desired_width + $bordersize;
       $y = $bordersize;
       break;

   case("bottomleft"):
       $x = $bordersize;
       $y = $new_height - $desired_height + $bordersize;
       break;

   case("bottomright"):
       $x = $new_width - $desired_width + $bordersize;
       $y = $new_height - $desired_height + $bordersize;
       break;

   case("center"):
       $x = ($new_width - $desired_width) / 2 + $bordersize;
       $y = ($new_height - $desired_height) / 2 + $bordersize;
       break;
   }

   // Resample with 1px border
   imagecopyresampled($image_f, $image_p, $bordersize, $bordersize, $x, $y,    $desired_width    - 2 * $bordersize, 
                                                                               $desired_height    - 2 * $bordersize, 
                                                                               $desired_width    - 2 * $bordersize, 
                                                                               $desired_height    - 2 * $bordersize);

   return $image_f;
}

$image_f = imagecopyresampledselection($pic, 200, 200, 1, "center");
header('Content-type: image/jpeg');
imagejpeg($image_f, null, 100);

?>

rosegarden

ah ok...

I found the quality in the imagejpeg() function. 100 is the highest quality.

http://us2.php.net/manual/en/function.imagejpeg.php

(I post this for the benefit of those that come after me)

I have set the quality to 0 but I still do not have a picture from my larger pics. I do from a smaller pic but very pixelated.

Installer

You can just leave off the quality argument and it will go to the default (which the manual says is c. 75). Or you can play around with 95, 90, 85, etc. until you see too much of a drop-off in quality. But 0 is a little too small. 🙂

rosegarden

I am still getting the fatal error even after the imagedestroy() added.

See the last code posted.

How can I do this differently