problem updating database thru form

[Rollo_Tamasi]

I have a script whereby i can edit the content of a database thru clicking on a link which carries a 'ID' over to another page. The code in this post is the code for editing for the content. The script connects sucsessfully to the database and dispalys the current database content within its textboxes, the user can type in their new content over the text and click submit to update the database. However its not working properly. When the user clicks sumit nothing happens and the database does not get updated.

<?

if(isset($_GET['id']))
{
	$query = "SELECT * FROM mynews WHERE id = '{$_GET['id']}'";
if (!isset($_POST["submit"]))
{

$id = $_GET["id"]; .
$sql = "SELECT * FROM mynews WHERE id=$id"; 
$result = mysql_query($sql);
$myrow = mysql_fetch_array($result);


if ($_POST["$submit"])
{
$id = $_POST['id'];
$title = $_POST['title'];
$message = $_POST['message'];
$user = $_POST['user'];
$email = $_POST['email'];

$sql = "UPDATE mynews SET id='$id', title='$title', message='$message', user='$user', email='$email' WHERE id=$id"; 

$result = mysql_query($sql); //run this query
echo "Information updated. <a href=test2.php>Return</a>";
}
?>
<form action="editcontent.php" method="post">
<INPUT TYPE="TEXT" NAME="title" VALUE="<?php echo $myrow["title"] ?>" SIZE=30>
//more forms down here....
<input type="submit" name="submit" value="submit">
</form>
<?

}
}

?>

Any ideas where i might have gone wrong?

[FatalError]

if ($_POST["$submit"])

I don't see a variable "$submit" anywhere. 😉

[Rollo_Tamasi]

mmm, so what code should i have in there?
i'm a bit of a novice

[tbobker]

it should just be $_POST['submit'] also where have you got (where.....set id='id') in your sql, put the table name or just the variable $id.

[Houdini]

Rollo Tamasi where is the $GET['id'] coming from? You are referring to 'id' as both $GET and $_POST, that alone is confusing.

FatalError the submit is the name of the submit field so if the submit is clicked the value of $_POST['submit'] is set to a value of submit.

Further down in the script

$id = $_POST['id'];
$title = $_POST['title'];
$message = $_POST['message'];
$user = $_POST['user'];
$email = $_POST['email'];

but earlier you have the $_GET['id'] in a conditional to perform a query. Do you have a form field with the name 'id' somewhere 'cause you skipped over the code and it just might have some clue as to where all these values are coming from, right now though it is difficult to tell.

[Rollo_Tamasi]

the $_GET['id'] is brought into the current page from another page and a query is run on the variable id, there shouldnt be a post there actually.

[FatalError]

Houdini wrote:

FatalError the submit is the name of the submit field so if the submit is clicked the value of $POST['submit'] is set to a value of submit.

I am aware of that (can't believe I understood it... @@), but he put a variable in there instead of just 'submit'.

@Rollo Tamasi: You put $POST['id'] in your script instead of $GET['id']. Basically, $id was overwritten with the POST value...but it looks like you don't even have the id anywhere in the POST...so there's your bug. 🙂

[Rollo_Tamasi]

that hasn't resolved the problem :bemused:
i have removed the $POST['id'] so i now have

if ($_POST["$submit"])
{

$title = $_POST['title'];
$message = $_POST['message'];
$user = $_POST['user'];
$email = $_POST['email'];

$sql = "UPDATE mynews SET title='$title', message='$message', user='$user', email='$email' WHERE id=$id";

[benbox]

You forgot the $_POST syntax in the IF

if ($_POST['submit'])
{ 

[Rollo_Tamasi]

that didn't make any difference either

[tbobker]

$sql = "UPDATE mynews SET ('title','message','user','email') VALUES('$title','$message','$user','$email') WHERE id='$id'";

also try the sql values without the ''. If that doesnt work i would suggest just making sure that at least one field will update, if that doesnt work check your database to see that your are updating the right amount of fields.

[Rollo_Tamasi]

so far so bad i'm afraid. Still not updating the db :bemused:

This is the revised code that i'm using as of now

<?php include("dbconnect.php") ?>
<?

if(isset($_GET['id']))
{
	$query = "SELECT * FROM mynews WHERE id = '{$_GET['id']}'";
if (!isset($_POST["submit"])) //if submit has not yet been pressed, do this
{

$id = $_GET['id']; //get the id of the news article being edited. This is provided in the link to edit it.
$sql = "SELECT * FROM mynews WHERE id='$id'"; //select all columns from mynews with this id
$result = mysql_query($sql);
$myrow = mysql_fetch_array($result);

if ($_POST['submit'])
{

$title = $_POST['title'];
$message = $_POST['message'];
$user = $_POST['user'];


$sql =  $sql = "UPDATE mynews SET ('title','message','user','email') VALUES('$title','$message','$user','$email') WHERE id='$id'"; 

$result = mysql_query($sql); //run this query
echo "Information updated. <a href=test2.php>Return</a>";
} 
?>

<form action="editcontent.php" method="post">
<table width="400" border="0">
  <tr>
    <td width="109">News Title </td>
    <td width="281"><INPUT TYPE="TEXT" NAME="title" VALUE="<?php echo $myrow["title"] ?>" SIZE=30></td>
  </tr>
</table>
</form>


<?

}
}

?>

[benbox]

Can you paste your table here? maybe an SQL dump with the create table code for it, so it's easier to see if there's a problem between that and your code

[Rollo_Tamasi]

benbox wrote:

Can you paste your table here? maybe an SQL dump with the create table code for it, so it's easier to see if there's a problem between that and your code

i have actually got it working. But its causing some heartache! I'd better start off a new thread since i'm using different code and i have a different problem