Form Help

avis

I have a form I use on a private clan site for a database. It allows me to insert mulitple rows into my database. It works fine on my host but when I put it on my local machine I get errors with the php code. Can someone please help me with this. Here is the code:

<?
$username="root";
$database="coords";
mysql_connect("localhost",$username);
@mysql_select_db($database) or die( "Unable to select database");
$mydata = $_POST['textareaname'];

$targettemp = preg_split('/\n/', $mydata); 
foreach($targettemp as $d ) {
	$d1 = preg_split('/ /', $d);
	$coords = $d1[0];
	$name = $d1[1];
	$owner = $d1[2];
	$defense = $d1[3];
	$comments = $d1[4];
	$query = "INSERT INTO planets VALUES ('','$coords','$name','$owner','$defense','$comments')";
	mysql_query($query);
}
	mysql_close();

?>

bradgrafelman

When posting code, please post only the part that is necessary to fix your error. If we need more, we'll definitely ask for it - pasting too much code just clutters up your post and turns away people that might want to help.
In addition, when posting PHP code you should always use the board's bbcode tag [ PHP] as it will highlight your code and make it much easier to read.
When you are getting errors... paste them! PHP's errors can oftentimes be very descriptive and lead you to the problem. Also, tell us which line is the line number referenced in the error message.
In reference to:
```
$targettemp = preg_split('/\n/', $mydata);
// and also...
$d1 = preg_split('/ /', $d);
```
you should try using [man]explode/man instead of wasting resources on a REGEXP function when you don't need (or even use) REGEXP.
In reference to:
```
mysql_connect("localhost",$username);
```
Do you not have a password on the user 'root' on your server? If you indeed do not have a password, then this will work fine, though I should think everyone password-protects the 'root' user...

avis

Sorry about not using the php bbcode. Please keep in mind I am very new to this 🙂 I don't know how to use the explode code you mentioned. IF you could clarify it some I would appreciate that alot. With the code I posted I get the following errors.

Notice: Undefined index: textareaname in c:\inetpub\wwwroot\swarm\insert2.php on line 11

Notice: Undefined offset: 1 in c:\inetpub\wwwroot\swarm\insert2.php on line 17

Notice: Undefined offset: 2 in c:\inetpub\wwwroot\swarm\insert2.php on line 18

Notice: Undefined offset: 3 in c:\inetpub\wwwroot\swarm\insert2.php on line 19

Notice: Undefined offset: 4 in c:\inetpub\wwwroot\swarm\insert2.php on line 20

Also this code is running on my home box in a windows environment unlike my host that runs linux. So I don't use a root password on my home machine; however I do on my hosting site 😉

Houdini

What is the name of your textarea in your form, is it 'textareaname'?

$_POST['textareaname'];
$targettemp = preg_split('/\n/', $mydata);

It might help if you pasted the code you have for your form that is being passed as a nonexistant (possibly misspelled) key with no value.

avis

Sorry about that. Here is the form:

real simple form huh 😉

Houdini

I noticed there is no action to that form so it should submit to itself what is the name of your file in the first post that you are showing? It would help to submit that post to the page that is supposed toprocess that code.

avis

Here is what I had originally posted before being asked not to post so much lol.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html><head><title>The Swarm</title>
</head>
<body bgcolor="#000000" text="#FFCC66">
<center><h1>The Swarm Coord DB</h1></center>
<?
$username="root";
$database="coords";
mysql_connect("localhost",$username);
@mysql_select_db($database) or die( "Unable to select database");
$mydata = $_POST['textareaname'];

$targettemp = preg_split('/\n/', $mydata);
foreach($targettemp as $d ) {
	$d1 = preg_split('/ /', $d);
	$coords = $d1[0];
	$name = $d1[1];
	$owner = $d1[2];
	$defense = $d1[3];
	$comments = $d1[4];
	$query = "INSERT INTO planets VALUES ('','$coords','$name','$owner','$defense','$comments')";
	mysql_query($query);
}
	mysql_close();

?>
<form  method="POST">
<textarea name="textareaname" rows="2" cols="20" accesskey="" tabindex="" ></textarea>
<br><input type="Submit">
</form>
<hr>
<iframe Name="results" SRC="db_search.php" backgroundcolor="TRANSPARENT" WIDTH="100%" HEIGHT="80%" FRAMEBORDER="0" MARGINHEIGHT="0" MARGINWIDTH="0"> If you can read this, then Iframe is not supported. Get mozilla (freeware). </iframe> 
</body>
</html>

Houdini

Like brad stated you would probably be better off using explode() instead of preg_split(), and it appears that by using the value of content of a textarea that you are depending on others to properly enter in to a textare with no label and a Submit Query button the values , in proper order what is required by your database. It look like 5 fields plus one that you are inserting a blank value into for some reason or the other.

Your form should look more like this to get positive results.

<form  method="POST">
Co-ordinates: <input type = "text" name="coords" />
Name: <input type = "text" name="name" />
Owner: <input type = "text" name="owner" />
Defense<input type = "text" name="defense" />
Comments:<br />
<textarea  name="comments" rows="2" cols="20" ></textarea>
<br><input type="Submit">
</form>

then you can change

$coords = $d1[0];
$name = $d1[1];
$owner = $d1[2];
$defense = $d1[3];
$comments = $d1[4];

$coords = $_POST['coords'];
$name = $_POST['name'];
$owner = $_POST['owner'];
$defense = $_POST['defense'];
$comments = $_POST['comments'];

Then try that and see what happens.

avis

The form needs be a textarea as the users post multiple rows of information. Then php should split the information at the spaces and insert it into different fields for that row and then go to the next row. http://www.theswarmclan.com/planet_test_db/insert2.php That is what it outputs online. It works great online, but I need to add more to it so I have it on my windows machine to test before I upload it. My host runs linux with apache server where I use windows with IIS. Maybe the better question would be is whether I need to use different syntax with different machine and what would that syntax be? I hope this makes sense.

avis

Also could you please explain this explode that was mention as it seems it might be the answer I seek 🙂

Houdini

From the PHP Manual explode()

explode ( string separator, string string [, int limit] )

Returns an array of strings, each of which is a substring of string formed by splitting it on boundaries formed by the string separator. If limit is set, the returned array will contain a maximum of limit elements with the last element containing the rest of string.

in you case I am not sure what you would use as a separator may a newline \n or possible both areturn and newline \r\n

Tezread

error_reporting(E_ALL ^ E_NOTICE);

quite handy for error reporting

hth