[RESOLVED] Drawing Results from Query Problem

The_MA

Hey - I can't seem to get the results of my cross table query to appear in a table.

I have a dropdown box where I select one of the variables for the query (the device) and then when I click submit it takes me to the table where all the results should be displayed - but I never get any results... just the header of the table.. Can you see what is wrong here? :chomp: Please help - an important project relies on this. thanks in advance.

<?php

$self = $_SERVER['PHP_SELF'];

// DOES THIS $device conflict with the one later on?

$device = $_POST['device'];

if( (!$device) )
{

// FORM HEADER  $form ="<table ..ETC

$conn=@mysql_connect( "localhost", "alexm", "rugby" )
		 	or die( "Error: MySQL Connection Failed" );

$db = @mysql_select_db( "rugby_project", $conn) or die( "Error: Database Connection Failed" );

// I.E. THIS $device BELOW

$device=$row["device"]; 
$query="SELECT DISTINCT device from devices";
$result=mysql_query($query);

  $form.="<form action=\"$self\" method=\"post\" name=\"cd\" onsubmit=\"return validate()\"><tr>";
  $form.="<td align=\"center\"><select name=\"device\">";
  $form.="<option value=\"\" selected>- Select Device -</option>";

while($row=mysql_fetch_array($result)) {

  $form.="<option value=\"$row[device]\">$row[device]"; 
}
  $form.="</td></tr></select><tr><td><center><input type=\"submit\" value=\"Run Query\">";
  $form.="</tr></table></form>";
  echo($form);

}
else
{

// Two possible queries? Neither produce results yet... there ARE records to produce

// $sql = "select commandID from commands where x10_channel = (select x10_channel from devices where device = '$device')";

$sql = "select c.commandID from commands c inner join devices d on c.x10_channel = d.x10_channel where device = '$device'";

$rs = @mysql_query( $sql,$conn);
$rows = mysql_num_rows($rs);


// TABLE HEADER  echo( "<table  ..ETC

if(mysql_num_rows($rs))
{

while( $row = mysql_fetch_array( $rs ) ){  

$commandID=$row["commandID"];  

   echo '<tr><td><font size="2" face="Verdana"> . $commandID . </td></tr>'; 
}

}
}

?>

bradgrafelman

Well, first you should debug your query. You have the error suppressor (@) on the mysql_query() call. Since you're having problems... you don't want to suppress ANY errors, so remove that.

In fact, to make sure we're getting the whole picture, add the ' or die(mysql_error());' bit on to the end of your mysql_query() call.

Also... that's an odd way to retrieve data from a query... why not simply do:

$rs = mysql_query( $sql,$conn) or die(mysql_error()); 

// TABLE HEADER  echo( "<table  ..ETC 

while( $row = mysql_fetch_array( $rs ) ) {   

     $commandID=$row["commandID"];   

     echo '<tr><td><font size="2" face="Verdana"> . $commandID . </td></tr>'; 
}

The_MA

Thanks very much - I found some errors thanks to your suggestion - that really helped - ty - it works well now =D