mysql_fetch_assoc error

crazylegseddie

Hi everyone

Im trying to edit information from my database but keep recieving this error when attemptong to retrieve the data:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in

Part of my code is the following:

<?php
require '../include/config.php';
foreach($_GET as $id=> $value)
$sql = 'Select * FROM client WHERE Client_ID=' . $id or exit(mysql_error());
$result = mysql_query($sql);
while
($row = mysql_fetch_assoc($result))
{
echo 'First Name ';
echo "<input name = \"First_Name\" type=\"text\" value=\"".$row['First_Name']."\">";

Im using mysql 4.1 and PHP 5.0 and have used the mysql_fetch_assoc query before and its worked fine so do not understnad why I am receiving this error. Any assistance will be appreciated??

HP400

You have an error in your sytanx here...
$sql = 'Select * FROM client WHERE Client_ID=' . $id or exit(mysql_error());

This will come out to be $sql = true;

Here is what your are looking for...

<?php
require '../include/config.php';
foreach($_GET as $id=> $value)
$sql = 'Select * FROM client WHERE Client_ID=' . $id;
if (!$result = mysql_query($sql))
exit(mysql_error());
while
($row = mysql_fetch_assoc($result))
{
echo 'First Name ';
echo "<input name = \"First_Name\" type=\"text\" value=\"".$row['First_Name']."\">";

crazylegseddie

Hi thanx a lot that worked. Im now having another problem when retrieving the client id from my list box. I use this to list my clients and push them to edit.

<form action="edit-client.inc.php" method="get">
<?php
require '../include/config.php';
$query = 'SELECT Client_ID, Last_Name, First_Name FROM client group by Last_Name asc';
$result = @($query) or die('<p>Sorry, no data to edit...</p>');
?>
</p>
<p>

<select name="Client_ID" id="selectClient">
<?php
while($row=mysql_fetch_assoc($result)) printf("\t<option value=\"%d\">%s, %s</option>\n",$row['Client_ID'],$row['Last_Name'],$row['First_Name']);
?>
</select>
</p>

<input type="submit" value="Submit record for editing" />

</form>[/COLOR]

When sending this to be edited I can identify the client_id has been passed as it shows it in the browser but all my clients are listed at once to be edited when i just need the client linked to that specific ID. I assume its a problem with edit script as shown above and is not correctly recognising the id. Any further help will be appreciated. Thank You.

crazylegseddie

problem solved using:

$sql = 'Select * FROM client WHERE Client_ID=' . $_GET['Client_ID'];

HP400

I would guard against SQL injection.

What if $_GET['Client_ID]' = ';DELETE FROM client;

Bye bye table. Now it would take someone skills to do that but this could be fixed with a simple

if (!is_numeric($_GET['Client_ID']))
exit('Get that crap outta here');

crazylegseddie

ah ok thx. Having one more problem with my edit which I hope someone can help me with. Im having trouble passing the client id on to update the record. on the edit page i have

echo "<input name = \"Client_ID\" type=\"hidden\" value=\"".$id."\">";

to pass the id to the process page

and on the process page i have:

<?php
require '../include/config.php';
id=$POST['Client_ID'];
$firstname=$POST['First_Name'];
$lastname=$_POST['Last_Name'];

if (!get_magic_quotes_gpc())
{
$firstname=addslashes($firstname);
$lastname=addslashes($lastname);
}
$sql = "update client SET
First_Name='$firstname',
Last_Name='$lastname'
where Client_ID='$id'";
$result = @($sql);
if ($result)
echo 'Record Edited Successfully';
else
echo 'Record Not Edited';
?>
If i manually change the ID the query works but this script is unable to recognize the clients ID automatically! Can someone inform me of what I am doing wrong.

HP400

First thing I see is the

id=$_POST['Client_ID'];

needs to be

$id=$_POST['Client_ID'];

(might be a typo)

Other then that verify that the hidden field populates. Also since you are assigning your global post variables to php variables you should check out the import_request_variables function.

bradgrafelman

I've never used [man]import_request_variables[/man] mainly because without the proper use of it, it's the same as using register_globals; a big no-no.

As HP said, you probably made a typo and missed the $, though you should have gotten a PHP error.

Also, when posting PHP code... use the board's [ PHP] tags, it makes it much easier to read.

HP400

Its not that hard really to use import_request_variables correctly.

As long as he does import_request_variables('p') its fine. I wouldn't use the function for more than 1 superglobal type because that is the case where you can get into trouble.