[RESOLVED] Holding Menu Value

s2e

I have used code like this one so many times with good results but cannot see why this isn't workin. Just want the form menu to hold the selected value after submission. Any ideas why this will not hold the value?

<?php
function build_customer1() { 
	require_once ('./mysql_connect.php'); // Connect to the database
	$query = "SELECT customer_id, CONCAT(last_name, ', ', first_name) AS name FROM customer_info ORDER BY last_name ASC"; 
	$result = @mysql_query($query); 

while($row = @mysql_fetch_array($result, MYSQL_NUM)) { 
	$customer_id = $row[0];
	$name = $row[1];

	echo "<option value=$customer_id"; 
	if(isset($_POST['customer']) && $_POST['customer'] == $customer_id) { 
		echo 'selected';
	} 
	echo ">$name</option>"; 
} 
}
?>
<select name="customer" class="frmtxt1" id="customer">
<option value="">-</option>
<?php echo build_customer1()?></select>

bradgrafelman

First of all, you don't want to echo the function, as it already prints the data. Simply call the function in the form. Also, one thing I notice is that you don't have a space after the value, so if it was indeed selected, it would print "value=5selected" etc. Add a space before the SELECTED property in your if statement.

If those changes don't fix it... can you tell us exactly what it's doing right now? What does it print instead? Can you give us a link?

s2e

Thanks bradgrafelman. Just had to change
<option value=$customer_id
to
<option value=<\"$customer_id\"

It's always the simple things. Flippin Idiot....

Here it is for anyone who wants it.

function build_customer1() { 
	require_once ('./mysql_connect.php'); // Connect to the database
	$query = "SELECT customer_id, CONCAT(last_name, ', ', first_name) AS name FROM customer_info ORDER BY last_name ASC"; 
	$result = @mysql_query($query); 

while($row = @mysql_fetch_array($result, MYSQL_NUM)) { 
	$customer_id = $row[0];
	$name = $row[1];

	echo "<option value=\"$customer_id\""; 
	if(isset($_POST['customer']) && $_POST['customer'] == $customer_id) { 
		echo 'selected';
	} 
	echo ">$name</option>"; 
} 
}