Radio btn how to get the radio group

[flashmxfreak]

In this page I test this code:

<!-- create table header -->
<table width=75% border='1' align="center">
  <?php
 $dbc = mysql_connect("localhost","aaa","xxx");
 mysql_select_db("aaa") or die(mysql_error("Couldn't select to DB"));
 $sql = "select isAproved,gflash from guestbook where isAproved like 'NO'";
 $r = mysql_query($sql);
 //define var for inecrement of radio button group
 $a = 1;
 if(!mysql_num_rows($r))
 {
 echo "No records found";
 // empty table
 }
 else
 {
 // loop all not aproved post 
 while($record = mysql_fetch_row($r))
	{
 echo "<tr><td><label><input type= 'radio' name = 'radio_group".$a++."' checked='checked' value = '$record[0]' > $record[0] ></label><br /><label><input type= 'radio' name = 'radio_group".$a++."' value = 'YES'>Aproved</label></td> <td>$record[1]</td></tr> <tr><td>&nbsp;</td></tr>";
//  echo "<tr><td><label><input type= 'radio' value = '$record[0]'>$record[0]</label></td> <td>$record[1]</td></tr> <tr><td>&nbsp;</td></tr>";
 	echo "radio_group".$a++." "." BUTTON";
    echo "$a++ = ".$a++;
	}
 }
?>
</table>

I need to have possibilty to set group of 2 radio btns for radio NO and radio Aproved. Now does not works.
Later I need to send values of selected radios to my dtb.
I spend 2 hours with try how to make it but without success :queasy: .
Please help how to do it.

[devinemke]

it looks like you are overcomplicating this. i assume that "isAproved" is some sort of boolean field in your table that is set to either "yes" or "no". your code suggests that you are pulling out only the "unapproved" rows and displaying a form presumably for the purpose of updating certain rows to "approved". if so then i would suggest not using radio buttons at all but checkboxes instead. the initial state of each checkbox would be unchecked and then in the form processing code simply loop thru the returned checked rows and form an UPDATE query to flip them to "approved". you can even do this all in a single query using the IN() syntax.

i am i missing something more complex than this?

[Houdini]

I am not sure what you are wanting to print but you can fix the output the way you want , this code will now work with the changes made to it.

<!-- create table header -->
<table width=75% border='1' align="center">
 <?php
//I need to have possibilty to set group of 2 radio btns for radio NO and radio Aproved. Now does not works.
//Later I need to send values of selected radios to my dtb.
//I spend 2 hours with try how to make it but without success .
//Please help how to do it.
 $dbc = mysql_connect("localhost","root","");
 mysql_select_db("angel_test") or die("Couldn't select to DB".mysql_error());
 $sql = "SELECT isAproved,gflash from isAproved WHERE isAproved like 'NO'";
 $result = mysql_query($sql);
 $rows= mysql_num_rows($result);
 //echo "There are $rows rows of data";
 //define var for inecrement of radio button group
 $a = 1;
 if($rows==0)
 {
 echo "No records found";
 // empty table
 }
 else
 {
 // loop all not aproved post 
 while($record = mysql_fetch_row($result))
	{
 echo "<tr><td><label><input type= 'radio' name = 'radio_group".$a++."' checked='checked' value = '$record[0]' > $record[0] ></label><br /><label><input type= 'radio' name = 'radio_group".$a++."' value = 'YES'>Aproved</label></td> <td>$record[1]</td></tr> <tr><td>&nbsp;</td></tr>";
//  echo "<tr><td><label><input type= 'radio' value = '$record[0]'>$record[0]</label></td> <td>$record[1]</td></tr> <tr><td>&nbsp;</td></tr>";
 	echo "radio_group".$a++." "." BUTTON";
    echo "\$a++ = ".$a++;
	}
 }
?>
</table>

[flashmxfreak]

Its really good complex idea, thanks 🙂
I changed the code and now looks following.
The code is:

<!-- create table header -->
<table width=75% border='1' align="center">
  <?php
 $dbc = mysql_connect("localhost","4645","asdf");
 mysql_select_db("asdf") or die(mysql_error("Couldn't select to DB"));
 $sql = "select isAproved,gflash from guestbook where isAproved like 0";
 $r = mysql_query($sql);
 //define var for inecrement of radio button group
 $a = 1;
 if(!mysql_num_rows($r))
 {
 echo "No records found";
 // empty table
 }
 else
 {
 // loop all not aproved post 
 while($record = mysql_fetch_row($r))
	{
	// bad idea:
	//echo "<tr><td><label><input type= 'radio' name = 'radio_group".$a++."' checked='checked' value = '$record[0]' > $record[0] ></label><br /><label><input type= 'radio' name = 'radio_group".$a++."' value = 'YES'>Aproved</label></td> <td>$record[1]</td></tr> <tr><td>&nbsp;</td></tr>";

// good idea display checkbox with 0 value of isAproved column:
echo "<tr><td><label><input type= 'checkbox' name = 'checkbox' value = '$record[0]' /> Approve</label></td> <td>$record[1]</td></tr>";	    

	}
 }
?>
</table>

Now I stay in front of problem, how to update the checked check box to the value TRUE or 1 in the records of column "isAproved".
You written about fn IN() and UPDATE statement. Can you send me example how can I update my records in this way?
Thank you very much.

devinemke wrote:

it looks like you are overcomplicating this. i assume that "isAproved" is some sort of boolean field in your table that is set to either "yes" or "no". your code suggests that you are pulling out only the "unapproved" rows and displaying a form presumably for the purpose of updating certain rows to "approved". if so then i would suggest not using radio buttons at all but checkboxes instead. the initial state of each checkbox would be unchecked and then in the form processing code simply loop thru the returned checked rows and form an UPDATE query to flip them to "approved". you can even do this all in a single query using the IN() syntax.

i am i missing something more complex than this?

[devinemke]

flashmxfreak wrote:

You written about fn IN() and UPDATE statement. Can you send me example how can I update my records in this way?

it's not clear from your code what is the primary key field from your table. here is a simple example that assumes that the primary key is called "id" and that "isApproved" is an integer field that is either 1 or 0 (true or false):

<?php
// connect to db here

if (!isset($_POST['submit']))
{
	$result = mysql_query('SELECT id, isAproved FROM guestbook WHERE isAproved = 0') or exit(mysql_error());
	echo '<form action="" method="POST">';
	while ($row = mysql_fetch_assoc($result))
	{
		echo '<input type="checkbox" name="approves[]" value="' . $row['id'] . '"> approve row #' . $row['id'] . '<br>';
	}
	echo '
	<input type="submit" name="submit" value="submit">
	</form>
	';
}
else
{
	if (isset($_POST['approves']))
	{
		$sql = 'UPDATE guestbook SET isAproved = 1 WHERE id IN(' . implode(',', $_POST['approves']) . ')';

	// this single query will UPDATE all rows that were checked
	echo $sql;
}
else
{
	echo 'you did not check any rows';
} 
}
?>

[flashmxfreak]

First, thank you.
I don´t know but the UPDATE statement don´t changes the value of my 'gid' record.
After checking it appears the echo of sql but if i look in the table, the value is still unchanged
Here is the table structure:

CREATE TABLE `guestbook` (
  `gid` int(11) NOT NULL auto_increment,
  `gdate` datetime default NULL,
  `gname` varchar(50) default NULL,
  `gmail` varchar(50) default NULL,
  `gfrom` varchar(50) default NULL,
  `gmsg` text,
  `gflash` text,
  `isAproved` tinyint(1) default '0',
  PRIMARY KEY  (`gid`),
  KEY `gdate` (`gdate`,`gname`,`gmail`,`gfrom`),
  FULLTEXT KEY `gmsg` (`gmsg`,`gflash`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='GuestBook penzion U Hrádku' AUTO_INCREMENT=28 ;

And your code with my small changes (rename of id ->gid + value of $row['gmsg'] ):

if (!isset($_POST['submit'])) 
{ 
    $result = mysql_query('SELECT gid, gmsg, isAproved FROM guestbook WHERE isAproved = 0') or exit(mysql_error()); 
    echo '<form action="" method="POST">'; 
    while ($row = mysql_fetch_assoc($result)) 
    { 
        echo '<input type="checkbox" name="appoves[]" value="' . $row['gid'] . '"> approve row #' . $row['gid'].' '.$row['gmsg'].'<br>'; 
    } 
    echo ' 
    <input type="submit" name="submit" value="submit"> 
    </form> 
    '; 
} 
else 
{ 
    if (isset($_POST['appoves'])) 
    { 
        $sql = 'UPDATE guestbook SET isAproved = 1 WHERE gid IN(' . implode(',', $_POST['appoves']) . ')'; 

    // this single query will UPDATE all rows that were checked 
    echo $sql; 
} 
else 
{ 
    echo 'you did not check any rows'; 
} 
} 

[devinemke]

my example posted above does not actually run the UPDATE query, it just outputs it for you to see the syntax. you have to run the query using [man]mysql_query[/man].

[flashmxfreak]

Thanks a lot devinemke, I see - OK.

mysql_query($sql);

The last think what I need to end my guestbook is in guestbook.php file, which store the entered data from flash guestbook to guestbook table.
Now I need to return to flash only the values with 1 - TRUE of column 'iAproved'.
Here is the code from guestbook.php which displays all data:

$action = $_REQUEST['action'];

 switch($action):
 case "view":
  $str = "";
  $query = "SELECT * FROM guestbook ORDER BY gid DESC";

// select aproved comments  
//$query = "SELECT * FROM guestbook WHERE isApproved = 'Yes' ORDER BY gid DESC";

  $rs = mysql_query($query);
  if(!$rs){
  	$count = 0;
  } else {
  	$count = mysql_num_rows($rs);
  }

  if ($count>0) {
	 while ($var=mysql_fetch_assoc($rs)){
	   $str .= $var["gflash"] . "<br/>";
	 }
	$str .= "<br/><br/> ::::::::::::: End of Entries ::::::::::::::: ";
  } else {
	$str=":: Nothing to Display ::";
  }

  //---------------------------------- Send the results to flash -----------------------------------------\\
  echo "&strflash=$str";

  break;
 case "add":
  //-------------------------- Grab variables from the POST ---------------------------\\
  foreach($_POST as $key => $value){
  	$$key = $value;
  }
  $gdate = date("Y-m-d H:i:s");
  $err = "Problem posting";

  //-------------------------- Prepare HTML to returm to flash ---------------------------\\
  $gflash = "<b>Name: </b>$gname<br/><b>From: </b>$gfrom<br/><b>Message: </b>$gmsg<br/><b>Posted: </b><i>$gdate</i><br/>";

  //-------------------------- Insert info to database ---------------------------\\
//  $query = "INSERT INTO guestbook(gdate,gname,gmail,gfrom,gmsg,gflash,isAproved) VALUES ('$gdate','$gname','$gmail','$gfrom','$gmsg','$gflash','NO')";
    $query = "INSERT INTO guestbook(gdate,gname,gmail,gfrom,gmsg,gflash) VALUES ('$gdate','$gname','$gmail','$gfrom','$gmsg','$gflash')";
  $rs = mysql_query($query);

  if($rs){
  	echo "&posted=true";
  	echo "&gflash=$gflash";
  } else {
  	echo "&error=$err";
	echo "&gflash=$gflash";
  }
  break;
 endswitch;

I need to prepare $gflash only with record with value TRUE of 'isApoved' column. Now displays all.

Thank you for your time.

devinemke wrote:

my example posted above does not actually run the UPDATE query, it just outputs it for you to see the syntax. you have to run the query using [man]mysql_query[/man].

[devinemke]

you want only the "approved" rows? then change your query to:

SELECT * FROM guestbook WHERE isAproved = 1 ORDER BY gid DESC

[flashmxfreak]

I try to understand this piece of code:
$sql = 'UPDATE guestbook SET isAproved = 1 WHERE gid IN(' . implode(',', $_POST['appoves']) . ')';

I read about implode but what means the SQL statement IN ?