[RESOLVED] php masters please help

novice_php

this query is giving me aproblem it keeps saying
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE username = 'admin'' at line 1. need some help. thaks

if (isset($_POST['submit']) && $_POST['submit'] == "Update") {
  $query_update = "UPDATE user SET " .
"first_name = ' " . $_POST['first_name'] . " ', " .
"last_name = ' " . $_POST['last_name'] . " ', " .
"address1 = ' " . $_POST['address1'] . " ', " .
"address2 = ' " . $_POST['address2'] . " ', " .
"city = '" . $_POST['city'] . "', " .
"postcode = ' " . $_POST['postcode'] . " ', " .
" WHERE username = ' " . $_SESSION['username'] ." ' ";
  $result_update = mysql_query($query_update) 
    or die(mysql_error());

echo "query1: " . $query;

bpat1434

Well, right off the bat you don't need to concatenate the query.... you can put linebreaks in the query like so:

$query_update = "UPDATE user SET 
first_name = '" . $_POST['first_name'] . "', 
last_name = '" . $_POST['last_name'] . "', 
address1 = '" . $_POST['address1'] . "', 
address2 = '" . $_POST['address2'] . "', 
city = '" . $_POST['city'] . "', 
postcode = '" . $_POST['postcode'] . "', 
WHERE username = '" . $_SESSION['username'] ."'";

Second off... a stray comma is after the postcode clause. So if you remove it to have it look like:

$query_update = "UPDATE user SET 
first_name = '" . $_POST['first_name'] . "', 
last_name = '" . $_POST['last_name'] . "', 
address1 = '" . $_POST['address1'] . "', 
address2 = '" . $_POST['address2'] . "', 
city = '" . $_POST['city'] . "', 
postcode = '" . $_POST['postcode'] . "' 
WHERE username = '" . $_SESSION['username'] ."'";

That should solve your issues.

novice_php

cheers mate,it wrkd a charm, and i learnt something

bpat1434

Glad to hear it 🙂