Large file

JohnF

I'm new to the forum and new to PHP.

I have a form that I have a problem with that I would like to submit to the forum but there is 500 lines of code.

I believe that I should attach this rather than insert it in the post. Would you please let me know how I should format this and go about it?

timus

JohnF wrote:
I'm new to the forum and new to PHP.

I have a form that I have a problem with that I would like to submit to the forum but there is 500 lines of code.

I believe that I should attach this rather than insert it in the post. Would you please let me know how I should format this and go about it?

Hi John

There should be a "Manage file" button you can use to upload your form if thats what you want to do.

Whats the problem with the form? why is it so large, is it due to the amount of information you are collecting? If you can provide a few more details or identify the code snippet thats causing the problem, someone here will help I'm sure.

Tim

JohnF

This is a booking form - attached.

The problem is that when the form sends and the data arrives by email, only the compulsory fields have any data in them, even though data has been entered into the non-compulsory fields.

robin_percy

Looks like you're depeding on register_globals functionalit. Since you don't explicitly assign the optional values to the variables before you add them to the mail message. Since enabling register_globals isn't recommended, I would just add the explicit assignments.

JohnF

Would you be able to give me an example of what you mean Robin?

robin_percy

Sure,

Right now, you do light validation and filtering on all compulsary fields. For example, you have:

 $camp_code = trim($_POST['camp_code']);

In the process of trimming the posted value, you are assigning it to $camp_code.
However, your optional fields don't get assigned anywhere (that I can see). At the very least you should have a line like:

$fax_number=$_POST['fax_number'];

Before $fax_number is used in the email text.

As I said, this would be the bare minimum for functionality. Leaving values unfiltered, especially when they'll be included in an email, is asking for trouble. But that's a separate issue .

JohnF

Thanks Robin. That has got the form functioning.

Thanks also for the PHP Security Guide link. I'm starting to work my way through that now.