about rtrim ,bug?

[arcow]

function trimSuffix($str, $suffix)
{
$suffixLen = strlen($suffix);
$str1 = substr($str, -$suffixLen);
if(0 == strcasecmp($str1, $suffix))
{
$retStr = @eregi_replace("$suffix$", "", $str);
}
else
{
$retStr = $str;
}
return $retStr;
}

$str="abcdefgaip.zip"
trimSuffix($str,".zip"); //result is abcdefgaip
rtrim($str,".zip"); //result is abcdefga (and this is not i want to see)

so i wrote a function trimSuffix,but the function use the eregi_replace,this maybe low efficient,
and do you have any better idea to realize the function like "trimSuffix"?

[laserlight]

Use [man]basename/man with the suffix argument, and next time post in Newbies or some other coding related forum when you want to ask help on your PHP scripts.

[arcow]

yes basename() can realize it,
but if $str="/test/123/aaaaa.zip" then basename($str,".zip") is aaaaa
and rimSuffix($str,".zip"); //result is /test/123/aaaaa i need this kind of result

any good idea?

[laserlight]

// one way
$result = implode('/', pathinfo($path, PATHINFO_DIRNAME | PATHINFO_BASENAME));

// another way
$parts = explode('.', $path);
array_pop($parts);
$result = implode('.', $parts);

[bubblenut]

WOOT! Who fancies playing "How many different ways can I solve this"?
(I know that soudns sarcastic but it's really not, I love trying to figure out different sollutions to a single problem)

substr:

$pos = strrpos($path, '.');
if($pos !== false) {
  $result = substr($path, 0, $pos);
}

preg_match:

if(preg_match('/^(.*)\..*?$/', $path, $matches)) {
  $result = $matches[1];
}

preg_replace:

$result = preg_replace('/\..*?$/', '', $path);

One thing I've noticed with my (and laserlight's second) sollutions are that if there is no dot in the filename but there is a dot earlier in the path, then the path will still be chopped, so...

substr:

$pos1 = strrpos($path, '.');
$pos2 = strrpos($path, DIRECTORY_SEPARATOR);

if($pos1 !== false && ($pos2 === false || $pos2 < $pos1)) {
    $result = substr($path, 0, $pos1);
}

preg_match:

if(preg_match('#^(.*)\.[^'.DIRECTORY_SEPERATOR.']*$#', $path, $matches)) {
  $result = $mathes[1];
}

preg_replace:

$result = preg_replace('#\.[^'.DIRECTORY_SEPERATOR.']*$#', '', $path);

So far, I think I like laserlight's first sollution best.

[Weedpacket]

Or

if(substr($path, -strlen($suffix))==$suffix)
    $result = substr($path, 0, -strlen($suffix));

if I understand the problem right.

And moving this to a more appropriate forum.

[arcow]

thank you !and thank Weedpacket's remind

i just come here ,and i want to know how to move the post to another forum?

[bubblenut]

Ah, yea, I should have actually read the first post and answered the original question shouldn't I?

[Weedpacket]

I've already moved it.