Where am I going wrong with this update

Tezread

So Im trying to create a form that gets prepopulated after selecting an item from a list box. Then I would like to edit the form, hit submit and have the form update.
I have an error message which reads:

Undefined index: quality_id in /disk1/home3/mindseye/public_html/notts_quality/info_resource/quality_info_form_updatev15.php on line 2101
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''quality_name'= 'test1', 'authority_body'= 'aaaaaa', 'address

here is my code:


<?php
session_start();
require_once('common_functions.php'); 
$_SESSION['form1_data']='';
?>


</style>
</head>

<body>
<?php
// list box to choose quality standard or approach to update

if (!isset ($_POST['submit'])) ;
{ 
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="POST">' 
        . 'Choose a quality standard/approach to update: <select name="quality_name">' . "\n"; 

$sql = "SELECT quality_id FROM quality_info"; 

$result = mysql_query($sql, $connection) 
    OR die(mysql_error()); 

while ($row = mysql_fetch_assoc($result)) 
{ 
    echo '<option value="' . $row['quality_id'] . '">' 
        . $row['quality_id'] . "</option>\n"; 
} 

echo '</select><input type="submit" name="submit" value="find" /></form>';  
}
?> 
</form>

<?php
//prepopulate the form
if (isset ($_POST['submit']) && $_POST['submit'] == 'find');
{ 
    $result = mysql_query ("SELECT * FROM quality_info WHERE quality_name = '" . $_POST['quality_name'] . "'");

if (mysql_num_rows ($result)) {$row = mysql_fetch_assoc ($result);} 
else {echo 'no records found matching ' . $_POST['quality_id'];} 

echo ' 
<form action="' . $_SERVER['PHP_SELF'] . '" method="POST"> 


      <td width="6%"></td>
<table width="100%"  border="0">
  <tr>

   <td width="3%">&nbsp;</td>
    <td width="1%">&nbsp;</td>
  </tr>
  <tr>
    <td><strong>Quality name </strong></td>
    <td width="39%"><input type="text" name="quality_name" value="' . $row['quality_name'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
    <td><strong>Authoritative/associative/governing body </strong></td>
     <td width="39%"><input name="authority_body" type="text" size="50" value="' . $row['authority_body'] . '"></td>
     <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
    <td><strong>Address1</strong></td>
     <td width="39%"><input name="address1" type="text" size="50" value="' . $row['address1'] . '"></td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Address2</strong></td>
     <td width="39%"><input name="address2" type="text" size="50" value="' . $row['address2'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Town</strong></td>
     <td width="39%"><input name="town" type="text" size="50" value="' . $row['town'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Postcode</strong></td>
     <td width="39%"><input name="postcode" type="text" size="50" value="' . $row['postcode'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Telephone</strong></td>
     <td width="39%"><input name="telephone" type="text" size="50" value="' . $row['telephone'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Email</strong></td>
     <td width="39%"><input name="email" type="text" size="50" value="' . $row['email'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Website</strong></td>
     <td width="39%"><input name="website" type="text" size="50" value="' . $row['website'] . '"></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Local agency</strong></td>
    <td width="39%"><textarea name="local_agency" rows = "5" cols="20">' . $row['local_agency'] . '</textarea></td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Contact</strong></td>
     <td width="39%"><textarea name="contact" rows = "5" cols="40">' . $row['contact'] . '</textarea></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
  	          <td><strong>What is it?</strong></td>
     <td width="39%"><textarea name="what_is_it" rows = "5" cols="40">' . $row['what_is_it'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>Who and what does it apply to?</strong></td>
     <td width="39%"><textarea name="who_what_apply" rows = "5" cols="40">' . $row['who_what_apply'] . '</textarea></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
  	          <td><strong>How does it work?</strong></td>
     <td width="39%"><textarea name="how_work" rows = "5" cols="40">' . $row['how_work'] . '</textarea></td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
  </tr>
  <tr>
  	          <td><strong>What are the resource implications</strong></td>
     <td width="39%"><textarea name="resource_implications" rows = "5" cols="40">' . $row['resource_implications'] . '</textarea></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>


  </tr>

  	<td>Click the submit button when you have completed your update 
    <input name="submit" type="submit" id="submit" value="update"></td>

    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>

  </tr>
</table>

  </form>

</div>
</body>
</html>

';  

}
?> 
<?php
$quality_name = $_POST['quality_name'];
if (isset($_POST['submit']) && $_POST['submit'] == 'update') 
{
//this is the update part
$sql = "UPDATE quality_info SET
'quality_name'= '".$_POST['quality_name']."',
'authority_body'= '".$_POST['authority_body']."',
'address1'= '".$_POST['address1']."',
'address2'= '".$_POST['address2']."',
'town'= '".$_POST['town']."',
'postcode'= '".$_POST['postcode']."',
'telephone varchar'= '".$_POST['telephone']."',
'email'= '".$_POST['email']."',
'website'= '".$_POST['website']."',
'local_agency'= '".$_POST['local_agency']."',
'contact'= '".$_POST['contact']."',
'what_is_it'= '".$_POST['what_is_it']."',
'who_what_apply'= '".$_POST['who_what_apply']."',
'how_work'= '".$_POST['how_work']."',
'resource_implications'= '".$_POST['resource_implications']."',

WHERE quality_id = '".$_POST['quality_id']."'
";
}

$result = mysql_query($sql) or die(mysql_error()); 

?>

</form>

thx in advance

Houdini

What is this field?
[code=php]'telephone varchar'= '".$_POST['telephone']."',

You might try this

$sql = "UPDATE quality_info SET
quality_name= '".$_POST['quality_name']."',
authority_body= '".$_POST['authority_body']."',
address'= '".$_POST['address1']."',
address2= '".$_POST['address2']."',
town= '".$_POST['town']."',
postcode= '".$_POST['postcode']."',
telephone= '".$_POST['telephone']."',
email= '".$_POST['email']."',
website= '".$_POST['website']."',
local_agency= '".$_POST['local_agency']."',
contact= '".$_POST['contact']."',
what_is_it= '".$_POST['what_is_it']."',
who_what_apply= '".$_POST['who_what_apply']."',
how_work= '".$_POST['how_work']."',
resource_implications= '".$_POST['resource_implications']."',

WHERE quality_id = '".$_POST['quality_id']."'
";

Tezread

that helps. Line 66 still throws back an undefined index error for quality_id. I have come across this before but I cannot remember how I dealt with it.

<?php
//prepopulate the form
if (isset ($_POST['submit']) && $_POST['submit'] == 'find');
{ 
    $result = mysql_query ("SELECT * FROM quality_info WHERE quality_id = '" . $_POST['quality_id'] . "'");

if (mysql_num_rows ($result)) {$row = mysql_fetch_assoc ($result);} 
[B]    else {echo 'no records found matching ' . $_POST['quality_id'];} [/B]

Houdini

Try echoing out the quality_id. because an undefined index is usually a blank value, see if theat variable actually has a value, possibly put a break; right after till you find out what is causing this or better yet set $_POST['quality_id'] to $id then echo it and also use it in the query

$result = mysql_query ("SELECT * FROM quality_info WHERE quality_id = ' $id'");

Tezread

ok now im totally lost- i did what you said and debugged using an echo statement as well as including $id in a resulting query. have a butchers at my code to see if im on the right track.
I getting the same feedback

see the form for yourself which has error messages

http://www.mindseyemidlands.co.uk/notts_quality/info_resource/quality_info_form_updatev15.php

<?php
session_start();
require_once('common_functions.php'); 
$_SESSION['form1_data']='';
?>


background-color: #990000;
-->
</style>
</head>

<body>
<?php
// list box to choose quality standard or approach to update

if (!isset ($_POST['submit'])) ;
{ 
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="POST">' 
        . 'Choose a quality standard/approach to update: <select name="quality_name">' . "\n"; 

$sql = "SELECT quality_id FROM quality_info"; 

$result = mysql_query($sql, $connection) 
    OR die(mysql_error()); 

while ($row = mysql_fetch_assoc($result)) 
{ 
    echo '<option value="' . $row['quality_id'] . '">' 
        . $row['quality_id'] . "</option>\n"; 
} 

echo '</select><input type="submit" name="submit" value="find" /></form>';  
}
?> 
</form>

<?php
//prepopulate the form
if (isset ($_POST['submit']) && $_POST['submit'] == 'find');
{ 
    $result = mysql_query ("SELECT * FROM quality_info WHERE quality_id = '" . $_POST['quality_id'] . "'");

if (mysql_num_rows ($result)) {$row = mysql_fetch_assoc ($result);} 
else {echo 'no records found matching ' . $_POST['quality_id'];} 

$id = $_POST['quality_id'];
echo $id;

echo ' 
<form action="' . $_SERVER['PHP_SELF'] . '" method="POST"> 




      <td width="6%"></td>
<table width="100%"  border="0">
  <tr>

   <td width="3%">&nbsp;</td>

  </tr>
  <tr>
    <td><strong>Quality name </strong></td>
    <td width="39%"><input type="text" name="quality_name" value="' . $row['quality_name'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
    <td><strong>Authoritative/associative/governing body </strong></td>
     <td width="39%"><input name="authority_body" type="text" size="50" value="' . $row['authority_body'] . '"></td>
     <td>&nbsp;</td>

  </tr>
  <tr>
    <td><strong>Address1</strong></td>
     <td width="39%"><input name="address1" type="text" size="50" value="' . $row['address1'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Address2</strong></td>
     <td width="39%"><input name="address2" type="text" size="50" value="' . $row['address2'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Town</strong></td>
     <td width="39%"><input name="town" type="text" size="50" value="' . $row['town'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Postcode</strong></td>
     <td width="39%"><input name="postcode" type="text" size="50" value="' . $row['postcode'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Telephone</strong></td>
     <td width="39%"><input name="telephone" type="text" size="50" value="' . $row['telephone'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Email</strong></td>
     <td width="39%"><input name="email" type="text" size="50" value="' . $row['email'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Website</strong></td>
     <td width="39%"><input name="website" type="text" size="50" value="' . $row['website'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Local agency</strong></td>
    <td width="39%"><textarea name="local_agency" rows = "5" cols="20">' . $row['local_agency'] . '</textarea></td>

    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Contact</strong></td>
     <td width="39%"><textarea name="contact" rows = "5" cols="40">' . $row['contact'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>What is it?</strong></td>
     <td width="39%"><textarea name="what_is_it" rows = "5" cols="40">' . $row['what_is_it'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>Who and what does it apply to?</strong></td>
     <td width="39%"><textarea name="who_what_apply" rows = "5" cols="40">' . $row['who_what_apply'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>How does it work?</strong></td>
     <td width="39%"><textarea name="how_work" rows = "5" cols="40">' . $row['how_work'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>What are the resource implications</strong></td>
     <td width="39%"><textarea name="resource_implications" rows = "5" cols="40">' . $row['resource_implications'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>How do you meet the standards and get assessed?</strong></td>
     <td width="39%"><textarea name="how_meet_standards" rows = "5" cols="40">' . $row['how_meet_standards'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	<td>&nbsp;</td>
  	   <td>&nbsp;</td>
  	          <td>&nbsp;</td>

  </tr>
  <tr>

   <td>&nbsp;</td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>

  </tr>
    <td>&nbsp;</td>
    <td>&nbsp;</td>

  </tr>

  	<td>Click the submit button when you have completed your update 
    <input name="submit" type="submit" id="submit" value="update"></td>

    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>

  </tr>
</table>

  </form>

</div>
</body>
</html>

';  

}
?> 
<?php
$quality_name = $_POST['quality_name'];
if (isset($_POST['submit']) && $_POST['submit'] == 'update') 
{
//this is the update part
$sql = "UPDATE quality_info SET
'quality_name'= '".$_POST['quality_name']."',
'authority_body'= '".$_POST['authority_body']."',
'address1'= '".$_POST['address1']."',
'address2'= '".$_POST['address2']."',
'town'= '".$_POST['town']."',
'postcode'= '".$_POST['postcode']."',
'telephone'= '".$_POST['telephone']."',
'email'= '".$_POST['email']."',
'website'= '".$_POST['website']."',
'local_agency'= '".$_POST['local_agency']."',
'contact'= '".$_POST['contact']."',
'what_is_it'= '".$_POST['what_is_it']."',
'who_what_apply'= '".$_POST['who_what_apply']."',
'how_work'= '".$_POST['how_work']."',
'resource_implications'= '".$_POST['resource_implications']."',

WHERE quality_id = '".$_POST['quality_id']."'
";
}

   $result = mysql_query ("SELECT * FROM quality_info WHERE quality_id = ' $id'");

?>

</form>

Houdini

Let me study this a little more, and I'll see what could be causing this, time for dinner right now.

Tezread

thx houdini- have a nice meal

Tezread

Started work early this morning and im still having issues with this. Although the error message is different. Here is my code:

<?php
session_start();
require_once('common_functions.php'); 
$_SESSION['form1_data']='';
?>

<?php 
// list box to choose quality standard or approach to update 

if (!isset ($_POST['submit'])) ; 
{ 
    echo '<form action="' . $_SERVER['PHP_SELF'] . '" method="POST">' 
        . 'Choose a quality standard/approach to update: <select name="quality_id">' . "\n"; 

$sql = "SELECT quality_id FROM quality_info"; 

$result = mysql_query($sql, $connection) 
    OR die(mysql_error()); 

while ($row = mysql_fetch_assoc($result)) 
{ 
    echo '<option value="' . $row['quality_id'] . '">' 
        . $row['quality_id'] . "</option>\n"; 
} 

echo '</select><input type="submit" name="submit" value="find" /></form>';   
} 
?> 
</form> 

<?php 

//prepopulate the form 
if (isset ($_POST['submit']) && $_POST['submit'] == 'find'); 
{ 
    $result = mysql_query ("SELECT * FROM quality_info WHERE quality_id = '" . $_POST['quality_id'] . "'"); 

if (mysql_num_rows ($result)) {$row = mysql_fetch_assoc ($result);} 
else {echo 'no records found matching ' . $_POST['quality_id'];} 

echo ' 
<form action="' . $_SERVER['PHP_SELF'] . '" method="POST"> 

          <td width="6%"></td>
<table width="100%"  border="0">
  <tr>

   <td width="3%">&nbsp;</td>
    <td width="1%">&nbsp;</td>
  </tr>
  <tr>
    <td><strong>Quality name </strong></td>
    <td width="39%"><input type="text" name="quality_name" value="' . $row['quality_name'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
    <td><strong>Authoritative/associative/governing body </strong></td>
     <td width="39%"><input name="authority_body" type="text" size="50" value="' . $row['authority_body'] . '"></td>
     <td>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
    <td><strong>Address1</strong></td>
     <td width="39%"><input name="address1" type="text" size="50" value="' . $row['address1'] . '"></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Address2</strong></td>
     <td width="39%"><input name="address2" type="text" size="50" value="' . $row['address2'] . '"></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Town</strong></td>
     <td width="39%"><input name="town" type="text" size="50" value="' . $row['town'] . '"></td>

    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Postcode</strong></td>
     <td width="39%"><input name="postcode" type="text" size="50" value="' . $row['postcode'] . '"></td>
    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Telephone</strong></td>
     <td width="39%"><input name="telephone" type="text" size="50" value="' . $row['telephone'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Email</strong></td>
     <td width="39%"><input name="email" type="text" size="50" value="' . $row['email'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Website</strong></td>
     <td width="39%"><input name="website" type="text" size="50" value="' . $row['website'] . '"></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
          <td><strong>Local agency</strong></td>
    <td width="39%"><textarea name="local_agency" rows = "5" cols="20">' . $row['local_agency'] . '</textarea></td>						
    <td>&nbsp;</td>
  </tr>
  <tr>
          <td><strong>Contact</strong></td>
     <td width="39%"><textarea name="contact" rows = "5" cols="40">' . $row['contact'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>What is it?</strong></td>
     <td width="39%"><textarea name="what_is_it" rows = "5" cols="40">' . $row['what_is_it'] . '</textarea></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
  	          <td><strong>Who and what does it apply to?</strong></td>
     <td width="39%"><textarea name="who_what_apply" rows = "5" cols="40">' . $row['who_what_apply'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>
  <tr>
  	          <td><strong>How does it work?</strong></td>
     <td width="39%"><textarea name="how_work" rows = "5" cols="40">' . $row['how_work'] . '</textarea></td>
    <td>&nbsp;</td>
  </tr>
  <tr>
  	          <td><strong>What are the resource implications</strong></td>
     <td width="39%"><textarea name="resource_implications" rows = "5" cols="40">' . $row['resource_implications'] . '</textarea></td>
    <td>&nbsp;</td>

  </tr>


  	<td>Click the submit button when you have completed your update 
    <input name="submit" type="submit" id="submit" value="update"></td>

    <td>&nbsp;</td>

  </tr>
</table>

  </form>

</div>
</body>
</html>

';  

}
?> 
<?php

if (isset($_POST['submit']) && $_POST['submit'] == 'update') 
{
//this is the update part
$sql = "UPDATE quality_info SET 
quality_name= '".$_POST['quality_name']."', 
authority_body= '".$_POST['authority_body']."', 
address'= '".$_POST['address1']."', 
address2= '".$_POST['address2']."', 
town= '".$_POST['town']."', 
postcode= '".$_POST['postcode']."', 
telephone= '".$_POST['telephone']."', 
email= '".$_POST['email']."', 
website= '".$_POST['website']."', 
local_agency= '".$_POST['local_agency']."', 
contact= '".$_POST['contact']."', 
what_is_it= '".$_POST['what_is_it']."', 
who_what_apply= '".$_POST['who_what_apply']."', 
how_work= '".$_POST['how_work']."', 
resource_implications= '".$_POST['resource_implications']."', 

WHERE quality_id = '".$row['quality_id']."' 
"; 

}

   $result = mysql_query($sql) or die(mysql_error()); 
  echo $row['quality_id'];

?>

</form>

the error message is vague:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''= 'bbbbbb', address2= 'cccc', town= 'ddddd', postcode= '

I have echoed my quality_id which outputs the correct number (depending on the choice made in the quality_id list box) so I still cannot see where im going wrong aaaahhrrrghhhh!

Tezread

I have done a search on updates based on variables too see if if there any threads out there that have touched on this already. As far as I can see Im on the right track already- if anyone can point me to a suitable thread from the past that would be great

thx in advance

Houdini

syntax to use near ''= 'bbbbbb', address2

Should

address'= '".$POST['address1']."',

address1= '".$_POST['address1']."',

?
or

address= '".$_POST['address1']."',

I think the single quote there is the problem, but I could be wrong