[RESOLVED] Need some help with echo

arbjones

I have a sample program I am trying to get going and its outputting some of the
code to my page. This is login script called from another page ... I thought I had the echo setup correctly but apparently not.
Houdini you probably can figure it out in a second lol. I uploaded the screenshot.

<?php
/ file login_form.inc
displays login page

*/
include("functions12.inc");
?>
<html>
<head><title>Members Login</title></head>
<body topmargin="0" leftmargin="0" marginright="0"
marginwidth="0">
<table border="0" cellpadding="5" cellspacing="0">
<tr><td colspan="3" bgcolor="gray" alighn="center">
<font color="white" size="+10">
<b>Members section</b></font></td></tr>
<tr>
<td width="33%" valign="top">
<font size="+1"><b>Are you a member?</b></font>
<p>

<form action="Login.php?do=login" method="POST">
<table border="0">
<?php
if (isset($message))
echo "<tr><td colspan='2'>$message </td></tr>";
?>
<tr><td align=right><b>username</b></td>
<td><input type="text" name="fusername"
size="20" maxsize="20">
</td></tr>
<tr><td width="120" align="right"><b>Password</b>
</td>
<td><input type="password" name="fpassword">
size="20" maxsize="20"</td></tr>
<tr><td align="center" colspan="2">
<br><input type="submit" name="log"
value="Enter">
</td></tr>
</table>
</form>
</td>
<td width="1" bgcolor="gray"></td>
<td width="67%">
<p><font size="+1"><b>Not a member yet?</b></font>
Get Discounts, a newsletter, advance notice of
new pets, much more. Fill in the information
below and join. Its easy and free! </b>

<form action="Login.php?do=new" method="POST">
<p>
<table border="0" width="100%">
<?php
if (isset($message_new))
echo "<tr><td colspan='2'><b>$message_new</b>
</td></tr>";
?>
<tr><td align="right"><b>Member ID</b></td>
<td><input type="text" name="newname"
value=<?php echo @$newname ?>"
size="20" maxlength="20"></td></tr>
<tr><td align="right"><b>Password</b></td>
<td><input type="text" name="newpass"
value=<?php echo @$newpass ?>"
size="10" maxlength="8"></td></tr>
<tr><td align="right"><b>First Name</b></td>
<td><input type="text" name="firstname"
value=<?php echo @$firstname ?>"
size="40" maxlength="40"></td></tr>
<tr><td align="right"><b>Last Name</b></td>
<td><input type="text" name="lastname"
value=<?php echo @$lastname ?>"
size="40" maxlength="40"></td></tr>
<tr><td align="right"><b>Street</b></td>
<td><input type="text" name="street"
value=<?php echo @$street ?>"
size="55" maxlength="50"></td></tr>
<tr><td align="right"><b>City</b></td>
<td><input type="text" name="City"
value=<?php echo @$city ?>"
size="40" maxlength="40"></td></tr>
<tr><td align="right"><b>State</b></td>
<td><input type="text" name=State">
?>
$statename=getstatename();
$statecode=getstatecode();
for ()$n=1;$n<=50;$n++)
{
$state=$statename[$n];
$scode=$statecode[$n];
echo "<option value='$scode'";
if ($scode== "AL")
echo " selected";
echo ">$state\n";
}
?>
</select>
    <b>Zip</b>
<input type="text" name="zip"
value="<php echo @$zip ?>"
size="10" maxsize="10">
</td></tr>
<tr><td align=right><b>Phone</b></td>
<input type="test" name="phone"
value="<php echo @$phone ?>"
size="15" maxsize="20">
   <b>Fax</b>
<input type="text" name="fax"
value="<php echo @$fax ?>"
size="15" maxsize="20"></td></tr>
<tr><td align=right><b>Email Address</b></td>
<input type="test" name="email"
value="<php echo @$email ?>"
size="55" maxsize="67"></td></tr>
<tr><td> </td>
<td align="center">
<input type="submit"
value="Become a Member"></td>"
</tr>
</table>
</form>
</td>
</tr>
<tr><td colspan="3" bgcolor="gray"> </td></tr>
</table>
<div align="center"><font size="1">
All comments and suggetions are appreciated. Please
send comments to <a href="mailto:webmaster@petstore.com">
webmaster@petstore.com</a> </font></div>
</body></html>

robin_percy

You have a couple problems.

You have an extra closing bracket on your password field, which is why the attributes are being displayed.
Your phone, fax, and email code is visible because you forgot the ? in the php tags ( <php should be <?php ).

Also, is there a reason you're prefixing your variables with @?

bradgrafelman

robin_percy wrote:
Also, is there a reason you're prefixing your variables with @?

'Tis the short-hand method of writing out all the "if(isset($_POST...))" junk to suppress errors. Not sure if it's a very preferred method, but I use it as well.

Also, when posting PHP code... make sure to use the forum's [ PHP] tags! Makes it easier to read.

Other than that, robin seems right on the money.

EDIT: Actually, you're also missing some semicolon's after all of your echo() calls to fill in the values.

Houdini

Everywhere you see the <php echo whatever?> is where you left the ? alsso you were missing a bunch of opening double quotes, and the table down where the zip city state and email were were all messed up. Also the @ all over have no real meaning that I am aware of so here is corrected code that should work provided your include has the two functions in it. When you paste code could you either manually type [ PHP ] in front of the code and [ /PHP ] (without the spaces) at the end it makes it easier to read and see problems, or there is a tilde ~ that is right after the <> that when clicked with code that has been highlighted it will enclose the php BB Code tag around the selected text.

<?php
/* file login_form.inc
* displays login page
*
*
*
*
*/
include("functions12.inc");
?>
<html>
<head><title>Members Login</title></head>
<body topmargin="0" leftmargin="0" marginright="0"
marginwidth="0">
<table border="0" cellpadding="5" cellspacing="0">
<tr><td colspan="3" bgcolor="gray" alighn="center">
<font color="white" size="+10">
<b>Members section</b></font></td></tr>
<tr>
<td width="33%" valign="top">
<font size="+1"><b>Are you a member?</b></font>
<p>
<!-- form for customer login -->
<form action="Login.php?do=login" method="POST">
<table border="0">
<?php
if (isset($message))
echo "<tr><td colspan='2'>$message </td></tr>";
?>
<tr><td align=right><b>username</b></td>
<td><input type="text" name="fusername" size="20" maxsize="20">
</td></tr>
<tr><td width="120" align="right"><b>Password</b>
</td>
<td><input type="password" name="fpassword" size="20" maxsize="20"></td></tr>
<tr><td align="center" colspan="2">
<br><input type="submit" name="log"value="Enter">
</td></tr>
</table>
</form>
</td>
<td width="1" bgcolor="gray"></td>
<td width="67%">
<p><font size="+1"><b>Not a member yet?</b></font>
Get Discounts, a newsletter, advance notice of
new pets, much more. Fill in the information
below and join. Its easy and free! </b>
<!-- form for new member to fill in -->
<form action="Login.php?do=new" method="POST">
<p>
<table border="0" width="100%">
<?php
if (isset($message_new))
echo "<tr><td colspan='2'><b>$message_new</b>
</td></tr>";
?>
<tr>
<td align="right">
<b>Member ID</b>
</td>
<td>
<input type="text" name="newname" value="<?php echo $newname ?>"size="20" maxlength="20">
</td>
</tr>
<tr>
<td align="right">
<b>
Password</b>
</td>
<td>
<input type="text" name = "newpass" value = "<?php echo $newpass ?>"size="10" maxlength="8">
</td>
</tr>
<tr>
<td align="right"><b>First Name</b>
</td>
<td>
<input type="text" name="firstname"value="<?php echo $firstname ?>"size="40" maxlength="40"></td></tr>
<tr>
<td align="right"><b>Last Name</b>
</td>
<td>
<input type="text" name="lastname"value="<?php echo $lastname ?>"size="40" maxlength="40"></td></tr>
<tr>
<td align="right">
<b>Street</b>
</td>
<td>
<input type="text" name="street"value="<?php echo $street ?>"size="55" maxlength="50">
</td>
</tr>
<tr>
<td align="right">
<b>City</b>
</td>
<td>
<input type="text" name="City"value="<?php echo $city ?>"size="40" maxlength="40"></td></tr>
<tr>
<td align="right">
<b>State</b>
</td>
<td>
<input type="text" name="State">
<?php
$statename=getstatename();
$statecode=getstatecode();
for ($n=1;$n<=50;$n++)
{
$state=$statename[$n];
$scode=$statecode[$n];
echo "<option value='$scode'";
if ($scode== "AL"){//this brace was added
echo " selected";
echo ">$state\n";
  }//as was this one
}
?>
</select>
&nbsp;&nbsp;&nbsp;&nbsp;
<b>Zip</b>
<input type="text" name="zip" value = "<?php echo $zip ?>" size="10" maxsize="10">
</td>
</tr>
<tr>
<td align="right">
<b>Phone</b>
</td>
<td>
<input type="test" name="phone" value = "<?php echo $phone ?>" size="15" maxsize="20">&nbsp;&nbsp;&nbsp;
</td>
</tr>
<tr>
<td align="right">
<b>Fax</b>
</td>
<td>
<input type="text" name= "fax" value = "<?php echo $fax ?>" size="15" maxsize="20">
</td>
</tr>
<tr>
<td align="right">
<b>Email Address</b>
<td>
<input type="test" name = "email" value = "<?php echo $email ?>"size="55" maxsize="67">
</td>
</tr>
<tr>
<td>&nbsp;</td>
<td align="center">
<input type="submit"value="Become a Member">
</td>
</tr>
</table>
</form>
</td>
</tr>
<tr><td colspan="3" bgcolor="gray">&nbsp;</td></tr>
</table>
<div align="center"><font size="1">
All comments and suggetions are appreciated. Please
send comments to <a href="mailto:webmaster@petstore.com">
webmaster@petstore.com</a> </font></div>
</body></html>

robin_percy

'Tis the short-hand method of writing out all the "if(isset($_POST...))" junk to suppress errors. Not sure if it's a very preferred method, but I use it as well.

I only mention this since this forum is dedicated to n00bs, but that practice would imply you're not initializing your variables before use - leaving your code a little more vulnerable to exploits.