Problems with fwrite and counter loop

chrisdee

Hello. Im trying to make the script that will write the same
sentance to a textfile, and in addition add a variable number
for each new sentance like this :

This is line number 1
This is line number 2
This is line number 3
and so on...

My script below only writes the first line again. How do I
solve this ?

<?php 
$open = fopen('test.txt', 'a'); 
$count = $count + 1; 
fwrite($open, "This is number $count\n"); 
fclose($open); 

$fileopen = file('test.txt'); 
foreach($fileopen as $f) { 
 print "$f<br>"; 
} 
?>

laserlight

Generate the string using a loop.

chrisdee

How would i do that

laserlight

$str = '';
for ($i = 1; $i < 4; ++$i) {
	$str .= 'This is line number ' . $i . "\n";
}

Pobega

What I would do is use a function.

$open = fopen('test.txt', 'a');
$count = 0;
function numberWrite($total)
{
while ($count <= $total)
{
$count += 1;
fwrite($open, "This is number $count\n");
}
}
fclose($open);

Then just call the function with

numberWrite(total_number_of_lines_you_want_written_in_integer_form);

For example:

$open = fopen('test.txt', 'a');
$count = 0;
function numberWrite($total)
{
while ($count < $total)
{
$count += 1;
fwrite($open, "This is number $count\n");
}
}
fclose($open); 

numberWrite(10);

So your file would read...

This is number 1
This is number 2
This is number 3
This is number 4
This is number 5
This is number 6
This is number 7
This is number 8
This is number 9
This is number 10

laserlight

Better to construct the string and write at once than to perform many writes.

Pobega

laserlight wrote:
Better to construct the string and write at once than to perform many writes.

Well the advantage of a function is that he can control how many times he wants the string outputted, so I think a function would be advantageous in this situation. Then again I'm moving to php from Python, and Python is almost built on recursion and functions (At least the way I used it)

laserlight

Well the advantage of a function is that he can control how many times he wants the string outputted, so I think a function would be advantageous in this situation.

It depends on whether any re-use is needed. The string can be generated via a function, of course.

Pobega

Yeah, that is true. I've only been using php for two days now so I'm still used to the way Python works with code. I suppose in a real program you'd be using functions more often than a web program.

chrisdee

Thank you for your suggestions but I could not get the function to work.
I got the following error message :

Warning: fwrite(): supplied argument is not a valid stream resource in /var/www/skole/skole/oving7/index.php on line 9

Im also not shure I explained myself good enough. What i want is
to write one line at a time, when the page is viewed.
If the line and number already exists I want the script to write a new line with the
same text but with a number one step bigger than the previous number/line.

Like so :

This is line number 1
This is line number 2
This is line number 3
This is line number 4

Pobega

Oh, okay, let me write out a script I think should work.

<?php
	function hitCounter();
		{
		$explodeMe = file_get_contents('hitCounts.txt');
		$explosion = explode('  ', $explodeMe);
		$count = 0;
		while ($explosion[$count])
			{
			$count++;
			}
		$count += 1;
		$openHits = fopen('hitCounts.txt', 'a+');
		fwrite($openHits, This line is number ");
		fwrite($openHits, $count);
		fwrite($openHits, "  \n");
		fclose($openHits);
		}
	hitCounter();
?>

You'll need a seperate file to permanently hold the number of hits, and make sure it is CHMODed to 777. The file should be in the same folder as this, and it should be called "hitCounts.txt" (Case-sensitive).

php include this php file into any page you want to add to the hit counter/text file (So, if you want only hits to the index to add to the file, only include it to index.php). In case you don't know how to include a file, here is the code:

<?php
include("fileHere.php");
?>

laserlight

What i want is
to write one line at a time, when the page is viewed.
If the line and number already exists I want the script to write a new line with the
same text but with a number one step bigger than the previous number/line.

And if it doesnt exist? Basically, your formulation of the problem is vague.

Another question: why do you want to do this? What do you hope to accomplish by this exercise?

If we know what you are actually trying to do, we may be able to suggest a better approach to solving it.

Pobega

I think he is trying to make something that acts like a hit counter, which is what I made for him.

chrisdee

That is correct. I found a solution actually. Se below :

<?php
$lines = file('test.txt');
$nextLineNumber = count($lines) + 1;

$open = fopen('test.txt', 'a');
fwrite($open, "This is number $nextLineNumber\n");
fclose($open);

foreach($lines as $line) {
 print "$line<br>";
}
?>