Long code, gives my blank page (as an error)

Oni

Hey,

I have a long piece of code that I coded in one shot, not testing out each little bit of it. And now that I run it it doesn't do anything other then just give me a blank page?

The page load time gives the impression that it's trying to do something but can't?

<?php 
function microtime_float()
{
   list($usec, $sec) = explode(" ", microtime());
   return ((float)$usec + (float)$sec);
}

$time_start = microtime_float();

include("http://surfall.be/top.php?ref=$ref"); 

print "<h1>Register</h1><p><center>";



$user = $_POST["user"];
$pass = $_POST["pass"];
$email = $_POST["email"];
$doono = $_POST["doono"];
$ref = $_POST["ref"];


include('mysql.php');

//Check if user already registered
$query = "SELECT user FROM users WHERE user = '$user'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&user=1");
exit;
}
//Check if doono is already registered
$query = "SELECT doono FROM users WHERE doono = '$doono'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&doono=1");
}

//Check if doono is banned
$query = "SELECT doono FROM banned WHERE doono = '$doono'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&doono=2");
}

//Check if email is already registered
$query = "SELECT email FROM users WHERE email = '$email'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&email=1");
}

//Check if email is banned
$query = "SELECT email FROM banned WHERE email = '$email'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&email=2");
}

If ($ref > 0)
{
mysql_query("INSERT INTO users(user, pass, email, doono, ref) VALUES('$user', '$pass', '$email', '$doono', '$ref')")
or die(mysql_error());

}
else {
mysql_query("INSERT INTO users(user, pass, email, doono) VALUES('$user', '$pass', '$email', '$doono')")
or die(mysql_error());
}

$numbers = Array(3jhkda,djqys7,koysk8,78hgsy,8hysjh,87hsyf,9juysh,ju7shg,uuhys6,koiys7,ysodty,yggft5,johys7,fhyd6a,ijyhza,bhdyas,bkhsya,7hdyas,mjdkis,kouasy);
srand((float)microtime() * 1000000);
shuffle($numbers);



// Your email address
$me = "admin@surfall.be";

// The subject
$subject = "$user surfall.be Registration";

// The message
$message = "
Welcome to the DoonoSurf.info community $user! \n 
Registration details can be seen below: \n \n
ID: $id \n
Username: $user \n
Password: $pass \n
Doono ID: $doono \n
IP Address: GetHostByName($REMOTE_ADDR) \n 
Surflink: <a href=\"http://surfall.be/surf.php?id=$id&email=$email\">http://doonosurf.info/surf.php?id=$id&email=$email</a> \n \n
Again, thanks for joining the community.  \n If you have any question please use the contact form on the website. \n 
surfall.be Admin \n \n 

Please note that --THIS ISNT SPAM--  The user may delete their membership by simply logging in and clicking on \"delete\".

";

mail($email, $subject, $message, "From: $me");

print "Confirmation email has been sent to $email.  You must activate your account before being able to login!<BR><BR>Thanks for joining!";
$time_end = microtime_float();
$time = round($time_end - $time_start, 4);
include ("http://surfall.be/footer.php?time=$time"); 

?>

Any ideas? :rolleyes:

R4v

Im not the greatest but perhaps adding check points.. ie..

echo 'DEBUG 1';

further down

echo 'DEBUG 2';

will give you some idea where the error is.. or even turn on error reporting...

bradgrafelman

Do a phpinfo() and tell us... is displays_errors set to On and error_reporting set to E_ALL ?

If not, make those changes and try it again.

Oni

display_errors Off Off
error_reporting 2039 2039

Are the values I see.

I added these lines to the top of my code:

ini_set (display_errors, ON);
ini_set (error_reporting, E_ALL);

But I still get a while page?

R4v: Nice idea but it seems that whatever I do I seem to get a blank page...

Oni

I ran the code on my computer and got this error:

Parse error: parse error, expecting `')'' in c:\apache\htdocs\htdocs\register.php on line 79

Line 79:

$numbers = Array(3jhkda,djqys7,koysk8,78hgsy,8hysjh,87hsyf,9juysh,ju7shg,uuhys6,koiys7,ysodty,yggft5,johys7,fhyd6a,ijyhza,bhdyas,bkhsya,7hdyas,mjdkis,kouasy);

bradgrafelman

Yeah.. I noticed that, should have said something.

That is not the proper way to identify strings in an array. You have the same problem there as if you were trying to reference an associative array such as $array[theKey] - strings are delimited by quotes. Without quotes, PHP thinks you're naming off constants, which 99.9% of the time don't exist since this is NOT what you want.

Surround the strings in the array elements with quotes and try that again. If that doesn't work, show us how you changed this line.

EDIT: In fact, you have the same problem with your [man]ini_set/man call. Looking in the manual page for that function (linked), you see this:

string ini_set ( string varname, string newvalue )

Note that it says it's looking for two string parameters. You didn't specify two strings - you specified two constants, neither of which exist.

Oni

Yup, that did the trick 😉

But now there is one little small problem...

I want to check if the username is already taken and if it is then change the header of the page. I use this code to do it:

//Check if user already registered
$query = "SELECT user FROM users WHERE user = '$user'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://site.com/join.php?ref=$ref&user=1");

}

But it doesn't seem to go to the page? The code just keeps on running.

stewartship

Hi Oni

I have revamped the code for you below so it should work now, always exit the code after a header, and note the use of mysql fetch row following the $result working not at same time. Hope this helps any trouble please post me back!

//Check if user already registered
$query = "SELECT user FROM users WHERE user = '$user'";

$result = mysql_query($query);

if ($result)
{

$user_exists = mysql_fetch_row($result);

if($user_exists > 0) { // means already exists

Header("Location: http://site.com/join.php?ref=$ref&user=1");

exit;

}

else{

echo 'Database query did not work.<br><br>';

}

Oni

I just get a blank page? 🙁

stewartship

Hi Oni!
Checked the code i wrote and it seems fine. Are you sure the location you are using is valid (just go through with a fine tooth comb just to check might be a mis-spell somewhere). The only other thing i know is that if you are using sessions, and the session has already started you get problems when trying to run headers after session start, as php automatically sends them, might be this!
Also do me a favour and echo all the $varibles to ensure everything is runnning smoothly (which it seems it is as you would have got one of my error messages popping up!), so it all sort of points to the Location / or the sesssion.
Sorry if this has not helped much!

Oni

Checked everything, still just a blank page as a reply 🙁

I even put a

print $query;
flush();
ob_flush();

To see the query but it doesn't do anything...Just a blank page again 🙁

My code as of now:

<?php 

ini_set ('display_errors', 'ON');
ini_set ('error_reporting', 'E_ALL');

function microtime_float()
{
   list($usec, $sec) = explode(" ", microtime());
   return ((float)$usec + (float)$sec);
}

$time_start = microtime_float();




$user = $_POST["user"];
$pass = $_POST["pass"];
$email = $_POST["email"];
$doono = $_POST["doono"];
$ref = $_POST["ref"]; 




include('mysql.php');

//Check if user already registered
$query = "SELECT user FROM users WHERE user = '$user'";
$result = mysql_query($query);

if (mysql_fetch_row($result) > 0)
{


  Header("Location: http://surfall.be/join.php?ref=$ref&user=1");
//exit;
}
//Check if doono is already registered
$query = "SELECT doono FROM users WHERE doono = '$doono'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&doono=1");
}

//Check if doono is banned
$query = "SELECT doono FROM banned WHERE doono = '$doono'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&doono=2");
}

//Check if email is already registered
$query = "SELECT email FROM users WHERE email = '$email'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&email=1");
}

//Check if email is banned
$query = "SELECT email FROM banned WHERE email = '$email'";
$result = mysql_query($query);
if (mysql_fetch_row($result))
{
  Header("Location: http://surfall.be/join.php?ref=$ref&email=2");
}

If ($ref > 0)
{
mysql_query("INSERT INTO users(user, pass, email, doono, ref) VALUES('$user', '$pass', '$email', '$doono', '$ref')")
or die(mysql_error());

}
else {
mysql_query("INSERT INTO users(user, pass, email, doono) VALUES('$user', '$pass', '$email', '$doono')")
or die(mysql_error());
}

$id = 1;
$numbers = Array('4312','4212');
srand((float)microtime() * 1000000);
shuffle($numbers);



// Your email address
$me = "admin@site";

// The subject
$subject = "$user  Registration";

// The message
$message = "
Welcome to the community $user! \n 
Registration details can be seen below: \n \n
ID: $id \n
Username: $user \n
Password: $pass \n
Doono ID: $doono \n
IP Address: "GetHostByName($REMOTE_ADDR)" \n 
Surflink: <a href=\"http://site/surf.php?id=$id\">http://site/surf.php?id=$id</a> \n \n
Again, thanks for joining the community.  \nIf you have any question please use the contact form on the website. \n 
 Admin \n \n 

Please note that --THIS ISNT SPAM--  The user may delete their membership by simply logging in and clicking on \"delete\".

";

mail($email, $subject, $message, "From: $me");

include("http://surfall.be/top.php?ref=$ref"); 

print "<h1>Register</h1><p><center>";
print "Confirmation email has been sent to $email.  You must activate your account before being able to login!<BR><BR>Thanks for joining!";
$time_end = microtime_float();
$time = round($time_end - $time_start, 4);
include ("http://surfall.be/footer.php?time=$time"); 

?>

All of the locations (urls) are valid...

bradgrafelman

Try changing this:

ini_set ('error_reporting', 'E_ALL');

to this:

ini_set ('error_reporting', E_ALL);

Oni

Still blank page 🙁

Rodney_H_

Oni wrote:

<?php 
/* SNIP */

// The message
$message = "
Welcome to the community $user! \n 
Registration details can be seen below: \n \n
ID: $id \n
Username: $user \n
Password: $pass \n
Doono ID: $doono \n
IP Address: "GetHostByName($REMOTE_ADDR)" \n 
Surflink: <a href=\"http://site/surf.php?id=$id\">http://site/surf.php?id=$id</a> \n \n
Again, thanks for joining the community.  \nIf you have any question please use the contact form on the website. \n 
 Admin \n \n 

Please note that --THIS ISNT SPAM--  The user may delete their membership by simply logging in and clicking on \"delete\".

";
?>

I think this line: IP Address: "GetHostByName($REMOTE_ADDR)" \n

Should be this: IP Address: " . GetHostByName($REMOTE_ADDR) . " \n

SO:

<?php

// The message
$message = "
Welcome to the community $user! \n
Registration details can be seen below: \n \n
ID: $id \n
Username: $user \n
Password: $pass \n
Doono ID: $doono \n
IP Address: " . GetHostByName($REMOTE_ADDR) . " \n
Surflink: <a href=\"http://site/surf.php?id=$id\">http://site/surf.php?id=$id</a> \n \n
Again, thanks for joining the community.  \nIf you have any question please use the contact form on the website. \n
Admin \n \n

Please note that --THIS ISNT SPAM--  The user may delete their membership by simply logging in and clicking on \"delete\".

";

?>

Oni

Yup, that did the trick 😉

However, I see that when the page goes back to the specified header, php still executes the below code. I put an exit(); but it doesn't seem to do anything?

Which is not too much of a problem because I can just make a variable value 1 and the rest of the code would check the variable and not run if it is 1 but a "real" fix would be better!

Thanks for all the help!!