IF & QUERY

[olsrey]

Hi everyone, im having a lot of trouble with query and then an if

$code1 = $_POST['code'];
$claim1 = mysql_query("SELECT * FROM credits WHERE `r_code` = '$code1'") or die(mysql_error());
$claim = mysql_query($claim1);
if(!$claim) {
print"Receipt Code doesnt exist!";
}elseif($claim['r_code'] == $code1 && $claim['claim'] == 'y') {
print"This Receipt Code has already been claimed!";
}elseif($claim['r_code'] == $code1 && $claim['claim'] == 'n') {
mysql_query("UPDATE credits SET claim = 'y' WHERE r_code = '$code1'");
print"Credits Claimed!";
}

now my problem is that whether or not the query is successful ie it finds the code its looking for it still displays "Receipt Code doesnt exist!" please can someone please tell me what im doing wrong

[stewartship]

Hi there!

Try the following, hints remeber to annotate as much as possible, split your code up makes it easier to run through (if something does not work post me back!):

$code1 = $_POST['code'];

$claim1 = "SELECT * FROM credits WHERE r_code = '$code1' ";

$claim = mysql_query($claim1);

if($claim) { // query has sucessful

$num_results = mysql_num_rows($claim); // returns number of rows returned from query

for($i=0; $i<$num_results; $i++){ // runs through the results

$row = mysql_fetch_assoc($claim); // can go through result array using names

if($row['r_code'] == '$code1' && $row['claim'] == 'y') {
print"This Receipt Code has already been claimed!";
}

if($row['r_code'] == '$code1' && $row['claim'] == 'n') {

$new_query = " UPDATE credits SET claim = 'y' WHERE r_code = '$code1' ";

$query2 = mysql_query($new_query);

if($query2){

echo 'Update of database successful.<br><br>';

}

else{

echo 'Could not update the databse.<br><br>';

}

} // to seconf if of first successgul query

} // to the for going through results

} // to if first query successful

else{
echo 'Could not find all from table credits in database. The query failed.<br><br>';
}

[olsrey]

lol well after u missed a } off i added it but now it doesnt say anything however i have printed a num_rows and that tells me that it exists but the code is messed somewhere :S

[stewartship]

lol sorry about that, had to do the code in a dash!

but the idea was to give you a basic layout to work with compared to the original code!
i am presuming that the association names do correlate correctly to that of the databse titles?! i know it sounds silly but sometimes it is easy to mispell the assoc bit.
If all is ok try bracketing the if queries in the second half more so that you got the layout of ( (.........) && (.........) ).
Post me back if no change!

[olsrey]

😕 nope i tried to do everything last night ive bein coding php for months now and ive never had such a problem ive checked and doubled checked everything :bemused:

[olsrey]

OMFG i cant beleive i did this if u look at the first query i did i never fetched the results DUH!!! ill try now lol

[olsrey]

yay!!! it works now 😛 😃

[stewartship]

good stuff! 🙂

[olsrey]

i really cant beleive i missed that although i did code it at like 5 am :$ ahwell i guess ill just have to code in the day lol

[stewartship]

i know the feeling

[laserlight]

Firstly, $claim1 is a database result resource. As such, you cannot do a mysql_query() on it, since that requires a string (i.e. the SQL statement).

What you probably want to do is to use [man]mysql_query/man to execute the query, then use [man]mysql_fetch_assoc/man to get the result set returned. In this case, you only need one field with a single row returned, so [man]mysql_result/man could be used instead.

// perform validation of $_POST['code']
// ...
// end the validation of $_POST['code']
// assume $code contains validated value of $_POST['code']
$query = "SELECT claim FROM credits WHERE r_code='$code'";
if ($result = mysql_query($query)) {
	if (mysql_num_rows($result) == 1) {
		if (mysql_result($result, 0) == 'y') {
			echo 'This Receipt Code has already been claimed!';
		} else {
			if (mysql_query("UPDATE credits SET claim='y' WHERE r_code='$code'")) {
				echo 'Credits Claimed!';
			} else {
				echo 'Credits could not be claimed!';
			}
		}
	} else {
		echo 'Receipt code provided is invalid!';
	}
} else {
	echo 'There has been some error with the database';
}

[olsrey]

as i just said i forgot it lol it was too early 😉 in the morning and i just used a fetch_array as it never fails 😃