if statement problem

[mrbill501]

Could anyone tell me why this if statement is working? Its for image resizing and individually the two parts work but when I put them in an if statement together only one does. The code is :
<?php
ini_set("include_path","/home/fhlinux192/s/studentart.streamlinenettrial.co.uk/user/htdocs/includes/");
include ('pics.inc');
$connection = mysql_connect($host,$user,$password)
or die(mysql_error());
$db = mysql_select_db($database, $connection)
or die(mysql_error());
if (isset($GET['image_id'])) {
$image_id = $GET['image_id'];
$query = "SELECT FROM tbl_images WHERE image_id = '$image_id'";
$result = mysql_query($query);
if(mysql_num_rows($result) == 1) {
$fileType = mysql_result($result, 0, "image_type");
$fileContent = mysql_result($result, 0, "image");
$im = imagecreatefromstring($fileContent);
$width = imagesx($im);
$height = imagesy($im);
$maxwidth = 760;
if ($width > $maxwidth){
$imgw = 740;
$imgh = $height / $width $imgw;
$image=imagecreatetruecolor($imgw,$imgh);
imagecopyresized($image,$im,0,0,0,0,$imgw,$imgh,imagesx($im),imagesy($im));
$out = imagejpeg($image);
header("Content-type: $fileType");
echo $out;
} elseif ($width < $maxwidth) {
$query = "SELECT * FROM tbl_images WHERE image_id = '$image_id'";
$result = mysql_query($query);
$fileType = mysql_result($result, 0, "image_type");
$filecontent = mysql_result($result, 0, "image");
header("Content-type: $fileType");
echo $filecontent;
}
}
};
?>
The first part is meant to resize an image to 740 px if its width exceeds the screen width and the bottom part shows an image if it is under the max width. The resize code works fine when it is used to change image to thumbnails so I guess the problem must be in my if statements.
Thanks

[laserlight]

How does it not work?

Its for image resizing and individually the two parts work but when I put them in an if statement together only one does.

Which part is which?

Also, use [php] and [/php] forum bbcode tags to enclode your properly indented PHP code.

[mrbill501]

ah righto. Its basically two seperate bits of code that I've tried to stick together to form one that works the way I want it to.
if (isset($GET['image_id'])) {
$image_id = $GET['image_id'];
$query = "SELECT FROM tbl_images WHERE image_id = '$image_id'";
$result = mysql_query($query);
if(mysql_num_rows($result) == 1) {
$fileType = mysql_result($result, 0, "image_type");
$fileContent = mysql_result($result, 0, "image");
$im = imagecreatefromstring($fileContent);
$width = imagesx($im);
$height = imagesy($im);
$maxwidth = 760;
if ($width > $maxwidth){
$imgw = 740;
$imgh = $height / $width $imgw;
$image=imagecreatetruecolor($imgw,$imgh);
imagecopyresized($image,$im,0,0,0,0,$imgw,$imgh,imagesx($im),imagesy($im));
$out = imagejpeg($image);
header("Content-type: $fileType");
echo $out;
} elseif ($width < $maxwidth) {
$query = "SELECT * FROM tbl_images WHERE image_id = '$image_id'";
$result = mysql_query($query);
$fileType = mysql_result($result, 0, "image_type");
$filecontent = mysql_result($result, 0, "image");
header("Content-type: $fileType");
echo $filecontent;
}
}
};
?>

Everything in blue is meant to check an image from a database and see if its width is bigger than 760px and resize it to 740 if it is, this is the bit that doesnt work and is taken from some code I used to resize images into thumbnails which does work.
The red code is the part that works and is for showing an image if it will already fit on the screen.

[laserlight]

Well, for starters note that ($width > $maxwidth) and ($width < $maxwidth) cannot be simultaneously true.

[mrbill501]

Does it say that? I thought if was two seperate statements. At the moment if the width is < maxwidth the image shows up. Its only when its > that it doesnt work.

[laserlight]

Consider this script:

<?php
if (true) {
	echo 'this is shown';
} elseif (true) {
	echo 'this is never shown';
}
?>

[mrbill501]

Ok I've changed the elseif to an else and removed the $width<$maxwidth. I still get the same result of images over 760px not being displayed while images under 760px will be displayed.

[laserlight]

You just need to resize if the width is greater than the maxwidth. Regardless of the result of this comparison, you will send the header and create the image.

if (isset($_GET['image_id'])) {
	$image_id = $_GET['image_id'];
	$query = "SELECT image_type, image FROM tbl_images WHERE image_id = '$image_id'";
	$result = mysql_query($query);
	if (mysql_num_rows($result) == 1) {
		$fileType = mysql_result($result, 0, "image_type");
		$fileContent = mysql_result($result, 0, "image");
		$im = imagecreatefromstring($fileContent);
		$width = imagesx($im);
		$height = imagesy($im);
		$maxwidth = 760;
		if ($width > $maxwidth) {
			$imgw = 740;
			$imgh = $height / $width * $imgw;
			$image = imagecreatetruecolor($imgw,$imgh);
			imagecopyresized($image,$im,0,0,0,0,$imgw,$imgh,imagesx($im),imagesy($im));
			$im = $image;
		}
		header("Content-type: " . $fileType);
		imagejpeg($im);
	}
}

[mrbill501]

Sorry I'm not sure I follow

[laserlight]

Think about it - resizing the image and displaying it are two different things.

[mrbill501]

I see where your going with this. Thanks.