Loop Printing only 1st filename

jennifer_ann

Can someone please tell me why this loop isn't working? It's only printing the first filename and I need it to print all the file names. THANKS!

extract($_POST);

$query = "SELECT yr_left, city_origin, country_origin, yr_arrival, city_arrival, state_arrival FROM story WHERE country_origin = '$search_country' AND pamapproved = 'Y' ORDER BY yr_left";
$result = mysql_query($query);
$query2 = "SELECT filename FROM story WHERE country_origin = '$search_country' AND pamapproved = 'Y' ORDER BY yr_left";
$result2 = mysql_query($query2);


print "<tr height = '15%'>";
print "<th class='theader'>File</th>";
print "<th class='theader'>Year Left</th>";
print "<th class='theader'>City Origin</th>";
print "<th class='theader'>Country Origin</th>";
print "<th class='theader'>Year Arrived</th>";
print "<th class='theader'>City Arrived</th>";
print "<th class='theader'>State Arrived</th></tr>";


while($row = mysql_fetch_array($result2))
{
	while($column = mysql_fetch_object($result))
	{
		foreach($row as $filename)
		{
		print "<tr height = '30%'>";
		print "<td><input type = 'button' name = 'file' value = '$filename' </td>";
		}
			foreach($column as $colval)
			{
				print "<td class = 'tdata'>$colval</td>";
			}
		print "</tr>";
	}
}	
print "</table>";

mysql_free_result($result);
mysql_free_result($result2);

mysql_close();
?>

bpat1434

You have a foreach() on an object..... 🙁

jennifer_ann

Why should it not be foreach?

bpat1434

because it's an object... not an array 😉

So this is wrong:

while($column = mysql_fetch_object($result))

It shoudl be this:

while($column = mysql_fetch_array($result))

and all should be well

jennifer_ann

Thanks for the suggestion, but that still didn't work

jennifer_ann

do I need counters rather than the while statements??

bpat1434

remove the foreach() calls... you're double looping....

SOmething like:

while($row = mysql_fetch_array($result2))
	{
		print "<tr height = '30%'>";
		print "<td><input type = 'button' name = 'file' value = '".$row['filename']."' </td>";

	while($column = mysql_fetch_array($result))
	{
		print "<td class = 'tdata'>".$row['colval']."</td>";
	}

	print "</tr>";
}

Alternatively you could do:

$files = array();
$cols = array();

while($row = mysql_fetch_array($result2))
    $files[] = $row['filename'];

while($row = mysql_fetch_array($result))
    $cols[] = $row['colval'];

foreach($files as $file)
{
  // Do whatever here

  foreach($cols as $colval)
  {
    // Do whatever else here
  }
}

jennifer_ann

I think its still doing part of a double loop, but I think I'm on a clearer track now. But could you please explain to me 1 thing? Just for my own curiousity.....why did you approach the loop this way and not with a counter???

bpat1434

No reason. A counter would have been fine. Either one would have worked, but a for() loop isn't necessarily the fastest for the array, but it could work.

It's just a preference.

jennifer_ann

Ok thank you 🙂

jennifer_ann

Hey now I keep getting this error message and I'm not sure why:

Notice: Undefined variable: result2 in c:\program files\easyphp1-8\www\mapquery.php on line 45

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in c:\program files\easyphp1-8\www\mapquery.php on line 45

Notice: Undefined index: colval in c:\program files\easyphp1-8\www\mapquery.php on line 49

Notice: Undefined index: colval in c:\program files\easyphp1-8\www\mapquery.php on line 49

Here is the new code

<html>
<head>
	<title>Eye Contact - Century to Century</title>
	<link rel="stylesheet" href="eye01.css" type="text/css" />
</head>


<body>
<form name = "display" method = "post" action = "http://localhost/display.php">
<?php
print "<table width='100%' border='1' height = '90%'>";
$db = mysql_connect("localhost","root","");
if (!$db)
{
	print "error - Could not connect to MySQL";
	exit;
}

$er = mysql_select_db("touch_art1");
if(!$er)
{
	print "error - Could not select the database";
	exit;	
}

extract($_POST);

$query = "SELECT filename, yr_left, city_origin, country_origin, yr_arrival, city_arrival, state_arrival FROM story WHERE country_origin = '$search_country' AND pamapproved = 'Y' ORDER BY yr_left";
$result = mysql_query($query);


print "<tr height = '15%'>";
print "<th class='theader'>File</th>";
print "<th class='theader'>Year Left</th>";
print "<th class='theader'>City Origin</th>";
print "<th class='theader'>Country Origin</th>";
print "<th class='theader'>Year Arrived</th>";
print "<th class='theader'>City Arrived</th>";
print "<th class='theader'>State Arrived</th></tr>";


 $files = array();
 $cols = array();

while($row = mysql_fetch_array($result2))
    $files[] = $row['filename'];

while($row = mysql_fetch_array($result))
    $cols[] = $row['colval'];

foreach($files as $file)
{
  print "<tr height = '30%'>";
			print "<td><input type = 'button' name = 'file' value = '$filename' </td>";
}
  foreach($cols as $colval)
  {
 print "<td class = 'tdata'>$colval</td>";
  }
	print "</table>";

mysql_free_result($result);
mysql_free_result($result2);

mysql_close();
?>
	<input type="hidden" name="" value="none">
<table width = "100%" border = "0" height = "10%">
	<tr height = "10%">
		<td align="left" valign="bottom" width="50%" >
		<embed src="images/home.svg" width="100%" height="100%" wmode="transparent" type="image/svg+xml" />
		</td>
		<td align="right" valign="bottom" width="50%" >
		<embed src="images/back.svg" width="100%" height="100%" wmode="transparent" type="image/svg+xml" />
		</td>
	</tr>
</table>
</form>
</body>
</html>

bpat1434

where id query2 go?

jennifer_ann

Ok now I'm only getting an error on this line

	print "<td><input type = 'button' name = '$file' value = '$filename' </td>";

With an error saying

Notice: Undefined variable: filename in c:\program files\easyphp1-8\www\mapquery.php on line 54

jennifer_ann

I combined the two queries

bpat1434

okay, then the new code woudl be:

<html>
<head>
	<title>Eye Contact - Century to Century</title>
	<link rel="stylesheet" href="eye01.css" type="text/css" />
</head>


<body>
<form name = "display" method = "post" action = "http://localhost/display.php">
<?php
print "<table width='100%' border='1' height = '90%'>";
$db = mysql_connect("localhost","root","");
if (!$db)
{
	print "error - Could not connect to MySQL";
	exit;
}

$er = mysql_select_db("touch_art1");
if(!$er)
{
	print "error - Could not select the database";
	exit;	
}

extract($_POST);

$query = "SELECT filename, yr_left, city_origin, country_origin, yr_arrival, city_arrival, state_arrival FROM story WHERE country_origin = '$search_country' AND pamapproved = 'Y' ORDER BY yr_left";
$result = mysql_query($query);


print "<tr height = '15%'>";
print "<th class='theader'>File</th>";
print "<th class='theader'>Year Left</th>";
print "<th class='theader'>City Origin</th>";
print "<th class='theader'>Country Origin</th>";
print "<th class='theader'>Year Arrived</th>";
print "<th class='theader'>City Arrived</th>";
print "<th class='theader'>State Arrived</th></tr>";


while($row = mysql_fetch_array($result))
{
	print "<tr height = '30%'>";
	foreach($row as $key=>$val)
	{
		if($key == 'filename')
			print "<td><input type = 'button' name = 'file' value = '$val'></td>";
		else
			print "<td class='tdata'>$val</td>";
	}
	print "</tr>";
}

print "</table>";

mysql_free_result($result);
mysql_free_result($result2);

mysql_close();
?>
	<input type="hidden" name="" value="none">
<table width = "100%" border = "0" height = "10%">
	<tr height = "10%">
		<td align="left" valign="bottom" width="50%" >
		<embed src="images/home.svg" width="100%" height="100%" wmode="transparent" type="image/svg+xml" />
		</td>
		<td align="right" valign="bottom" width="50%" >
		<embed src="images/back.svg" width="100%" height="100%" wmode="transparent" type="image/svg+xml" />
		</td>
	</tr>
</table>
</form>
</body>
</html>

jennifer_ann

I guess when I was thinking about it logically I didn't really NEED two seperate queries. The only different between the two is that I was looking for 1 extra field called the filename, which is in the same table as the other colums I was trying to get. So I just combined those to come up with 1 query result

jennifer_ann

LOL hey that works perfect but it prints everything twice so I'm going to take out the

mysql_free_result($result2);

And try it now 🙂

jennifer_ann

YAY! How do I mark resolved?

bpat1434

lol... check my sig....

jennifer_ann

Thank you for your help pat 🙂