upload of specific files, jpg. pdf

billhobbs

I've been working on this all day long, I still really new to php so I'm not sure where I'm making my mistake. I want the user to be able to upload only certain types of files. My code as it is allows the user to upload virtually anything. I want it to give them an error message before going any further when they try to upload anything that isn't in the array. Here is my code, any help would be greatly appreciated.

The number of files available to upload is determined by a form on the previously viewed page.

<?
// start of dynamic form
$uploadNeed = $POST['uploadNeed'];
for($x=0;$x<$uploadNeed;$x++){
?>
<input name="uploadFile<? echo $x;?>" type="file" id="uploadFile<? echo $x;?>">
</p>
<?
// end of for loop
}
?>
<p>
<input name="uploadNeed" type="hidden" value="<? echo $uploadNeed;?>">
<input name="filename" type="hidden" id="filename" value="
<?
$UploadExts = array('gif','jpeg','jpg');
$uploadNeed = $POST['uploadNeed'];
*
// start for loop
for($x=0;$x<$uploadNeed;$x++){

// strip file_name of slashes
$file_name = stripslashes($file_name);
$file_name = str_replace("'","",$file_name);
$file_name = $_FILES['uploadFile'. $x]['name']['type'];
$file_ext = strtolower(substr($file_name,strrpos($file_name,".")));

//File Extension Check
if (!in_array($file_ext, $FILE_EXTS))
$copy = copy($_FILES['uploadFile'. $x]['tmp_name'],$file_name);
else
$message = "Sorry, $file_name($file_type) is not allowed to be uploaded.";

// check if successfully copied
if($copy){
echo "$file_name | uploaded Successfully!><br>";
}else{
echo "$file_name | Could Not Be Uploaded!<br>";
}
}
// end of loop
?>">

sfullman

a few thoughts:

no way (to my knowledge) to process this script until after the files have finished loading - with jpgs that can be a while. Suggest you check on the client side with javascript:

function check_ext(myFileElementId){
   var reg=/((jpg)|(gif)|(tiff)|(pdf)|(png))$/i;
   if(!document.getElementById(myFileElementId).value.match(reg)){
      alert('This extension is not allowed only ... extensions are allowed');
      //clear the file element
      document.getElementById(myFileElementId).outerHTML='<input type="file" name="uploadFile" id="uploadFile" onChange="check_ext(this.id)">';
   }

}

your coding should be more like this:

if(is_uploaded_file($x=$_FILES['uploadFile']['tmp_name'])){
   move_uploaded_file($x, '/final/destination/of/file/' . $_FILES['uploadFile']['name']);

}

on the logical block after //File Extension Check , your logic is just flipped around wrong - take a look
finally, on that same block, you should get in the habit of using curly braces :-)

billhobbs

I tried that and it didn't work either. Here is the code.

<form action="1CarUploadProcess.php" method="post" enctype="multipart/form-data" name="Car1Form" id="Car1Form">
<p>
<?
// start of dynamic form
$uploadNeed = $POST['uploadNeed'];
for($x=0;$x<$uploadNeed;$x++){
?>
<input name="uploadFile<? echo $x;?>" type="file" id="uploadFile<? echo $x;?>">
</p>
<?
// end of for loop
}
?>
<p>
<input name="uploadNeed" type="hidden" value="<? echo $uploadNeed;?>">
<input name="filename" type="hidden" id="filename" value="
<?
$UploadExts = array('gif','jpeg','jpg');
$uploadNeed = $POST['uploadNeed'];

// start for loop
for($x=0;$x<$uploadNeed;$x++){

//File Extension Check
if (!in_array($file_ext, $FILE_EXTS))
$message = "Sorry, $file_name($file_type) is not allowed to be uploaded.";
else
$copy = copy($_FILES['uploadFile'. $x]['tmp_name'],$file_name);

if(is_uploaded_file($x=$FILES['uploadFile']['tmp_name'])){
move_uploaded_file($x, 'http://www.bsketched.com/upload/uploaded/' . $FILES['uploadFile']['name']);

}

// check if successfully copied
if($copy){
echo "$file_name | uploaded Successfully!><br>";
}else{
echo "$file_name | Could Not Be Uploaded!<br>";
}
}
// end of loop
?>">
<br>
<input type="submit" name="Submit" value="Continue">
<br>
<script language="JavaScript" type="text/JavaScript">
function check_ext(myFileElementId){
var reg=/((jpg)|(gif)|(tiff)|(pdf)|(png))$/i;
if(!document.getElementById(myFileElementId).value.match(reg)){
alert('This extension is not allowed only ... extensions are allowed');
//clear the file element
document.getElementById(myFileElementId).outerHTML='<input type="file" name="uploadFile" id="uploadFile" onChange="check_ext(this.id)">';
}

}
</script>
</p>
<p>  </p>
<p>  </p>
</form>