[RESOLVED] Confused on OOP DB connect and array (first attempt at OOP)

[dmacman1962]

Hi all,

I found these examples (by the way, I am WIDE OPEN to any BETTER examples) on making an OOP class for my database (and table select) connections.

But when I test it, I am getting an array for my table, but the title is the same for all rows??? And the loop for all rows only gives rows 2-5 (there are 5 total rows in this table).

Here is what I get...

Single Row

VideoID: 1
Title: Is America #One?

Output All rows

VideoID: 2 Title: Is America #One?
Output All rows

VideoID: 3 Title: Is America #One?
Output All rows

VideoID: 4 Title: Is America #One?
Output All rows

VideoID: 5 Title: Is America #One?
Number of rows: 5
Warning: mysql_close(): supplied argument is not a valid MySQL-Link resource in /home/inthecla/public_html/Don/mysql_class.php on line 16

And the code (from all 3 files) is...

 (passwords.php)
$host = 'localhost';
$name = 'x';
$pass = 'x';

 (mysql_class.php)
class mysql {

function Connect($host, $name, $pass, $db){

$connection = mysql_connect("$host", "$name", "$pass");
mysql_select_db("$db", $connection) OR DIE (mysql_error());

}//ends the connection function

function Close(){

mysql_close($this->connection);

}//ends the close function <-----------------------------This is Line 16 (the error from the output)

function FetchRow($query){
$rows = mysql_fetch_row($query);
return $rows;
}

function FetchArray($query){
$array = mysql_fetch_array($query);
return $array;
}

function FetchNum($query){
$num = mysql_num_rows($query);
return $num;
}

function Query($sql){
$query = mysql_query($sql) or die(mysql_error());
return $query;
}//ends the query function

}//ends the class

and the output...

 (testconnect.php)
//select the table and db
$table = 'Videos';
$db = 'Main_table';

//include the needed name/password
include("includes/passwords.php");
include("mysql_class.php");

//make a new db connection
$DB = new mysql();

//connect
$connection = $DB->Connect($host, $name, $pass, $db);

//define an SQL statement and execute it
$sql = "SELECT * FROM " . $table;
$query = $DB->Query($sql);

//fetch a single row and output it
$newsrow = $DB->FetchRow($query);
$VideoID = $newsrow[0];
$Title = $newsrow[1];
echo "<b>Single Row</b><br /><br />VideoID: $VideoID<br>
Title: $Title<br><br>";

//output all rows from the statement
while($array = $DB->FetchArray($query)){
extract($array);
echo "<b>Output All rows</b><br /><br />VideoID: $VideoID<b>
Title: $Title<br />";
}

//find the number of rows
$num = $DB->FetchNum($query);
echo "Number of rows: $num";

//close the connection
$DB->Close($sql);

I am just looking for some direction and is this a good way to approach an OOP solution for connecting and selecting from my tables?

I found more complex example, but if course, to complex for me to comprehend (yet, I am working on understanding them eventually).

Thanks in advance,

Don

[samudasu]

The reason your only getting rows 2-5 is because you've already used FetchRow and that's moved the internal data pointer ahead to row 2. Get rid of the call to FetchRow and use FetchArray by itself. I'm also thinking that your setting of $Title = $newsrow[1] may be the reason why you're seeing the same title over and over. When you do FetchArray and extract, are you sure you have a field named "Title" in your database? Could it possibly be "title"? Do like below and see what's inside $array.

while ($array = $DB->FetchArray($query)) {
print "<pre>";
print_r($array);
print "</pre>";

The Close function doesn't take a paramater so it should just be $DB->Close(); but it still may not work because it won't know what $this->connection is until you set "var $connection;" underneath the class declaration and change $connection in the Connect function to $this->connection.

class mysql {
    var $connection;
    function Connect($host, $name, $pass, $db){
    $this->connection = mysql_connect("$host", "$name", "$pass");

[dmacman1962]

Hi samudasu,

Your suggestions worked great.

I removed FetchRow and changed the name from Title to Name (which is the correct label in the table).

Also, I fixed the close function, and no more errors.

One note: the ...

while ($array = $DB->FetchArray($query)) {
print "<pre>";
print_r($array);
print "</pre>";
}

produced no results.

Thanks a lot.

Don

[samudasu]

I'm glad it's working for you. I'm not sure why you couldn't see the results of print_r($array). Doing a print_r on an array will show you all the internals (keys and values) of the array. <pre></pre> just formats it nicely. I guess it doesn't matter at this point since you've got it working but just for future reference it's a great debugging tool.