[RESOLVED] Effecient Coding

[obrienkev]

Hi all,

Is there a more effecient way of using the below instead of many if/else clauses?

if(isset($centralised_priced))
{
    $centralised_priced = 'Yes';
}
else {
		$centralised_priced = 'No';
}

// Check Fund Holdings - Equities
if(isset($holdings_equities))
{
 		$holdings_equities = 'Yes';
}
else {
		$holdings_equities = 'No';
}

// Check Fund Holdings - Bonds
if(isset($holdings_bonds))
{
 		$holdings_bonds = 'Yes';
}
else {
		$holdings_bonds = 'No';
}

// Check Fund Holdings - Futures
if(isset($holdings_futures))
{
 		$holdings_futures = 'Yes';
}
else {
		$holdings_futures = 'No';
}

// Check Fund Holdings - Options
if(isset($holdings_options))
{
 		$holdings_options = 'Yes';
}
else {
		$holdings_options = 'No';
}

// Check Fund Holdings - Swaps
if(isset($holdings_swaps))
{
 		$holdings_swaps = 'Yes';
}
else {
		$holdings_swaps = 'No';
}

[saraadmin]

Looks perfectly efficient to me. If you mean you want shorter code you can use the ternary operator:

$centralised_priced = (isset($centralised_priced)) ? 'Yes' : 'No';

(Hows that recusrive function coming on, BTW?)

[laserlight]

There is a more concise way, i.e. use the ternary operator, but that still is a variant of the if-else construct.

You could use variable variables, but I dont think that actually improves efficiency - it may even be worse.

Is this a bottleneck in your code? Chances are you shouldnt even bother with improving it since it is readable and easy to understand, and at the same time doesnt lend itself to an immediate optimisation. If you do want to optimise it, I think you have to restructure your code further, upon which we will need to know what you are actually trying to do in order for us to make proper suggestions.

[Installer]

...readable and easy to understand...

The reason for high-level languages in the first place. It seems to be a common conception that fewer lines equals greater efficiency, which is not neccessarally and not that often so. For example, "if...else" is "if...else" no matter what tokens it's written with. Why not use the ones that don't need translation?

[obrienkev]

Great. Thaks guys.