Why are my images coming out as black jpegs?

WMUWSE

Hi guys,

I've written a script to create thumbnails of my images. Here is my code.

list($width, $height) = getimagesize($filename);
$new_height = 100;
$new_width = ($new_height / $height) * $width;
$image_p = imagecreate($new_width, $new_height);
$image = imagecreatefromjpeg($filename);
imagecopyresampled($image_p, $image, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
imagejpeg($image_p "images/thumbs/1.jpg", 100);

When I look at images/thumbs/1.jpg it's just a blank image. Anyone have any ideas why this would happen and how I can fix it?

Thanks

ClarkF1

imagejpeg($image_p "images/thumbs/1.jpg", 100);

Shouldn't there be a comma after the p????

It's not ready the source image correctly and this could be the problem

WMUWSE

Thanks for pointing that out! I often seem to miss these things. Well, it started to fix the problem. It now works fine if the $filename is a small (~100K😎 file... But when it's a larger file (~4.6M😎 then no images/thumbs/1.jpg file gets written at all. No errors either. Any ideas what this could be caused by?

ClarkF1

It could be a script execution time limit.

Near the top of the script put in

set_time_limit(x);

Where x is the number of seconds that you want as the max.......

For me I have 300 with is 5 minutes which allowed me to create 200 100px by 100px thumbs from files around 1.5MB

WMUWSE

Hi thanks for the suggestion but that didn't work. I set it to 300 and no go. Also the script didn't run for 5 minutes, it ran almost instantly. Any ideas? Thanks.

Weedpacket

Also check the value of memory_limit in php.ini.

WMUWSE

My memory limit is set at 16MB.