Switch and function problem

mrbaseball34

I am trying to call functions from a switch and it just won't go into the function
at all. I just can't understand why..

Can anyone see the problem???

<html>
<head>
<title>
  AMBL game change page
</title>
</head>
<body onload="document.baseform.gameid_1.focus();">
<?php
$debug = true;
include("board/db/mysql.php");
include("../dbconnect.inc");
$db = new dbstuff;
//if ($_POST["gameid_1"]=='') $gameid_1=1;
$db->connect($dbhost, $dbuser, $dbpw, $dbname, '');
define ("NL", "<br />\n");
if ( isset($_POST["g_change"] ) )
{
  $change_type = $_POST["g_change"];
}
$rainout = false;

echo '<form name="baseform" action="'.$_SERVER['PHP_SELF'].'" method="POST">';
echo '  <fieldset>';
echo '    <legend>';
echo '      Game Numbers:';
echo '    </legend>';
echo '    <input type="text" name="gameid_1" size="4" maxlength="4">&nbsp;&nbsp;&nbsp;';
echo '    <input type="text" name="gameid_2" size="4" maxlength="4"><br /><br />';
echo '  </fieldset>';
echo '  <br />';

$sql = 'SELECT id, teamname '
     . 'FROM teams '
     . 'WHERE active = 1 '
     . 'ORDER BY teamname';

$query = $db->query($sql);

echo '  <fieldset>';
echo '    <legend>';
echo '      Teams:';
echo '    </legend>';
echo '  <select name="team1" size="1">';
while (list($id, $teamname)=$db->fetch_row($query))
{
    // want to add OPEN at bottom so skip here Keeps the 40 option from
    // being added during the loop.
    if ($id <> 40)
    {
        echo '    <option value="' . $id . '">' . $teamname . '</option>';
    }
}
echo '    <option value="40">OPEN</option>';
echo '  </select>&nbsp;&nbsp;Team 1&nbsp;&nbsp;';
//echo '  <br /><br />';
$query = $db->query($sql);
echo '  <select name="team1" size="1">';
while (list($id, $teamname)=$db->fetch_row($query))
{
    // want to add OPEN at bottom so skip here Keeps the 40 option from
    // being added during the loop.
    if ($id <> 40)
    {
        echo '    <option value="' . $id . '">' . $teamname . '</option>';
    }
}
echo '    <option value="40">OPEN</option>';
echo '  </select>&nbsp;&nbsp;Team 2<br /><br />';

echo '  </fieldset>';
echo '  <br />';
echo '  <fieldset>';
echo '    <legend>';
echo '      Switch Type:';
echo '    </legend>';
echo '    <input type="radio" name="g_change" value="0">Rainout&nbsp;&nbsp;';
echo '    <input type="radio" name="g_change" value="1">Game Switch&nbsp;&nbsp;';
echo '    <input type="radio" name="g_change" value="2">Team Switch&nbsp;&nbsp;';
echo '    <input type="radio" name="g_change" value="3">Cancel&nbsp;&nbsp;';
echo '    <input type="radio" name="g_change" value="4">Clear Game Scores<br /><br />';
echo '  </fieldset>';
echo '  <input type="submit" name="Submit" value="Edit this game">';
echo '</form>';
echo '</body>';
echo '</html>';

  switch ($change_type)
  {
  case $change_type === "0":
    doRainout;
    $rainout = true;
    // No need to send out confirmation emails for Rainouts...
    break;
  case $change_type === "1":
    // doGameSwitch;
    // SendConfirmationEmails($change_type);
    break;
  case $change_type === "2":
    // doTeamSwitch;
    // SendConfirmationEmails($change_type);
    break;
  case $change_type === "3":
    doCancel;
    SendConfirmationEmails($change_type);
    break;
  case $change_type === "4":
    clearGameScores;
    break;
  }

function doCancel() {
  echo 'in doCancel';
  if ( isset($_POST["gameid_1"]) ) {
    $game_num = $_POST["gameid_1"];
    $sql = 'update games set';
    $sql = $sql.' homescore=777, visitorscore=777 where gamenum='.$game_num;
    $query = $db->query($sql);
  } else {
    //die "You must select a game to Cancel";
  }
}

function doRainout() {
 $rainout = true;
 if ( isset($_POST["gameid_1"]) ) {
   $game_num = $_POST["gameid_1"];
   $sql = 'update games set';
   $sql = $sql.' homescore=999, visitorscore=999 where gamenum='.$game_num;
   $query = $db->query($sql);
 } else {
   //die "You must select a game to Cancel";
 }
}

function clearGameScores() {
 if ( isset($_POST["gameid_1"]) ) {
   $game_num = $_POST["gameid_1"];
   $sql = 'update games set';
   $sql = $sql.' homescore=null, visitorscore=null where gamenum='.$game_num;
 } else {
   //die "You must select a game to Cancel";
 }
}

function SendConfirmationEmails($change_type) {
  echo "Sending Confirmation Emails for ".$change_type;
}

?>

thorpe

Your switch syntax is incorrect. These lines...

case $change_type === "0":

Should be...

case 0:

mrbaseball34

If I do this:

  case $change_type === "3":
    echo "doCancel";
    doCancel;
    break;

or this:

  case "3":
    echo "doCancel";
    doCancel;
    break;

I get the echo. But it won't go into the function doCancel;

thorpe

Didn't even see that....

case 3:
    echo "doCancel";
    doCancel();
    break;

php thinks doCancel is a constant. doCancel() is a call to the function do Cancel.

mrbaseball34

OK, I made the change like you showed but then now it is going into the
doRainout function when I just LOAD the page.

It just goes into doRainout, echoes "in doRainout" and dies...

<html> 
<head> 
<title> 
  AMBL game change page 
</title> 
</head> 
<body onload="document.baseform.gameid_1.focus();"> 
<?php 
$debug = true; 
include("board/db/mysql.php"); 
include("../dbconnect.inc"); 
$db = new dbstuff; 
//if ($_POST["gameid_1"]=='') $gameid_1=1; 
$db->connect($dbhost, $dbuser, $dbpw, $dbname, ''); 
define ("NL", "<br />\n"); 
if ( isset($_POST["g_change"] ) ) 
{ 
  $change_type = $_POST["g_change"]; 
} 
$rainout = false; 

echo '<form name="baseform" action="'.$_SERVER['PHP_SELF'].'" method="POST">'; 
echo '  <fieldset>'; 
echo '    <legend>'; 
echo '      Game Numbers:'; 
echo '    </legend>'; 
echo '    <input type="text" name="gameid_1" size="4" maxlength="4">&nbsp;&nbsp;&nbsp;'; 
echo '    <input type="text" name="gameid_2" size="4" maxlength="4"><br /><br />'; 
echo '  </fieldset>'; 
echo '  <br />'; 

$sql = 'SELECT id, teamname ' 
     . 'FROM teams ' 
     . 'WHERE active = 1 ' 
     . 'ORDER BY teamname'; 

$query = $db->query($sql); 

echo '  <fieldset>'; 
echo '    <legend>'; 
echo '      Teams:'; 
echo '    </legend>'; 
echo '  <select name="team1" size="1">'; 
while (list($id, $teamname)=$db->fetch_row($query)) 
{ 
    // want to add OPEN at bottom so skip here Keeps the 40 option from 
    // being added during the loop. 
    if ($id <> 40) 
    { 
        echo '    <option value="' . $id . '">' . $teamname . '</option>'; 
    } 
} 
echo '    <option value="40">OPEN</option>'; 
echo '  </select>&nbsp;&nbsp;Team 1&nbsp;&nbsp;'; 
//echo '  <br /><br />'; 
$query = $db->query($sql); 
echo '  <select name="team1" size="1">'; 
while (list($id, $teamname)=$db->fetch_row($query)) 
{ 
    // want to add OPEN at bottom so skip here Keeps the 40 option from 
    // being added during the loop. 
    if ($id <> 40) 
    { 
        echo '    <option value="' . $id . '">' . $teamname . '</option>'; 
    } 
} 
echo '    <option value="40">OPEN</option>'; 
echo '  </select>&nbsp;&nbsp;Team 2<br /><br />'; 

echo '  </fieldset>'; 
echo '  <br />'; 
echo '  <fieldset>'; 
echo '    <legend>'; 
echo '      Switch Type:'; 
echo '    </legend>'; 
echo '    <input type="radio" name="g_change" value="0">Rainout&nbsp;&nbsp;'; 
echo '    <input type="radio" name="g_change" value="1">Game Switch&nbsp;&nbsp;'; 
echo '    <input type="radio" name="g_change" value="2">Team Switch&nbsp;&nbsp;'; 
echo '    <input type="radio" name="g_change" value="3">Cancel&nbsp;&nbsp;'; 
echo '    <input type="radio" name="g_change" value="4">Clear Game Scores<br /><br />'; 
echo '  </fieldset>'; 
echo '  <input type="submit" name="Submit" value="Edit this game">'; 
echo '</form>'; 
echo '</body>'; 
echo '</html>'; 

switch ($change_type)
{
case 0:
  doRainout();
  // No need to send out confirmation emails for Rainouts...
  break;
case 1:
  doGameSwitch();
  SendConfirmationEmails($change_type);
  break;
case 2:
  doTeamSwitch();
  SendConfirmationEmails($change_type);
  break;
case 3:
  doCancel();
  SendConfirmationEmails($change_type);
  break;
case 4:
  clearGameScores();
  break;
}

function doGameSwitch() {
  echo "in doGameSwitch";
}
function doTeamSwitch() {
  echo "in doTeamSwitch";
}

function doRainout() {
  echo "in doRainout";
  $rainout = true;
  if ( isset($_POST["gameid_1"]) ) {
    $game_num = $_POST["gameid_1"];
    $sql = 'update games set';
    $sql = $sql.' homescore=999, visitorscore=999 where gamenum='.$game_num;
    $query = $db->query($sql);
  } else {
    die("You must select a game to Rainout");
  }
}

function doCancel() {
  echo 'in doCancel';
  if ( isset($_POST["gameid_1"]) ) {
    $game_num = $_POST["gameid_1"];
    $sql = 'update games set';
    $sql = $sql.' homescore=777, visitorscore=777 where gamenum='.$game_num;
    $query = $db->query($sql);
  } else {
    die("You must select a game to Cancel");
  }
}

function clearGameScores() {
  echo "in clearGameScores";
  if ( isset($_POST["gameid_1"]) ) {
    $game_num = $_POST["gameid_1"];
    $sql = 'update games set';
    $sql = $sql.' homescore=null, visitorscore=null where gamenum='.$game_num;
  } else {
    die("You must select a game to Clear");
 }
}

function SendConfirmationEmails($change_type) { 
  echo "Sending Confirmation Emails for ".$change_type; 
} 

?>

thorpe

You'll need to wrap your entire switch in a check to see if the form was posted. 0 equals false in php which is why it is going into doRainout.

if (isset($_POST['submit'])) {
  switch() {
  }
}

mrbaseball34

That got it working when I changed to 'Submit'.

Now I get this in doRainout:
"Fatal error: Call to a member function on a non-object in /home/austin1/public_html/gamechange.php on line 127"

Seems the $db variable isn't being avail in doRainout even though I declared it global

  global $db;
  $db = new dbstuff;

Am I going to have to redeclare it in the doRainOut function?

thorpe

Yes. And its best to avoid global vars if possible.