[RESOLVED] Not Able to Delete

reflash

I've written a script to display all records in a database table and allow the user to select a record for deletion by entering it's ID number into a form at the bottom of the page. When they click on the Submit button, it refreshes the page & shows the entire record that they selected and it asks if they're sure that they want to delete it. There's 2 radio buttons that that allow them to select either "Yes" or "No". Everything is working fine up to that point. Where I run into problems is that no matter whether they choose yes or no, the record does not get deleted. :mad:

Here's what I've got:

<?php

$page="del1";

include ('../parts/header.php');

// Set Mysql Variables
$host='xxxxxx'; 
$user='xxxxxx';
$pass='xxxxxx';
$db='xxxxxx';
$table='xxxxxx';

// Connect to Mysql, select the correct database, and run the query which adds the data gathered from the form into the database

mysql_connect($host, $user, $pass) or die('Connection died!');

mysql_select_db($db) or die('Selection died!');

if(isset($_POST['dadd'])){

$did=$_POST['did'];

$sel="SELECT * FROM $table WHERE id = $did LIMIT 1";

$result=mysql_query ($sel);

$show=mysql_fetch_array($result);

print "Are you sure you want to delete this record?<br /><br />\n\n";
print "<table width=\"50%\" border=\"2\">\n\n\t<tr>\n\t\t<td width=\"15%\" align=\"center\">ID</td>\n\t\t";
print "<td width=\"40%\" align=\"center\">NAME</td>\n\t\t<td width=\"45%\" align=\"center\">CATEGORY</td>";
print "\n\t</tr>\n\n\t<tr>\n\t\t<td width=\"15%\" align=\"center\">{$show['id']}</td>\n\t\t";
print "<td width=\"40%\" align=\"center\">{$show['name']}</td>\n\t\t<td width=\"45%\" align=\"center\">";
print "{$show['cat']}</td>\n\t</tr>\n\n</table>";
print "<form action=\"del.php\" method=\"post\">\n\t";
print "<input type=\"radio\" name=\"sure\" value=\"Yes\" />Yes&nbsp&nbsp&nbsp&nbsp";
print "<input type=\"radio\" name=\"sure\" value=\"No\" checked=\"checked\" />No<br /><br />";
print "<input type=\"submit\" name=\"yup\" value=\"Submit\" />";
print "</form><br />";

}else{

$query="SELECT * FROM $table ORDER BY name";

$result=mysql_query($query);

$count=1;

print "<h2><i>DELETE AN ENTRY</i></h2>";
print "<table width=\"100%\">";
print "\n\n\t<tr>\n\t";

while ($row=mysql_fetch_array($result)){

print "\t<td width=\"5%\" align=\"left\"><font color=\"#dd0022\"><b>{$row['id']}</b></font></td>\n\t\t";
print "<td width=\"15%\" align=\"left\">{$row['name']}</td>\n\t\t<td width=\"30%\" align=\"left\">";
print "<font color=\"#0022dd\">{$row['cat']}</font></td>\n\t";

if ($count == 2){

print "</tr>\n\n\t<tr>\n\t\t";

$count=1;

}else{

$count++;

}

}

if ($count == 2){

print "</tr>\n\n";

}else{

print "<td width=\"5%\">&nbsp</td>\n\t\t<td width=\"15%\">&nbsp</td>\n\t\t<td width=\"30%\">&nbsp</td>\n\t";

}

print "</tr>\n\n</table>\n\n";

print "<form action=\"del.php\" method=\"post\">\n\t";
print "<input type=\"text\" name=\"did\" SIZE=\"5\" /><br />\n\t";
print "<input type=\"submit\" value=\"Input\" name=\"dadd\">&nbsp&nbsp<input type=\"reset\">\n";
print "</form><br />";

include ('../parts/footer.php');

}

if (isset($_POST['yup'])){

if ($_POST['sure'] == "Yes"){

$query = "DELETE FROM $table WHERE id = {$show['id']} LIMIT 1";

$result = mysql_query($query);

}

}

?>

If anyone could shed some light on this mystery, I would be most grateful...

bretticus

One of your conditions for getting the $show array is if(isset($_POST['dadd'])) that's great for the first pass but once you resubmit, that POST var is not present. Which means if you echo out your $query = "DELETE FROM $table WHERE id = {$show['id']} LIMIT 1"; line you'll see something like "DELETE FROM xxxxxx WHERE id = LIMIT 1." Use a hidden value with the "did" result as your hidden field value and use that instead. If you want some more user-friendly methods for doing this (like checkboxes where you can delete mulitple records), just let me know.

reflash

Hi bretticus, Thanks for the reply. So what you're saying is that if I add a hidden input for $did in the first form (right after "$show=mysql_fetch_array($result);") and then use that in the form at the end of the code, rather than {$show['id']} it should then work? I'll try that.

Thanks for your offer of the user-friendly methods for doing this (especially the checkboxes for multiple records). I'd like to see that.

reflash

bretticus, I tried what you suggested, but it's still giving the same results. Here's what I have:

$show=mysql_fetch_array($result);

print "Are you sure you want to delete this record?<br /><br />\n\n";
print "<table width=\"50%\" border=\"2\">\n\n\t<tr>\n\t\t<td width=\"15%\" align=\"center\">ID</td>\n\t\t";
print "<td width=\"40%\" align=\"center\">NAME</td>\n\t\t<td width=\"45%\" align=\"center\">CATEGORY</td>";
print "\n\t</tr>\n\n\t<tr>\n\t\t<td width=\"15%\" align=\"center\">{$show['id']}</td>\n\t\t";
print "<td width=\"40%\" align=\"center\">{$show['name']}</td>\n\t\t<td width=\"45%\" align=\"center\">";
print "{$show['cat']}</td>\n\t</tr>\n\n</table>";
print "<form action=\"del.php\" method=\"post\">\n\t";
print "<input type=\"radio\" name=\"sure\" value=\"Yes\" />Yes&nbsp&nbsp&nbsp&nbsp";
print "<input type=\"radio\" name=\"sure\" value=\"No\" checked=\"checked\" />No<br /><br />";
print "<input type=\"submit\" name=\"yup\" value=\"Submit\" />";
print "<input type=\"hidden\" name=\"rid\" value=\"'.$did.'\" />";
print "</form><br />";

}else{

Note the hidden input. I also tried the hidden input without the '. and .' around $did - no dice. At the end of the code, I have this:

if (isset($_POST['yup'])){

if ($_POST['sure'] == "Yes"){

$rid=$_POST['rid'];

$query = "DELETE FROM $table WHERE id = $rid LIMIT 1";

$result = mysql_query($query);

}

}

?>

Would I have to use 2 separate documents to do this? Does it have to do with nesting if statements?

reflash

Never mind - I fixed it. I was making multiple fixes at a time, and didn't test all possibilities. betticus: you were absolutely right - it was the hidden input that did it. When I tried it without the '. and .' around $did and with the $rid=$_POST['rid']; (which I forgot the first time around... :queasy: ) it worked. Thanks again for your help! I would like to see the other items you mentioned in your post, if you have the time.

bretticus

Here's a very basic example

Put this at the top of your page before you query from the database

if ( isset($_POST['Submit']) ) {
	foreach ($_POST['did'] as $did) {
		mysql_query("DELETE FROM xxxxx WHERE id = $did");
	}	
}

When you're printing your database records, use the the array brackets in HTML "[]" for the checkbox value. This tells PHP to treat multiple values for that name as an array in the $_POST superglobal.

print "<INPUT TYPE=\"checkbox\" NAME=\"did[]\" VALUE=\"{$row['id']}\">{$row['name']}\n";

If you wanted the "yes" "no" dialogue for each you could build out a form with hidden fields again where I have used a DELETE query. However, I would make it simple and just do

print"<INPUT TYPE=\"submit\" NAME=\"Submit\" VALUE=\"Submit\" ONCLICK=\"return confirm('Are you sure you want to delete selected records?')\">\n";

and make use of ultra simple javascript.