Uploads Files Twice, Want Only Once

[billhobbs]

I've got 2 pages, one uploads the files and the second shows what files were uploaded. I've been told that what I'm doing is uploading the files twice. What would I strip out of my code so that it doesn't do that.
Here is the code for the first page that allows you to upload the files:

<?
$num_of_uploads=$_POST['uploadNeed'];
$file_types_array=array("jpg", "JPG", "pdf", "PDF");
$max_file_size=1048576;
$upload_dir="";

function uploaderFILES($num_of_uploads=1, $file_types_array=array("jpg", "JPG", "pdf", "PDF"), $max_file_size=1048576, $upload_dir=""){
  if(!is_numeric($max_file_size)){
   $max_file_size = 1048576;
  }
  foreach($_FILES["file"]["error"] as $key => $value)
  {
     if($_FILES["file"]["name"][$key]!="")
     {
       if($value==UPLOAD_ERR_OK)
       {
         $origfilename = $_FILES["file"]["name"][$key];
         $filename = explode(".", $_FILES["file"]["name"][$key]);
         $filenameext = $filename[count($filename)-1];
         unset($filename[count($filename)-1]);
         $filename = implode(".", $filename);
         $filename = substr($filename, 0, 15).".".$filenameext;
         $file_ext_allow = FALSE;
         for($x=0;$x<count($file_types_array);$x++){
           if($filenameext==$file_types_array[$x])
           {
             $file_ext_allow = TRUE;
           }
         } // for
         if($file_ext_allow){
           if($_FILES["file"]["size"][$key]<$max_file_size){
             if(move_uploaded_file($_FILES["file"]["tmp_name"][$key], $upload_dir.$filename)){
               echo("File Uploaded Successfully. - <a href='".$upload_dir.$filename."' target='_blank'>".$filename."</a><br />");
             } 
             else { echo('<font color="#FF0000">'.$origfilename."</font> Was Not Successfully Uploaded<br />");}
           }
           else  { echo('<font color="#FF0000">'.$origfilename."</font> Was Too Big, Not Uploaded<br />"); }
         } // if
         else{ echo('<font color="#FF0000">'.$origfilename." </font>Had An Invalid File Extension<br />");  }
       }
       else{ echo('<font color="#FF0000">'.$origfilename." </font>Was Not Successfully Uploaded<br />");  } // else
     }
  }
} // funtion
?></td>
                <td align="left" valign="top" class="Body">&nbsp;</td>
              </tr>
              <tr class="Body">
                <td align="right" valign="top" class="Body">&nbsp;</td>
                <td align="left" valign="top" class="Body"><?  for($x=0;$x<$num_of_uploads;$x++){
     $form .= "<input type='file' name='file[]'><br><br />";
   }
   $form .= "<input type='submit' value='Submit Information And Upload Files'><strong> Click Here When Ready.</strong><br><br />
   <font color='red'>*</font>Maximum file length (minus extension) is 15 characters. Anything over that will be cut to only 15 characters. Valid file type(s): ";
   for($x=0;$x<count($file_types_array);$x++){
     if($x<count($file_types_array)-1){
       $form .= $file_types_array[$x].", ";
     }else{
       $form .= $file_types_array[$x].".";
     }
   }
   echo($form);
?>

And here is the code that shows what was uploaded:

<?
$num_of_uploads=$_POST['uploadNeed'];
$file_types_array=array("jpg", "JPG", "pdf", "PDF");
$max_file_size=1048576;
$upload_dir="";

function uploaderFILES($num_of_uploads=1, $file_types_array=array("jpg", "JPG", "pdf", "PDF"), $max_file_size=1048576, $upload_dir=""){
  if(!is_numeric($max_file_size)){
   $max_file_size = 1048576;
  }
  foreach($_FILES["file"]["error"] as $key => $value)
  {
     if($_FILES["file"]["name"][$key]!="")
     {
       if($value==UPLOAD_ERR_OK)
       {
         $origfilename = $_FILES["file"]["name"][$key];
         $filename = explode(".", $_FILES["file"]["name"][$key]);
         $filenameext = $filename[count($filename)-1];
         unset($filename[count($filename)-1]);
         $filename = implode(".", $filename);
         $filename = substr($filename, 0, 15).".".$filenameext;
         $file_ext_allow = FALSE;
         for($x=0;$x<count($file_types_array);$x++){
           if($filenameext==$file_types_array[$x])
           {
             $file_ext_allow = TRUE;
           }
         } // for
         if($file_ext_allow){
           if($_FILES["file"]["size"][$key]<$max_file_size){
             if(move_uploaded_file($_FILES["file"]["tmp_name"][$key], $upload_dir.$filename)){
               echo("File Uploaded Successfully. - <a href='".$upload_dir.$filename."' target='_blank'>".$filename."</a><br />");
             } 
             else { echo('<font color="#FF0000">'.$origfilename."</font> Was Not Successfully Uploaded<br />");}
           }
           else  { echo('<font color="#FF0000">'.$origfilename."</font> Was Too Big, Not Uploaded<br />"); }
         } // if
         else{ echo('<font color="#FF0000">'.$origfilename." </font>Had An Invalid File Extension<br />");  }
       }
       else{ echo('<font color="#FF0000">'.$origfilename." </font>Was Not Successfully Uploaded<br />");  } // else
     }
  }
} // funtion


?>
                <?
if(isset($_POST["submitted"])){
   uploaderFILES($num_of_uploads, $file_types_array, $max_file_size, $upload_dir);
}
?>

[hagen00]

from your code i'm finding it very difficult to see where you upload the files.

Basically, files will get uploaded if your form tag has enctype='multipart/form-data' as a property. If you don't want to upload files, remove that property from the form.

[billhobbs]

Thanks, I removed what you suggested from the form. The files are being uploaded into the same directory as the scripts.