problem with code

[slimjim]

Can anyone tell me what is wrong with this code ?

$siteurl="http://www.somesite.com"; 
$recip="http://www.mysite.com"; 

    $conts = @file_get_contents($siteurl); 
    if(preg_match("^<!--.*?".$recip.".*?-->^si", $conts)) 
    { 
        // It's inside a comment: 
        echo 'Link is commented out.'; 
    } 
    else
    {
        echo 'Link is NOT commented out.'; 	        
    }

[Houdini]

I dont see a delimiter try

if(preg_match("#^{<!--.?".$recip.".?-->$#si",} $conts))

also removed the caret at the end and used the $

[slimjim]

Nope that didnt work either....

[slimjim]

what is going on, why is this so dang hard to figure out.

Going nuts

[laserlight]

Well, what do you want to match?

[slimjim]

I want see if a link is in between comment tags...

So in short, if $recip is in comment tags echo link is in comment tags..

Of course I am opening $siteurl to see if this is the case..

[slimjim]

Thought I would post again so a person would not have to do much scrolling..

$siteurl="http://www.somesite.com"; 
$recip="http://www.mysite.com"; 

    $conts = @file_get_contents($siteurl); 
    //if(preg_match("^<!--.*?".$recip.".*?-->^si", $conts)) //does not work
    if(preg_match("#^<!--.*?".$recip.".*?-->$#si", $conts)) // nor this 
    { 
        // It's inside a comment: 
        echo 'Link is commented out.'; 
    } 
    else 
    { 
        echo 'Link is NOT commented out.';              
    }

[laserlight]

$filename = "http://www.somesite.com";
$search_uri = "http://www.mysite.com";

if (($content = file_get_contents($filename)) !== false) {
	if (preg_match('#\<\!\-\-.*' . preg_quote($search_uri) . '.*\-\-\>#si', $content)) {
		echo '"' . $search_uri . '" is commented out';
	} else {
		echo '"' . $search_uri . '" is NOT commented out';
	}
} else {
	echo 'Content from "' . $filename . '" could not be retrieved';
}

[slimjim]

Nope not working correctly either, no matter what I put in for a file name, it shows up as link is commented out.

[laserlight]

Nope not working correctly either, no matter what I put in for a file name, it shows up as link is commented out.

There must be some other problem, then.

Test with:

<?php
$search_uri = "http://www.example.com";

$content = $search_uri . "<!-- hello world -->";

if (preg_match('#\<\!\-\-.*' . preg_quote($search_uri) . '.*\-\-\>#si', $content)) {
	echo '"' . $search_uri . '" is commented out';
} else {
	echo '"' . $search_uri . '" is NOT commented out';
}
?>

[slimjim]

you want me to change example.com or use the code as is.

[laserlight]

Use the code as-is.

[slimjim]

could it be finding the links like this :
<!--- whatever -->
link here
<!--- whatever -->

And taking that as being between comment tags ?

[slimjim]

as is gives me :
"http://www.example.com" is NOT commented out

[laserlight]

could it be finding the links like this :
<!--- whatever -->
link here
<!--- whatever -->

And taking that as being between comment tags ?

Possibly, I neglected to use non-greedy search.

If you want to exclude such possibility change to:

preg_match('#\<\!\-\-.*?' . preg_quote($search_uri) . '.*?\-\-\>#si', $content)

[laserlight]

I'm wrong. It still doesnt work.

[slimjim]

only thing on a page I am testing on is a piece of javascript that has the url in it.
Would it be thinking that is in comment tags, even though there isnt comment tags ?

[laserlight]

Okay, I give up. Here's a solution with preg_match_all() instead:

<?php
$search_uri = "http://www.example.com";

$content = "<!-- hello --> $search_uri <!-- goodbye -->";

if (preg_match_all('#\<\!\-\-(.*?)\-\-\>#si', $content, $matches)) {
	$found = false;
	foreach ($matches[1] as $string) {
		if (strpos($string, $search_uri) !== false) {
			$found = true;
			break;
		}
	}
	echo '"' . $search_uri . '"';
	if ($found) {
		echo ' is commented out';
	} else {
		echo ' is NOT commented out';
	}
} else {
	echo 'Content has no comments';
}
?>

[slimjim]

Ok using your last idea :
I used it as is

"http://www.example.com" is NOT commented out

shouldnt it be Content has no comments ?

This is crazy......

[laserlight]

It is correct. The content has comments, but the URI is not commented out.