help with file download

chapm4

I have uploaded files to mysql (doc and xls) using the tutorial at http://www.php-mysql-tutorial.com

The problem comes when I try to download. Again I followed instructions in the tutorial. When I click on the link to download the file, it formats it as text and sends it to the browser instead of seeing it as binary and offering me a download box.

Can someone please help?

<? 
if(isset($_GET['id'])) 
{ 
    include 'includes/configdb.php'; 
    include 'includes/opendb.php'; 

$id      = $_GET['id']; 
$query   = "SELECT name, type, size, content FROM upload WHERE id = '$id'"; 
$result  = mysql_query($query) or die('Error, query failed'); 
list($name, $type, $size, $content) = mysql_fetch_array($result); 

header("Content-Disposition: attachment; filename=$name"); 
header("Content-length: $size"); 
header("Content-type: $type"); 
echo $content; 

include 'includes/closedb.php';     
exit; 
} 

?> 
<html> 
<head> 
<title>Download File From MySQL</title> 
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> 
</head> 

<body> 
<? 
include 'includes/configdb.php'; 
include 'includes/opendb.php'; 

$query  = "SELECT id, name FROM upload"; 
$result = mysql_query($query) or die('Error, query failed'); 
if(mysql_num_rows($result) == 0) 
{ 
    echo "Database is empty <br>"; 
}  

else 
{ 
    while(list($id, $name) = mysql_fetch_array($result)) 
    { 
?> 
    <a href="download.php?id=<?=$id;?>"><?=$name;?></a> <br> 
<?         

    } 
} 
include 'includes/closedb.php'; 
?> 
</body> 
</html>

snootch

I'm having the same problem. The files are moved and renamed properly by the upload script becuase I can open them fine from the control panel in my web hosting account. However, when I click on the links from the download2.php page it outputs the binary garbage into the browser window instead up opening the file in the application it's associated with (i.e. PDF with Adobe Acrobat).

Can someone please help? I can't seem to find a solution to this problem.

bogu

For download, I use this function from php manual:

Ex.

<?php

function dl_file($file){

   //First, see if the file exists
   if (!is_file($file)) { die("<b>404 File not found!</b>"); }

   //Gather relevent info about file
   $len = filesize($file);
   $filename = basename($file);
   $file_extension = strtolower(substr(strrchr($filename,"."),1));

   //This will set the Content-Type to the appropriate setting for the file
   switch( $file_extension ) {
         case "pdf": $ctype="application/pdf"; break;
     case "exe": $ctype="application/octet-stream"; break;
     case "zip": $ctype="application/zip"; break;
     case "doc": $ctype="application/msword"; break;
     case "xls": $ctype="application/vnd.ms-excel"; break;
     case "ppt": $ctype="application/vnd.ms-powerpoint"; break;
     case "gif": $ctype="image/gif"; break;
     case "png": $ctype="image/png"; break;
     case "jpeg":
     case "jpg": $ctype="image/jpg"; break;
     case "mp3": $ctype="audio/mpeg"; break;
     case "wav": $ctype="audio/x-wav"; break;
     case "mpeg":
     case "mpg":
     case "mpe": $ctype="video/mpeg"; break;
     case "mov": $ctype="video/quicktime"; break;
     case "avi": $ctype="video/x-msvideo"; break;

 //The following are for extensions that shouldn't be downloaded (sensitive stuff, like php files)
 case "php":
 case "htm":
 case "html":
 case "txt": die("<b>Cannot be used for ". $file_extension ." files!</b>"); break;

 default: $ctype="application/force-download";
   }

   //Begin writing headers
   header("Pragma: public");
   header("Expires: 0");
   header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
   header("Cache-Control: public"); 
   header("Content-Description: File Transfer");

   //Use the switch-generated Content-Type
   header("Content-Type: $ctype");

   //Force the download
   $header="Content-Disposition: attachment; filename=".$filename.";";
   header($header );
   header("Content-Transfer-Encoding: binary");
   header("Content-Length: ".$len);
   @readfile($file);
   exit;
}

?>