[RESOLVED] why does this not work

rbblue8

why does this not work?

it does not open the new window.

however when i do just plain html..... it works just fine.

so i just have my close my php tages and do it the html / php way?

print('<a href="http://www.nightlance.com/?link=matches" ONCLICK="window.open("http://www.nightlance.com/match/view/view.php?match='.$Challenged['Match_Id'].', "NewWindow","toolbar=yes,location=yes,directories=no,status=no,menubar=yes,scrollbars=yes,resizable=no,copyhistory=yes,width=635,height=260")">'.$Challenged['Match_Id'].'</a>');

vaaaska

double quotes...too many double quotes...javascript is borking I bet...

rbblue8

sigh

ok.. well i got it work with the mixing of html / php.

like so.

<a id="view_a_tag" href="http://www.nightlance.com/?link=matches" ONCLICK="window.open('http://www.nightlance.com/match/view/view.php?match=<?php echo $challenger['Match_Id'] ?>', 'NewWindow','toolbar=yes,location=yes,directories=no,status=no,menubar=no,scrollbars=yes,resizable=no,copyhistory=yes,width=635,height=600')"><?php echo $challenger['Match_Id'] ?></a>

i know.. bad bad way... but it works.

vaaaska

Sigh?

The issue was a javascript problem...not PHP. You had too many double quotes...I'm adding the returns so it doesn't fall off the page...normally javascript won't like this so I don't recommend using returns in your code...

print("<a href='#' 
onclick=\"window.open('/match/view/view.php?match=$Challenged[Match_Id]',
'NewWindow',
'toolbar=yes,location=yes,directories=no,status=no,
menubar=yes,scrollbars=yes,resizable=no,copyhistory=yes,
width=635,height=260');return false;\">$Challenged[Match_Id]</a>");

It's certainly messy and not the most 'readable' code, but as I pointed out, the problem is not PHP, it's javascript and quotes issues (you'll see where I \ the double quote for javascript (which PHP happens to appreciate as well)...

Weedpacket

i know.. bad bad way... but it works.

No, probably the most straightforward. The whole point of PHP was that it could be embedded into HTML. It would get messy if you were going to do a load of processing of that string, but since all you're doing is spitting it straight out then getting PHP to do it is just added overhead.

(Incidentally, if you specify 'yes' for some options, any you don't specify will default to 'no'; so "directories=no" etc. are redundant and can be removed.)