Frustrated with debugging script!

lonebyrd

I'm new to PHP. I'm working on a registration/login page. I have run the registation.php file I have been working on through PHP Builder 2006 and keep coming up with the same error. It says it is a parse error: unexpected $end. Can someone look at this script and tell me what is wrong with it. I don't understand a word of that.

<HTML>
<HEAD>
<TITLE>Fantasized TeleVision</TITLE>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<style type="text/css">

BODY {
    background:#808080;
    text-align:center;
    font-family:Verdana, Arial;
    font-weight:bold;
    font-size:36px;
    color:#FF0000;
       }

register_box
{
    border: 1px solid #0000A0;
    background-color: #0000FF;
    font-family: Verdana, Arial;
    font-weight: bold;
    font-size: 9px;
    color: #FF0000;
    top margin: 200px
    left margin: 200px
    }

</style>
</head>
</html>
<?php
require("config.php");
require("functions.php");
// The following line verifies which action is requested by the user
// by default is setting to new if nothing is requested
$action = (isset($_REQUEST['action'])) ? $_REQUEST['action'] : "new";
switch($action) {
    //--------------------------------------
    //       [New Registration]
    //--------------------------------------

  case "new":
    if(!isset($_POST['register'])) {
        echo "
        <form action='registration.php' method='POST'>
            Name: <br />
            <input type='text' name='name' class='register_box'>
            <br />
            Email: <br />
            <input type='text' name='email' class='register_box'>
            <br />
            Nickname: <br />
            <input type='text' name='nickname' class='register_box'>
            <br />
            Password: <br />
            <input type='password' name='password' class='register_box'>
            <br />
            Location: <br />
            <input type='text' name='location' class='register_box'>
            <br />
            Gender: <br />
            <input type='text' name='gender' class='register_box'>
            <br />
            Date_of_Birth: <br />
            <input type='date' name='date_of_birth' class='register_box'>
            <br />
            <input type='submit' name='register' value='New Registration!' class='register_box'>
            <input type='hidden' name='action' value='new'>
        </form>
        ";
    }
    elseif(isset($_POST['register'])) {
        $name = mysql_real_escape_string($_POST['name']);
        $email = mysql_real_escape_string($_POST['email']);
        $nickname = mysql_real_escape_string ($_POST['nickname']);
        $password = mysql_real_escape_string($_POST['password']);
        $location = mysql_real_escape_string($_POST['location']);
        $gender = mysql_real_escape_string ($_POST['gender']);
        $date_of_birth = mysql_real_escape_string ($_POST['date_of_birth']);
        $activation_code = generateCode(25);
        $nameq = "SELECT ad_name FROM registration WHERE ad_name = '$name' LIMIT 1";
        $emailq = "SELECT ad_email FROM registration WHERE ad_email = '$email' LIMIT 1";
        $nicknameq = "SELECT ad_nickname FROM registration WHERE ad_nickname = '$nickname' LIMIT 1";
        //put errors into an array I need to change these if I change the db
        if(empty($name)) {
            $errors[] = "The name field was blank! <br />";
        }
        if(mysql_num_rows(mysql_query($nameq)) > 0) 
        {    $errors[] = "The name given is already in use! Please try another one! <br />";
        }

        if(empty($email)) {
                $errors[] = "The email field was blank! <br />";
        }
        if(mysql_num_rows(mysql_query($emailq)) > 0) {
            $errors[] = "The email given is already in use! Please try another one! <br />";
        }

        if(empty($nickname)) {
            $errors[] = "The nickname field was blank! <br />";

        if(mysql_num_rows(mysql_query($nicknameq))>0) {
            $error[] = "That nickname is already taken.  Please try another one.<br />";
        }

        if(empty($password)) {
            $errors[] = "The password field was blank! <br />";
        }

        if(empty($location)) {
            $errors[] = "The location field was blank! <br />";
        }

        if(empty($gender)) {
            $errors[] = "The gender field was blank! <br />";
        }

        if(empty($date_of_birth)) {
            $errors [] = "No date of birth was entered! <br />";
        }
        if(count($errors) > 0) {
          foreach($errors as $err) {
            echo $err;
            }
        }
        else {
          $sqlq = "INSERT INTO registration (name, email, nickname, password, location, gender, date_of_birth, is_activated, activation_code)";
          $sqlq .= " VALUES ('$name', '$email', '$nickname', '".md5($password)."', '$location', '$gender', '$date_of_birth', '0', '$activation_code')";
          mysql_query($sqlq) or die(mysql_error());
          echo "Thanks for registering! You will recieve an email shortly containing your validation code, and a link to activate your account!";
          mail($email, "New Registration, www.ftv.astahost.com", "Thanks for registering on FTV.\n\nHere are your login details:\n\nNickname: ".$nickname."\n\nPassword: ".$password."\n\nIn order to login and gain full access, you must validate your account.\n\nClick here to validate:\n\nhttp://www.ftv.astahost.com/registration.php?action=activate&nickname=".$nickname."&code=".$activation_code."\n\nThanks!\n\n[lonebyrd]");              
// \n is equal to a new line
// in your original version you use the variable user to send the nickname data
// to your activation file and in that file you check for a variable nickname, so it never work.
            }
        }
        break;
//--------------------------------------
//       [Activate Account]
//--------------------------------------
   if(isset($_GET['nickname']) && isset($_GET['code']))
   {
      $nickname = mysql_real_escape_string($_GET['nickname']);

  if(mysql_num_rows(mysql_query("SELECT ad_email FROM registration WHERE nickname = '$nickname'")) == 0)
  {
     echo "That username is not in the database!";
  }
  else
  {
     $activate_query = "SELECT is_activated FROM registration WHERE nickname = '$nickname'";
     $is_already_activated = mysql_fetch_object(mysql_query($activate_query)) or die(mysql_error());

     if($is_already_activated->is_activated == '1')
     {
        echo "This user is already activated!";
     }
     else
     {
        $code = mysql_real_escape_string($_GET['code']);
        $code_query = "SELECT activation_code FROM registration WHERE nickname = '$nickname' LIMIT 1";
        $check_code = mysql_fetch_object(mysql_query($code_query)) or die(mysql_error());

        if($code == $check_code->activation_code)
        {
           $update = "UPDATE registration SET is_activated = '1' WHERE nickname = '$nickname'";
           mysql_query($update) or die(mysql_error());
           echo "User $nickname has been activated! Thanks! You may now login!";
        }
        else
        {
           echo "The activation code was wrong! Please try again!";
   }
   Break;
   }



?>

I've tried putting the </head> and </html> before the ?> and it gave me a parse error at the < of the head saying unexpected T_STRING '<'. I'm totally lost as what to do.

FatalError

You never ended your switch statement. Add another { at the end.

Download Notepad 2 (link in my signature) and use that (or alternitavely Notepad++, but I don't like that one as much). It helps find those mistakes easily, and the PHP syntax highlighter is the best I've seen (and easily customizable).

lonebyrd

That did not work. Did you mean to add the { after the } at the very end where the break; was? PHP Designer just doesn't want me to end this thing I guess.

laserlight

That did not work. Did you mean to add the { after the } at the very end where the break; was?

You have a number of missing/mismatched braces.

Line 37: Where is the closing brace for this switch construct?

$action = (isset($_REQUEST['action'])) ? $_REQUEST['action'] : "new";
switch($action) {

Line 99: Where is the closing brace for this if-conditional? The closing brace that matches is on line 136, but I do not think that was what you had in mind.

if(empty($nickname)) {
	$errors[] = "The nickname field was blank! <br />";

Line 142: Can you find the closing brace for this?

if(isset($_GET['nickname']) && isset($_GET['code']))
{

Line 150: What about this one?

else
{

Basically, you need a good text editor that provides line numbering and some way for you to identify matching braces/parentheses/brackets. Both Notepad2 and Notepad++ are suitable (though I prefer the latter for the tabbed interface, nonetheless the former is pretty).

Also, you need to be consistent in your brace placement. You have used:

if (condition) {
	// ...
}

and

if (condition)
{
	// ...
}

Pick one and stick to it.

By the way, FatalError, your link to Notepad2 is wrong. It should be:
http://www.flos-freeware.ch/notepad2.html