Problem

[raouleduke]

What I am trying to do is, have a different coupon for each record based upon the year make model and mileage of a vehicle. I am doing this in the middle of a query, that selects the vehciles. It seems what happens is that when it finds a match it doesn't stop, it keeps going and defaults to the last one. Here is the code.

/////Smart Coupons
			$query171 = "SELECT * FROM coupons WHERE dealer = 'DEALER' and template = 'main' and position = '1'";
			$result171 = mysql_query($query171);
			while ($row171 = mysql_fetch_array($result171)) {
			$coupon1id = $row171["id"];
			$coupon1type = $row171["type"];
			$coupon1year = $row171["year"];
			$coupon1make = $row171["make"];
			$coupon1model = $row171["model"];
			$coupon1mileage_low = $row171["mileage_low"];
			$coupon1mileage_high = $row171["mileage_high"];
			for($i = 0; $i < count($ro); $i++){
			if($coupon1type == 'smart'){
			if(($make = $coupon1make && $model = $coupon1model) || ($nextincrementmileage >= $coupon1mileage_low && $nextincrementmileage <= $coupon1mileage_high)){
				$coupon1text1 = $row171["text_1"];
				$coupon1text2 = $row171["text_2"];
				$coupon1text3 = $row171["text_3"];
				$coupon1text4 = $row171["text_4"];
			}
			}else{
				$query17 = "SELECT * FROM coupons WHERE dealer = 'DEALER' and template = 'main' and position = '1' and type = 'default'";
				$result17 = mysql_query($query17);
				while ($row17 = mysql_fetch_array($result17)) {
				$coupon1text1 = $row17["text_1"];
				$coupon1text2 = $row17["text_2"];
				$coupon1text3 = $row17["text_3"];
				$coupon1text4 = $row17["text_4"];
				}
			}
			}
			}
			print "<td>$coupon1text1</td>
				   <td>$coupon1text2</td>
			       <td>$coupon1text3</td>
			       <td>$coupon1text4</td>";

Let me know what you think. Any idea's.

[ClarkF1]

Use mysql_fetch_assoc rather than mysql_fetch_array

The latter uses numerical keys (i.e. $row171[0]) whereas the former uses the keys from the field titles as you have done (i.e. $row171['model'])

Also is $ro defined elsewhere or did you mean count($row171)

[Houdini]

Actually mysql_fetch_array() by default returns both an indexed and an associative array but it can be forced by using mysql_fetch_array($link,MYSQL_ASSOC)

[raouleduke]

$ro is defined else where, it's the primary key for the records. What is mysql_fetch_assoc going to do. Do I need it to stop somewhere if it finds a match, for each one.

[Houdini]

Source PHP Manual:mysql_fetch_assoc() mysql_fetch_assoc()

Description
array mysql_fetch_assoc ( resource result )

Returns an associative array that corresponds to the fetched row and moves the internal data pointer ahead. mysql_fetch_assoc() is equivalent to calling mysql_fetch_array() with MYSQL_ASSOC for the optional second parameter. It only returns an associative array.

You can do either of these

while ($row171 = mysql_fetch_assoc($result171))

or

while ($row171 = mysql_fetch_array($result171,MYSQL_ASSOC))

and the arrays as written in your code should work

[raouleduke]

That didn't make a difference. How do I get it to stop at the one it is equal to, it seems like that is the problem.

$query171 = "SELECT * FROM coupons WHERE dealer = 'TENVOORDERECOMMEND' and template = 'main' and position = '1'";
			$result171 = mysql_query($query171);
			while ($row171 = mysql_fetch_array($result171,MYSQL_ASSOC))  {
			$coupon1id = $row171["id"];
			$coupon1type = $row171["type"];
			$coupon1year = $row171["year"];
			$coupon1make = $row171["make"];
			$coupon1model = $row171["model"];
			$coupon1mileage_low = $row171["mileage_low"];
			$coupon1mileage_high = $row171["mileage_high"];
			for($i = 0; $i < count($ro); $i++){
			if($coupon1type == 'smart'){
			if(($make = $coupon1make && $model = $coupon1model) || ($nextincrementmileage >= $coupon1mileage_low && $nextincrementmileage <= $coupon1mileage_high)){
				$coupon1text1 = $row171["text_1"];
				$coupon1text2 = $row171["text_2"];
				$coupon1text3 = $row171["text_3"];
				$coupon1text4 = $row171["text_4"];
			}
			}else{
				$query17 = "SELECT * FROM coupons WHERE dealer = 'TENVOORDERECOMMEND' and template = 'main' and position = '1' and type = 'default'";
				$result17 = mysql_query($query17);
				while ($row17 = mysql_fetch_array($result17)) {
				$coupon1text1 = $row17["text_1"];
				$coupon1text2 = $row17["text_2"];
				$coupon1text3 = $row17["text_3"];
				$coupon1text4 = $row17["text_4"];
				}
			}
			}
			}
			print "<td>$coupon1text1</td>
				   <td>$coupon1text2</td>
			       <td>$coupon1text3</td>
			       <td>$coupon1text4</td>";

Let me know what you think.

[raouleduke]

This seems to be working but it's not doing some of the coupons. Let me know what you think.

/////Smart Coupons
			$query171 = "SELECT * FROM coupons WHERE dealer = 'DEALER' and template = 'main' and position = '1'";
			$result171 = mysql_query($query171);
			while ($row171 = mysql_fetch_array($result171,MYSQL_ASSOC))  {
			$coupon1id = $row171["id"];
			$coupon1option = $row171["option"];
			$coupon1year_low = $row171["year_low"];
			$coupon1year_high = $row171["year_high"];
			$coupon1make = $row171["make"];
			$coupon1model = $row171["model"];
			$coupon1mileage_low = $row171["mileage_low"];
			$coupon1mileage_high = $row171["mileage_high"];
			if($coupon1option == '1'){
					if($YEAR >= $coupon1year_low && $YEAR <= $coupon1year_high){
						$coupon1text1 = $row171["text_1"];
						$coupon1text2 = $row171["text_2"];
						$coupon1text3 = $row171["text_3"];
						$coupon1text4 = $row171["text_4"];
						}
			}
			elseif($coupon1option == '2'){
					if($nextincrementmileage >= $coupon1mileage_low && $nextincrementmileage <= $coupon1mileage_high){
						$coupon1text1 = $row171["text_1"];
						$coupon1text2 = $row171["text_2"];
						$coupon1text3 = $row171["text_3"];
						$coupon1text4 = $row171["text_4"];
					}
			}
			elseif($coupon1option == '3'){
					if($MAKE == $coupon1make && $MODEL == $coupon1model){
						$coupon1text1 = $row171["text_1"];
						$coupon1text2 = $row171["text_2"];
						$coupon1text3 = $row171["text_3"];
						$coupon1text4 = $row171["text_4"];
					}
			}
			elseif($coupon1option == '4'){
					if($YEAR >= $coupon1year_low && $YEAR <= $coupon1year_high && $MAKE == $coupon1make && $MODEL == $coupon1model && $nextincrementmileage >= $coupon1mileage_low && $nextincrementmileage <= $coupon1mileage_high){
						$coupon1text1 = $row171["text_1"];
						$coupon1text2 = $row171["text_2"];
						$coupon1text3= $row171["text_3"];
						$coupon1text4 = $row171["text_4"];
					}
			}else{
				$query17 = "SELECT * FROM coupons WHERE dealer = 'DEALER' and template = 'main' and position = '1' and type = 'default'";
				$result17 = mysql_query($query17);
				while ($row17 = mysql_fetch_array($result17)) {
				$coupon1text1 = $row17["text_1"];
				$coupon1text2 = $row17["text_2"];
				$coupon1text3 = $row17["text_3"];
				$coupon1text4 = $row17["text_4"];
				}
			}
			}
			print "<td>$coupon1text1</td>
				   <td>$coupon1text2</td>
			       <td>$coupon1text3</td>
			       <td>$coupon1text4</td>";

Thanks for any help.

[ClarkF1]

You need to add ,MYSQL_ASSOC after $result17 in the call to mysql_fetch_array